Spec URL: http://www.auroralinux.org/people/spot/review/XaraLX.spec SRPM URL: http://www.auroralinux.org/people/spot/review/XaraLX-0.5-1.src.rpm Description: General purpose and vector graphics program, supports photo, graphics, and illustration creation and editing.
Does not build in mock: "autoreconf: failed to run autopoint: No such file or directory" Needs BuildReq: gettext-devel
(In reply to comment #1) > Does not build in mock: > "autoreconf: failed to run autopoint: No such file or directory" > Needs BuildReq: gettext-devel You should not run autoreconf in specs - You should use patches.
The latest version 0.7 rev 1537 builds fine here.
#3 - have you got a spec file you can upload somewhere?
(In reply to comment #4) > #3 - have you got a spec file you can upload somewhere? I simply used the one from comment #1. I suspect that spot is not very interesting in this package anymore or is to busy with other things currently. Maybe someone else can step in?
#5 - someone has. me.
Spec URL: http://www.knox.net.nz/~nodoid/XaraLX.spec SRPM URL: http://www.knox.net.nz/~nodoid/XaraLX-0.7-1.r1564.src.rpm - bump to new version - includes 64 bit fixes - Additional docs - fixed EOL for xaralx.htm - fixed multiple mode errors for header and source files - removed mixed use of spaces and tabs The package builds cleanly on x86_64 with rpmlint not giving a single complaint! I've not built it in mock yet (my testrig is not working happily today from a remote login).
I will review this one. ---------------------------------------- Review for release 1.r1564: * RPM name is OK * Source XaraLX-0.7r1564.tar.bz2 is the same as upstream Needs work: * BuildRequires: perl should not be included (wiki: PackagingGuidelines#Exceptions) * Build failed in mock autoreconf: failed to run autopoint: No such file or directory Minor: * Duplicate BuildRequires: automake (by libtool), autoconf (by libtool), perl (by automake), gtk2-devel (by wxGTK-devel)
Spec URL: http://www.knox.net.nz/~nodoid/XaraLX.spec (I've not uploaded a new src.rpm by agreement with the reviewer) - changed group to Applications/Publishing - fixed autoreconf problem (BR gettext-devel) - removed dupes in BR - removed BR perl - added mime-info - added examples
Spec URL: http://www.knox.net.nz/~nodoid/XaraLX.spec SRPM URL: http://www.knox.net.nz/~nodoid/XaraLX-0.7-1.r1614.src.rpm - bump to newer tarball - Removed the examples from the main package - Created examples subpackage
Spec URL: http://www.knox.net.nz/~nodoid/XaraLX.spec Patch URL : Spec URL: http://www.knox.net.nz/~nodoid/xaralx.desktop.patch - updated spec - fixed desktop file - removed unused (and empty) directory
Looks good Paul. Menu entry shows up now too. APPROVED. Please remember to close this review request once imported and built.
Thanks for that and such an easy review process!