Bug 1933644 - Don't BuildRequires xorg-x11-font-utils
Summary: Don't BuildRequires xorg-x11-font-utils
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: unifont
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Zbigniew Jędrzejewski-Szmek
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 1932731
TreeView+ depends on / blocked
 
Reported: 2021-03-01 10:42 UTC by Peter Hutterer
Modified: 2021-03-19 19:59 UTC (History)
12 users (show)

Fixed In Version: unifont-13.0.05-2.fc34
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2021-03-01 12:46:22 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description Peter Hutterer 2021-03-01 10:42:23 UTC
Explicitly require the tool we actually need instead, xorg-x11-font-utils has had Provides: for this for ages.

xorg-x11-font-utils is to be split up into multiple packages, see Bug 1932731, this ensures the transition goes smoothly.


Suggested diff:

diff --git a/unifont.spec b/unifont.spec
index fe68e06..71c5d93 100644
--- a/unifont.spec
+++ b/unifont.spec
@@ -11,7 +11,7 @@ Source1:         unifont.metainfo.xml
 BuildRequires:   make
 BuildRequires:   gcc
 BuildRequires:   perl-generators
-BuildRequires:   xorg-x11-font-utils
+BuildRequires:   bdftopcf
 BuildRequires:   fontforge
 BuildRequires:   fontpackages-devel
 BuildRequires:   texinfo


Verified successful build in a local F33 container with only the mkfontscale (Bug 1932734) and bdftopcf (Bug 1932736) packages installed.

Comment 1 Zbigniew Jędrzejewski-Szmek 2021-03-01 12:26:20 UTC
I'll apply this. But I think it'd make more sense to submit pull requests for other packages.

Comment 2 Zbigniew Jędrzejewski-Szmek 2021-03-01 12:46:22 UTC
I rebuild this, but actually it doesn't make sense to even create an update, since there's no change
in the binary package.

(I checked the provides in F33 and F32, and we could do the same change there without any harm, but
I don't see the need.)

Comment 3 Peter Hutterer 2021-03-02 00:36:23 UTC
> I'll apply this. But I think it'd make more sense to submit pull requests for other packages.

thanks to running out of disk space, the initial list of packages was much smaller than the final list...
creating the bugs seemed like the more prudent (and trackable) solution. Don't think I'll do that again now that I have all spec files locally :)

thanks for the push, much appreciated.

> I rebuild this, but actually it doesn't make sense to even create an update, since there's no change in the binary package.

dnf would still fetch the old one with the wrong BR, so I think a new build would be a good idea here. Otherwise there's the slim chance of a srpm rebuild failing when
we move bdftopcf out of -utils.

Comment 4 Fedora Update System 2021-03-02 08:08:27 UTC
FEDORA-2021-929a0acb1c has been submitted as an update to Fedora 34. https://bodhi.fedoraproject.org/updates/FEDORA-2021-929a0acb1c

Comment 5 Fedora Update System 2021-03-03 15:43:21 UTC
FEDORA-2021-929a0acb1c has been pushed to the Fedora 34 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --advisory=FEDORA-2021-929a0acb1c`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2021-929a0acb1c

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 6 Fedora Update System 2021-03-19 17:43:11 UTC
FEDORA-2021-929a0acb1c has been pushed to the Fedora 34 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 7 Fedora Update System 2021-03-19 19:59:24 UTC
FEDORA-2021-929a0acb1c has been pushed to the Fedora 34 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.