Bug 1934358 - Don't suggest xorg-x11-server-utils, suggest the tool itself
Summary: Don't suggest xorg-x11-server-utils, suggest the tool itself
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: radeon-profile
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Artem
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 1932754
TreeView+ depends on / blocked
 
Reported: 2021-03-03 04:19 UTC by Peter Hutterer
Modified: 2021-03-19 20:00 UTC (History)
1 user (show)

Fixed In Version: radeon-profile-20200824-4.fc34
Clone Of:
Environment:
Last Closed: 2021-03-19 17:44:07 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description Peter Hutterer 2021-03-03 04:19:42 UTC
radeon-profile.spec Suggests xorg-x11-server-utils. As part of Bug 1932754 that package will go away, replaced by its component packages.

I don't know which specific utility we are suggesting here though (xrandr maybe? ). There's a few to choose from but none are more obvious.

Please replace the Suggests line with e.g. 
  Suggests: xrandr{?_isa}
or whatever tool(s) are required. xorg-x11-server-utils already has Provides for all its subtools anyway, so this can be done immediately without breakage. Thanks

Comment 1 Fedora Update System 2021-03-03 09:03:34 UTC
FEDORA-2021-bc6e0cb006 has been submitted as an update to Fedora 34. https://bodhi.fedoraproject.org/updates/FEDORA-2021-bc6e0cb006

Comment 2 Artem 2021-03-03 09:09:49 UTC
@Peter Hutterer thanks. Submitted update to f34. Not sure is 'xrandr' enough but this shouldn't be critical i hope. Can't test this myself at this moment because i am still on f33.

Comment 3 Fedora Update System 2021-03-03 15:47:07 UTC
FEDORA-2021-bc6e0cb006 has been pushed to the Fedora 34 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --advisory=FEDORA-2021-bc6e0cb006`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2021-bc6e0cb006

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 4 Peter Hutterer 2021-03-03 22:39:47 UTC
> Not sure is 'xrandr' enough

Well, xorg-x11-server-utils ships the following tools: (copy/paste from specfile because I'm lazy)

%global iceauth 1.0.8
%global rgb 1.0.6
%global sessreg 1.1.0
%global xgamma 1.0.6
%global xhost 1.0.7
%global xinput 1.6.3
%global xkill 1.0.5
%global xmodmap 1.0.9
%global xrandr 1.5.0
%global xrdb 1.1.1
%global xrefresh 1.0.6
%global xset 1.2.4
%global xsetpointer 1.0.1
%global xsetroot 1.1.2
%global xstdcmap 1.0.3
%global xisxwayland 1

So after `fedpkg prep`, grep finds only xrandr:

$ egrep -R "\<(iceauth|rgb|sessreg|xgamma|xhost|xinput|xkill|xmodmap|xrandr|xrdb|xrefresh|xset|xsetpointer|xsetroot|xsetstdcmap|xisxwayland)\>"                 
radeon-profile.spec:BuildRequires: pkgconfig(xrandr)
radeon-profile-20200824/README.md:* xrandr - connected displays
radeon-profile-20200824/radeon-profile/gpu.cpp:// http://cgit.freedesktop.org/xorg/app/xrandr/tree/xrandr.c#n2408
radeon-profile-20200824/radeon-profile/gpu.cpp:    // Old implementation, parsing the output of xrandr
radeon-profile-20200824/radeon-profile/gpu.cpp:    QStringList out = globalStuff::grabSystemInfo("xrandr -q --verbose"), screens;
radeon-profile-20200824/radeon-profile/gpu.cpp:    // XRandr source code (useful as reference): http://cgit.freedesktop.org/xorg/app/xrandr/tree/xrandr.c

So I think we're good here.

Comment 5 Fedora Update System 2021-03-19 17:44:07 UTC
FEDORA-2021-bc6e0cb006 has been pushed to the Fedora 34 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 6 Fedora Update System 2021-03-19 20:00:11 UTC
FEDORA-2021-bc6e0cb006 has been pushed to the Fedora 34 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.