Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.

Bug 1939134

Summary: [Assisted-4.7][Wizard] Changes in the networking page are auto-saved, but the "Next" is still disabled
Product: OpenShift Container Platform Reporter: Udi Kalifon <ukalifon>
Component: assisted-installerAssignee: Marek Libra <mlibra>
assisted-installer sub component: assisted-ui QA Contact: Udi Kalifon <ukalifon>
Status: CLOSED DUPLICATE Docs Contact:
Severity: urgent    
Priority: unspecified CC: aos-bugs, gharden, jtomasek, mlibra, tjelinek
Version: 4.7Keywords: TestBlocker
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2021-04-30 11:41:58 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Udi Kalifon 2021-03-15 17:13:56 UTC
Description of problem:
In out Cypress automation - after entering the VIP addresses - we wait for all the hosts to turn "ready", but then the "Next" button remains disabled. We know that the changes were auto-saved because the validations passed, and we expect that the "Next" will become enabled. We have to work around it by going back and forward again.


Version-Release number of selected component (if applicable):
Assisted Installer UI version
    (quay.io/ocpmetal/ocp-metal-ui:2fe99dd56daff096177e5d9a1b644c8a3ee5b039)
Assisted Installer UI library version
    0.0.12-wizard


How reproducible:
100% with the automation


Steps to Reproduce:
1. In the networking page (3rd step in the wizard), quickly enter the VIP addresses of the cluster and wait for the validation to complete


Actual results:
After the validations pass, the Next button is still disabled


Expected results:
"Next" should be automatically enabled at this point

Comment 1 Udi Kalifon 2021-03-16 08:29:15 UTC
On staging, there is no autosaving in the networking page. This was recreated manually:
1) Create a cluster and discover hosts
2) In the networking page, select a CIDR
3) Notice that the DHCP is on by default, and the system is now trying to allocate VIPs
4) Deselect the DHCP and enter VIPs manually
5) At this stage, all the hosts are already in "ready" state, but the "Next" button never gets enabled
6) Click "Back" and then "Next"
=> The VIPs you entered manually were not saved, and instead you see the dynamically allocated VIPs. Oddly, also the dhcp checkbox is deselected. You have to enable and disable dhcp to work around this issue, and re-enter the manual VIPs.

Comment 2 Marek Libra 2021-03-16 09:58:09 UTC
The issue 5 from the list in #1, is resolved by the provided patch.

Can be the "not saving issue" caused by timing? The auto-save is debounced - called with a delay. When submitting is in progress, the user is notified via "saving changes ..." message.
For a moment I was thinking about disabling the Back button in case of a dirty form but that would lead to even worser UX.

Comment 4 Udi Kalifon 2021-03-31 19:58:21 UTC
Verified in: UI version 1.5.13

Comment 5 Jiri Tomasek 2021-04-28 08:57:00 UTC
Gary can you please elaborate on why this was reopened?

Comment 6 gharden 2021-04-28 12:18:48 UTC
On the Networking Step: All host have networking state ready with some SOFT validations failed but Next button is not enabled. This is inconsistent with how it was before. There was never a need to wait longer than 30 sec after the nodes all reach ready state

Comment 7 Tomas Jelinek 2021-04-30 11:41:58 UTC

*** This bug has been marked as a duplicate of bug 1954106 ***