Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.

Bug 1954106

Summary:	The "Next" button is disabled after any change. Need to click on "Back"to re-enable it.
Product:	OpenShift Container Platform	Reporter:	Alexander Chuzhoy <sasha>
Component:	assisted-installer	Assignee:	Jiri Tomasek <jtomasek>
assisted-installer sub component:	assisted-ui	QA Contact:	Udi Kalifon <ukalifon>
Status:	CLOSED CURRENTRELEASE	Docs Contact:
Severity:	urgent
Priority:	urgent	CC:	aos-bugs, cvultur, iovadia, jtomasek, lalon, mchernyk, mlibra, ohochman, tjelinek, ukalifon
Version:	4.8	Keywords:	TestBlocker
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2022-08-28 08:45:59 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Alexander Chuzhoy 2021-04-27 15:26:44 UTC

Version:
Assisted-ui-lib version:  1.5.16

A cluster doesn't become ready for deployment.

Looking at  the host events:


4/27/2021, 11:03:21 AM	
warning Host master-0-0: updated status from "discovering" to "insufficient" (Host cannot be installed due to following failing validation(s): Host couldn't synchronize with any NTP server)


The "Next" button in the wizzard didn't become enabled.


After I added the NTP source , in some time the node became ready, but the "Next" button was still disabled.


I clicked the back button and then the Next button became enabled.


Cluster events:

4/27/2021, 11:22:35 AM	Host master-0-0: updated status from "known" to "preparing-for-installation" (Host is preparing for installation)
4/27/2021, 11:22:33 AM	Cluster was prepared successfully for installation
4/27/2021, 11:21:58 AM	Host master-0-0: set as bootstrap
4/27/2021, 11:18:29 AM	Host master-0-0: validation 'ntp-synced' is now fixed
4/27/2021, 11:10:41 AM	Updated status of cluster sasha1 to ready
4/27/2021, 11:10:41 AM	Cluster validation 'all-hosts-are-ready-to-install' is now fixed
4/27/2021, 11:10:41 AM	Cluster validation 'machine-cidr-defined' is now fixed
4/27/2021, 11:10:41 AM	Host master-0-0: updated status from "insufficient" to "known" (Host is ready to be installed)
4/27/2021, 11:03:21 AM	
warning Host master-0-0: updated status from "discovering" to "insufficient" (Host cannot be installed due to following failing validation(s): Host couldn't synchronize with any NTP server)
4/27/2021, 11:01:32 AM	Cluster validation 'sufficient-masters-count' is now fixed
4/27/2021, 11:01:32 AM	
warning Cluster validation 'all-hosts-are-ready-to-install' that used to succeed is now failing
4/27/2021, 11:01:18 AM	Host 3f3910bb-41da-4a52-bc82-e079f3ff9f26: registered to cluster
4/27/2021, 10:58:44 AM	Generated image (Image type is "full-iso", SSH public key is set)
4/27/2021, 10:20:37 AM	Updated status of cluster sasha1 to pending-for-input
4/27/2021, 10:20:25 AM	Successfully registered cluster sasha1 with id a0686c23-3750-4f05-9dfb-3f7f60cae3f7
4/27/2021, 10:20:25 AM	Registered cluster "sasha1"

Comment 1 Alexander Chuzhoy 2021-04-27 16:21:08 UTC

What happens is that after every change the "Next" button becomes disabled.

You need to click on the "back" button and the "Next" button becomes enabled.

Comment 2 Jiri Tomasek 2021-04-28 09:04:51 UTC

Can you please confirm that there was no error message next to the 'Next' button in the wizard?
Can you please elaborate on exact steps you did in networking step which lead to Next button not getting enabled?

Comment 4 Jiri Tomasek 2021-04-28 13:45:52 UTC

Went through the issue with Sasha, the problem occurs with SNO, on networking step, do any field change in the form, the form gets autosaved but form remains dirty and the next button won't get highlighted.

Comment 5 Jonathan Kilzi 2021-04-28 14:23:25 UTC

Quick repro step:

When the user arrives to the networking step the next button is enabled. however, if the user changes for example the cluster network CIDR field in the advanced networking section then the next button gets disabled.

Observing the React context I see there is a discrepancy in the field that changed; the initialValues still hold the old value event after the field was validated the form was autosaved and we patched the cluster with the new value.

Comment 6 Omri Hochman 2021-04-29 14:18:50 UTC

*** Bug 1954697 has been marked as a duplicate of this bug. ***

Comment 7 Omri Hochman 2021-04-29 14:20:25 UTC

impact also multi-node cluster ..
see dup: 
https://bugzilla.redhat.com/show_bug.cgi?id=1954697

Comment 8 Tomas Jelinek 2021-04-30 11:41:54 UTC

*** Bug 1939134 has been marked as a duplicate of this bug. ***

Comment 9 Marek Libra 2021-04-30 11:54:23 UTC

I was facing the same issue when fixing MGMT-5433.
Should be fixed by the MGMT-5433 patch on the Networking step but adding the same workaround for the Host Discovery step as well.

Comment 10 Ido Ovadia 2021-05-04 15:41:10 UTC

Failed QA
=========
v1.0.19.3

Comment 11 Ido Ovadia 2021-05-04 15:53:46 UTC

mark / unmark  operator and Next button disabled. (I waited ~5 and its status didn't changed)

Comment 12 Lital Alon 2021-05-05 09:32:57 UTC

Verified on Staging v1.0.19.3
According to Jiri, fix applied on OCM.

Comment 13 Marek Libra 2021-05-05 09:55:04 UTC

A follow-up: https://github.com/openshift-assisted/assisted-ui-lib/pull/585