Bug 1940198 - Request to add libjwt to epel7
Summary: Request to add libjwt to epel7
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora EPEL
Classification: Fedora
Component: libjwt
Version: epel7
Hardware: All
OS: Linux
unspecified
low
Target Milestone: ---
Assignee: Ward
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 1947878
TreeView+ depends on / blocked
 
Reported: 2021-03-17 19:24 UTC by Ward
Modified: 2021-05-04 13:20 UTC (History)
3 users (show)

Fixed In Version: libjwt-1.12.1-7.el7
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2021-05-04 13:20:25 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description Ward 2021-03-17 19:24:39 UTC
The current spec file of libjwt in https://src.fedoraproject.org/rpms/libjwt/ is only build for Fedora 34. Could a build for epel7 also be added? The current spec file of the main branch works fine on CentOS 7 without any changes. I've verified by running the libjwt test suite on top of it.

Comment 1 Jared Smith 2021-03-17 20:29:50 UTC
I don't have any particular interest in maintaining it in EPEL 7 at the moment, but if I get some free time in the next few days I'll investigate what it might take to maintain it in EPEL7 and EPEL8.  In the meantime, if you're a Fedora packager, feel free to send me your FAS username and I'd be happy to make you a co-maintainer.

Comment 2 Ward 2021-03-17 20:32:09 UTC
I'm not a Fedora packager but I'm willing to help co maintain this. My FAS username is wpoely86.

Comment 3 Jared Smith 2021-03-17 20:44:57 UTC
I've opened a ticket to sponsor you as a co-maintainer on the package (https://pagure.io/packager-sponsors/issue/461).  Once that's been processed by the admin team, I'll give you packaging rights to the libjwt package.  Please reach out if you have questions/concerns/ideas... I'm "jsmith" on IRC, or my email is jsmith.

Comment 4 Fedora Admin user for bugzilla script actions 2021-03-18 00:50:57 UTC
This package has changed maintainer in Fedora. Reassigning to the new maintainer of this component.

Comment 5 Ward 2021-03-18 10:08:52 UTC
Great! I've done everything that was asked in the issue (the mailinglist, keys etc). All seems fine but I guess you still need to make me co-maintainer before I can do `fedpkg clone`?

Comment 6 Jared Smith 2021-03-20 17:38:02 UTC
I've tried to give you rights to the project at https://src.fedoraproject.org/rpms/libjwt/adduser but it's not working.  I'll reach out to the admin team and try to figure out what's going on there.

Comment 7 Ward 2021-04-01 07:59:51 UTC
Any luck with adding me as co-maintainer?

Comment 8 Heitor 2021-04-09 13:23:20 UTC
I'm also interested in libjwt for EPEL7. This packaged is needed to package slurm-slurmrestd[0]. I'm not a Fedora packager, but I'm willing to help. What can I do to help here?

[0] https://bugzilla.redhat.com/show_bug.cgi?id=1947878

Comment 9 Ward 2021-04-09 14:55:01 UTC
I'm interested for the same reason ;)

See: https://bugs.schedmd.com/show_bug.cgi?id=11114

Comment 10 Philip Kovacs 2021-04-12 19:04:15 UTC
If you need help with this let me know (pkfed), you can add me as a maintainer to libjwt (don't need sponsorship). I'll bootstrap the EPEL7 version, then jump off the project.

Comment 11 Jared Smith 2021-04-13 19:18:11 UTC
@pkfed I've added you as a co-maintainer.

@wpoely86 Please log into src.fedoraproject.org, and then I should be able to add you as a co-maintainer.  Apparently I can't do it until you login first, though.

Comment 12 Philip Kovacs 2021-04-13 21:49:40 UTC
Branch request created: https://pagure.io/releng/fedora-scm-requests/issue/33522

They do those fairly quickly. Once that's done, I'll continue.

Comment 13 Philip Kovacs 2021-04-14 02:34:35 UTC
Pushed minor updates -- had to use canonical date format in changelog to get some builds to go through (don't use time in changelog entries).

https://bodhi.fedoraproject.org/updates/FEDORA-2021-5e627dbab7 (f34)
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2021-ff2ffc617f (epel8)

I'll push epel7 when they create the branch.  

Note that the epel updates sit for two full weeks in bodhi unless karma is granted.

Comment 14 Ward 2021-04-14 07:40:11 UTC
@

Comment 15 Ward 2021-04-14 07:41:35 UTC
Oeps, I meant:

@jsmith, I've already logged in to src.fedoraproject.org. I've now done it again so hopefully it does work now.

Comment 16 Fedora Update System 2021-04-14 15:12:43 UTC
FEDORA-EPEL-2021-81a9547da3 has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2021-81a9547da3

Comment 17 Philip Kovacs 2021-04-14 15:24:50 UTC
The EPEL7 branch is created, the files are pushed, the build is finished and is submitted to bodhi (see above).
I've attached this bug to that update so it will auto-close once the EPEL7 newpackage update is complete.

The time gate is two weeks should no positive karma be granted.  A newpackage announcement message will be generated
(as required) to the EPEL dev list once the package is released.  That should be it.

Comment 18 Philip Kovacs 2021-04-14 16:17:41 UTC
I realigned the git sha's since the four branches are identical (epe7/epel8/f34/rawhide).  If you are new to dist-git,
be aware you cannot rewrite git history with rebase.  Try to do fast-forward commits!

Comment 19 Fedora Update System 2021-04-15 14:16:34 UTC
FEDORA-EPEL-2021-81a9547da3 has been pushed to the Fedora EPEL 7 testing repository.

You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2021-81a9547da3

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 20 Philip Kovacs 2021-04-16 21:16:01 UTC
I read the bodhi update comment that the binary `jwtgen` is segfaulting.  It appears to be part of the upstream "examples" folder -- is it truly necessary to distribute those two example binaries?  I would rather strip them from the package, if they are not needed, then distribute them as broken binaries.

Comment 21 Ward 2021-04-18 17:58:32 UTC
I would strip them (at least from 'bin'). They're just simple examples without much error handling.

@jsmith any progress with adding me?

Comment 22 Philip Kovacs 2021-04-18 22:37:28 UTC
I added an upstream pull request to build the examples optionally when building with autotools (similar to their cmake option).

https://github.com/benmcollins/libjwt/pull/149

I added this patch to the Fedora repo and changed the spec to apply it so we can ./configure --without-examples.

The new build ares submitted (unfortunately this resets the time gate -- karma would help -- the submitter cannot provide karma).

Comment 23 Fedora Update System 2021-04-19 17:14:17 UTC
FEDORA-EPEL-2021-b8c4714317 has been pushed to the Fedora EPEL 7 testing repository.

You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2021-b8c4714317

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 24 Ward 2021-04-21 10:56:44 UTC
Karma given.

@pkfed also push the new release to EPEL 8?

Comment 25 Philip Kovacs 2021-04-21 17:12:17 UTC
I did EPEL 8 on the same day as EPEL 7.  It's here:
 
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2021-f1920cd4c1

Comment 26 Fedora Update System 2021-05-04 13:20:25 UTC
FEDORA-EPEL-2021-b8c4714317 has been pushed to the Fedora EPEL 7 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.