Spec URL: https://ankursinha.fedorapeople.org/python-neurom/python-neurom.spec SRPM URL: https://ankursinha.fedorapeople.org/python-neurom/python-neurom-1.8.0-1.fc34.src.rpm Description: NeuroM is a Python-based toolkit for the analysis and processing of neuron morphologies. Documentation is available at https://neurom.readthedocs.io/ Fedora Account System Username: ankursinha
Will perform this review soon.
Hi Ankur! Package looks wonderful. I have only one comment. 1. It seems that upstream released several versions in the past days. The last one was released app. 19 hours ago. Please check it out. Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "BSD 3-clause "New" or "Revised" License". 86 files have unknown license. Detailed output of licensecheck in /home/iztok/rpmbuild/reviews/1950624-python- neurom/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 20480 bytes in 2 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [x]: Python eggs must not download any dependencies during the build process. [x]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Packages MUST NOT have dependencies (either build-time or runtime) on packages named with the unversioned python- prefix unless no properly versioned package exists. Dependencies on Python packages instead MUST use names beginning with python2- or python3- as appropriate. [x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [-]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in python3-neurom [x]: Package functions as described. [?]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: python3-neurom-1.8.0-1.fc35.noarch.rpm python-neurom-doc-1.8.0-1.fc35.noarch.rpm python-neurom-1.8.0-1.fc35.src.rpm python3-neurom.noarch: W: spelling-error %description -l en_US morphologies -> morphological, morphology python3-neurom.noarch: W: no-manual-page-for-binary morph_check python3-neurom.noarch: W: no-manual-page-for-binary morph_stats python3-neurom.noarch: W: no-manual-page-for-binary neurom python3-neurom.noarch: W: no-manual-page-for-binary raw_data_check python-neurom-doc.noarch: W: spelling-error %description -l en_US morphologies -> morphological, morphology python-neurom.src: W: spelling-error %description -l en_US morphologies -> morphological, morphology 3 packages and 0 specfiles checked; 0 errors, 7 warnings. Rpmlint (installed packages) ---------------------------- python3-neurom.noarch: W: spelling-error %description -l en_US morphologies -> morphological, morphology python3-neurom.noarch: W: no-manual-page-for-binary morph_check python3-neurom.noarch: W: no-manual-page-for-binary morph_stats python3-neurom.noarch: W: no-manual-page-for-binary neurom python3-neurom.noarch: W: no-manual-page-for-binary raw_data_check python-neurom-doc.noarch: W: spelling-error %description -l en_US morphologies -> morphological, morphology 2 packages and 0 specfiles checked; 0 errors, 6 warnings. Source checksums ---------------- https://files.pythonhosted.org/packages/source/n/neurom/neurom-1.8.0.tar.gz : CHECKSUM(SHA256) this package : d364d3b184bd96cbe5fa601ae24f6b7d431fa42de646e3011a33d56f3cfc247c CHECKSUM(SHA256) upstream package : d364d3b184bd96cbe5fa601ae24f6b7d431fa42de646e3011a33d56f3cfc247c Requires -------- python3-neurom (rpmlib, GLIBC filtered): /usr/bin/python3 python(abi) python3.9dist(click) python3.9dist(h5py) python3.9dist(matplotlib) python3.9dist(numpy) python3.9dist(pandas) python3.9dist(pyyaml) python3.9dist(scipy) python3.9dist(tqdm) python-neurom-doc (rpmlib, GLIBC filtered): Provides -------- python3-neurom: python-neurom python3-neurom python3.9-neurom python3.9dist(neurom) python3dist(neurom) python-neurom-doc: python-neurom-doc Generated by fedora-review 0.7.6 (b083f91) last change: 2020-11-10 Command line :/usr/bin/fedora-review -b 1950624 Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Python, Shell-api Disabled plugins: fonts, Ocaml, Perl, Haskell, SugarActivity, C/C++, Java, PHP, R Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH
PACKAGE APPROVED
Thanks very much Iztok! I just checked out the new version. It's a new major release, and it now depends on MorphIO which is still a WIP (https://pagure.io/neuro-sig/NeuroFedora/issue/438). So I'll import this version, and update to the latest one as soon as we've included MorphIO too. Requesting SCM now. Cheers, Ankur
(fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/python-neurom
FEDORA-2021-3e408bb956 has been submitted as an update to Fedora 34. https://bodhi.fedoraproject.org/updates/FEDORA-2021-3e408bb956
FEDORA-2021-5997c3efbf has been submitted as an update to Fedora 33. https://bodhi.fedoraproject.org/updates/FEDORA-2021-5997c3efbf
FEDORA-2021-3e408bb956 has been pushed to the Fedora 34 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2021-3e408bb956 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2021-3e408bb956 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2021-5997c3efbf has been pushed to the Fedora 33 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2021-5997c3efbf \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2021-5997c3efbf See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2021-3e408bb956 has been pushed to the Fedora 34 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-2021-5997c3efbf has been pushed to the Fedora 33 stable repository. If problem still persists, please make note of it in this bug report.