Bug 196625 - Review Request: perl-SVN-Simple - a simple interface to subversion's editor interface
Review Request: perl-SVN-Simple - a simple interface to subversion's editor ...
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
All Linux
medium Severity medium
: ---
: ---
Assigned To: Jason Tibbitts
Fedora Package Reviews List
Depends On:
Blocks: FE-ACCEPT 196627
  Show dependency treegraph
Reported: 2006-06-25 22:04 EDT by Ian Burrell
Modified: 2008-06-06 14:59 EDT (History)
0 users

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Last Closed: 2006-06-29 02:45:21 EDT
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
kevin: fedora‑cvs+

Attachments (Terms of Use)

  None (edit)
Description Ian Burrell 2006-06-25 22:04:27 EDT
Spec URL: http://znark.com/fedora/perl-SVN-Simple.spec
SRPM URL: http://znark.com/fedora/perl-SVN-Simple-0.27-1.src.rpm
Description: a simple interface to
subversion's editor interface.

It is required perl-SVN-Mirror which is required by perl-SVK.
Comment 2 Jason Tibbitts 2006-06-28 13:51:16 EDT
This fails to build in mock; you are missing a BuildRequires: perl(SVN::Core)
(which ends up being provided by subversion-perl).  I'm going to assume for the
purposes of this review that it's been added.

Since that's the only issue, I'll go ahead and approve and you can fix it when
you check in.

* package meets naming and packaging guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* dist tag is present.
* build root is correct.
* license field matches the actual license.
* license is open source-compatible.  License text not included upstream. 
* source files match upstream:
   6a5609e038421564051019649dd05fd0  SVN-Simple-0.27.tar.gz
* latest version is being packaged.
X BuildRequires are proper (needs perl(SVN::Core).)
O package builds in mock (development, x86_64) (once the needed BR: is added.)
* rpmlint is silent.
* final provides and requires are sane:
   perl(SVN::Simple::Edit) = 0.27
   perl-SVN-Simple = 0.27-2.fc6
* no shared libraries are present.
* package is not relocatable.
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* %clean is present.
* %check is present and all tests pass:
   All tests successful.
   Files=1, Tests=8,  0 wallclock secs ( 0.12 cusr +  0.03 csys =  0.15 CPU)
* no scriptlets present.
* code, not content.
* documentation is small, so no -docs subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.
* no headers.
* no pkgconfig files.
* no libtool .la droppings.
* not a GUI app.

Comment 3 Ian Burrell 2006-06-29 02:45:21 EDT
Built for devel.
Comment 4 Ian Burrell 2008-06-06 14:38:32 EDT
Package Change Request
Package Name: perl-SVN-Simple
New Branches: EL-4 EL-5
Comment 5 Kevin Fenzi 2008-06-06 14:59:35 EDT
cvs done.

Note You need to log in before you can comment on or make changes to this bug.