Spec URL: http://people.redhat.com/llch/fonts-sinhala/fonts-sinhala.spec SRPM URL: http://people.redhat.com/llch/fonts-sinhala/fonts-sinhala-0.2-1.src.rpm Packge Owner: dsantani Description: An essential font for Sinhala language for FC6. Size: noarch = 107k; SRPMS = 105k
Translations for this locale seem woefully incomplete. Aside from that, sounds OK.
Jesse, please review and would be great to add the component.
Some comments regarding the spec file: > BuildRoot: %{_tmppath}/%{name}-root Please use the recommended BuildRoot: %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n) > Prereq: fontconfig This is not necessary in font packages, since they could be installed in systems without fontconfig. See a policy explanation in http://www.redhat.com/archives/fedora-extras-list/2005-May/msg00887.html Moreover, provisions are made in the spec file to check the presense of fc-cache before running it. > # %%ghost the fonts.cache-1 file > touch $RPM_BUILD_ROOT%{_datadir}/fonts/sinhala/fonts.cache-1 > %ghost %{_datadir}/fonts/sinhala/fonts.cache-1 This is not necessary for fontconfig > 2.3.93, i.e. for FC>=5. If this package is intended for Fedora >=5 only, ghosting this file is superfluous.
Other than the above comments, rpmlint has this to say: W: fonts-sinhala wrong-file-end-of-line-encoding /usr/share/doc/fonts-sinhala-0.2/COPYING W: fonts-sinhala wrong-file-end-of-line-encoding /usr/share/doc/fonts-sinhala-0.2/license.txt Those two files may have windows encoding or the like. Fix that and the comments above and I'll be happy to approve this.
Do we have a plan in place to get translations for the desktops?
Thanks. It is updated. Jesse please approve: Spec URL: http://people.redhat.com/llch/fonts-sinhala/fonts-sinhala.spec SRPM URL: http://people.redhat.com/llch/fonts-sinhala/fonts-sinhala-0.2-2.src.rpm Packge Owner: dsantani Description: An essential font for Sinhala language for FC6. Size: noarch = 107k; SRPMS = 105k
The first and third issue (i.e. BuildRoot and superfluous %ghosting) are still in -2.
Jesse: Spec URL: http://people.redhat.com/llch/fonts-sinhala/fonts-sinhala.spec SRPM URL: http://people.redhat.com/llch/fonts-sinhala/fonts-sinhala-0.2-3.src.rpm Packge Owner: dsantani Description: An essential font for Sinhala language for FC6. Size: noarch = 107k; SRPMS = 105k
Issues look resolved. RPMLINT is silent. Approving. Adding to dist per notting's approval.
Thanks Jesse. Package is imported into cvs-dist and built in dist-fc6. But seems the owner should be dsantani instead.
fixed.
*** Bug 226809 has been marked as a duplicate of this bug. ***