Bug 1973572 - Hardcode strings(Control Plane,None,Configure,Cluster,Not available) happen in Home->Overview page
Summary: Hardcode strings(Control Plane,None,Configure,Cluster,Not available) happen i...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: OpenShift Container Platform
Classification: Red Hat
Component: Management Console
Version: 4.7
Hardware: All
OS: All
unspecified
low
Target Milestone: ---
: 4.7.z
Assignee: Kim Dobestein
QA Contact: Yadan Pei
URL:
Whiteboard:
Depends On: 1924586 1927465
Blocks:
TreeView+ depends on / blocked
 
Reported: 2021-06-18 07:55 UTC by Xu Rui Li
Modified: 2021-07-14 06:35 UTC (History)
5 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2021-07-06 11:38:38 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)
Hardcode strings(Control Plane,None,Configure,Cluster,Not available) happen in Home->Overview page. (322.07 KB, image/png)
2021-06-18 07:55 UTC, Xu Rui Li
no flags Details
"None" display when installed Openshift without a provider (437.56 KB, image/png)
2021-06-24 07:50 UTC, Xu Rui Li
no flags Details
"None" displays in the pseudolocalization environment (531.36 KB, image/png)
2021-06-24 07:52 UTC, Xu Rui Li
no flags Details
latest translation on Home -> Overview page (378.06 KB, image/png)
2021-06-28 02:13 UTC, Yadan Pei
no flags Details


Links
System ID Private Priority Status Summary Last Updated
Github openshift console pull 9322 0 None open Bug 1973572: Hardcode strings in Home->Overview page 2021-06-22 19:48:59 UTC
Red Hat Product Errata RHBA-2021:2554 0 None None None 2021-07-06 11:39:14 UTC

Description Xu Rui Li 2021-06-18 07:55:44 UTC
Created attachment 1791990 [details]
Hardcode strings(Control Plane,None,Configure,Cluster,Not available) happen in Home->Overview page.

Description of problem:

Hardcode strings(Control Plane,None,Configure,Cluster,Not available) happen in Home->Overview page.

Version-Release number of selected component (if applicable):
OpenShift 4.7.16

How reproducible:

Steps to Reproduce:
1.Login OpenShift Web console
2.The language preference set to Simplified Chinese language
3.In Administrator, access Home->Ovewview dashboard 
3.In Overview, hardcode strings(Control Plane,None,Configure,Cluster,Not available) happen .

Actual results:
hardcode strings(Control Plane,None,Configure,Cluster,Not available) happen

Expected results:
They are translated when the language preference set to Simplified Chinese language

Additional info:

Comment 1 Xu Rui Li 2021-06-18 07:57:44 UTC
In https://kubernetes.io/zh/docs/concepts/overview/components/, 'control plane' is translated into '控制平面' in Simplified Chinese language.

Comment 2 Kim Dobestein 2021-06-22 19:46:13 UTC
All of these appear to be fixed in 4.8 (and above) so this fix is only needed in 4.7.  The fixes into 4.8 are covered in Bug 1924586, Bug 1927465, CONSOLE 2539, CONSOLE 2527.

In both 4.8 and the master branch, the entry for "control plane" in Simplified Chinese is "Control Plane" so I'm wondering if the fix for that should be a different bug that can then be applied to current and previous version.

I also couldn't find where "None" is set in the console UI code. When using shared clusters, the value I see is "AWS" which makes sense.  Wondering if there is a cluster available where I can see the "None" set.

Comment 3 Xu Rui Li 2021-06-24 07:50:59 UTC
Created attachment 1793781 [details]
"None" display when installed Openshift without a provider

Comment 4 Xu Rui Li 2021-06-24 07:52:49 UTC
Created attachment 1793782 [details]
"None" displays in the pseudolocalization environment

Comment 5 Kim Dobestein 2021-06-25 14:11:29 UTC
Thanks for the info.  I was able to verify that the text "None" is being sent into the console from the backend.  When I ran the oc describe infrastructures command, the provider is listed as "None" and that is what is displayed.  Since the console isn't determining the text to show, it can't be translated.

Comment 7 Yadan Pei 2021-06-28 02:13:19 UTC
Created attachment 1795252 [details]
latest translation on Home -> Overview page

Cluster has been translated with 集群
Not Available has been translated with 不可用
Configure has been translated with 配置
None is something we get from backend so it can't be translated
Control Plane is not translated, I'm not sure if there is any proper text it can be translated to

Comment 8 Yadan Pei 2021-06-28 02:14:35 UTC
Hi,

Could you help confirm if comment 7 is satisfying? I think current translation looks good but please help confirm, thanks!

Comment 10 Yadan Pei 2021-06-29 09:50:46 UTC
Shall we fix `Control Plane` translation in this bug or another bug?

Comment 11 Kim Dobestein 2021-06-29 13:53:43 UTC
My thought is to fix it in another bug. As of right now, `Control Plane` doesn't have a translation in master.  All of the other translations in this bug (`Configure`, `Cluster`, and `Not available`) are fixed in 4.8.  So if we move the translation of `Control Plane` to another bug, this bug covers items that only need to be fixed in 4.7.  The new bug to translate `Control Plane` then is a bug that would cover the fix in multiple versions.  With that said, I'm fairly new and don't know how the best way to approach items like this yet.  Let me know what you would like to do.

Comment 12 Yadan Pei 2021-06-30 01:02:03 UTC
(In reply to Kim Dobestein from comment #11)
> My thought is to fix it in another bug. As of right now, `Control Plane`
> doesn't have a translation in master.  All of the other translations in this
> bug (`Configure`, `Cluster`, and `Not available`) are fixed in 4.8.  So if
> we move the translation of `Control Plane` to another bug, this bug covers
> items that only need to be fixed in 4.7.  The new bug to translate `Control
> Plane` then is a bug that would cover the fix in multiple versions.  With
> that said, I'm fairly new and don't know how the best way to approach items
> like this yet.  Let me know what you would like to do.

Fair enough, I will move this one to VERIFIED, this is checked against 4.7.0-0.nightly-2021-06-26-014854

@xurl.com please open another bug to track the translation of 'Control Plane'

Comment 14 errata-xmlrpc 2021-07-06 11:38:38 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (OpenShift Container Platform 4.7.19 bug fix update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2021:2554

Comment 15 Xu Rui Li 2021-07-14 06:35:10 UTC
Opened a new Bug 1982063 - 'Control Plane' is not translated in Simplified Chinese language in Home->Overview page.
https://bugzilla.redhat.com/show_bug.cgi?id=1982063


Note You need to log in before you can comment on or make changes to this bug.