Bug 1973934 - Review Request: python-connection_pool - Thread-safe connection pool for python
Summary: Review Request: python-connection_pool - Thread-safe connection pool for python
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Zbigniew Jędrzejewski-Szmek
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: fedora-neuro, NeuroFedora 1821189
TreeView+ depends on / blocked
 
Reported: 2021-06-19 06:38 UTC by Aniket Pradhan
Modified: 2021-07-02 01:20 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2021-07-01 01:13:16 UTC
Type: ---
Embargoed:
zbyszek: fedora-review+

Attachments (Terms of Use)

Description Aniket Pradhan 2021-06-19 06:38:36 UTC 
Spec URL: https://major.fedorapeople.org/python-connection_pool/python-connection_pool.spec
SRPM URL: https://major.fedorapeople.org/python-connection_pool/python-connection_pool-0.0.3-1.fc34.src.rpm

Description: Thread-safe connection pool for python

Fedora Account System Username: major

Koji build: https://koji.fedoraproject.org/koji/taskinfo?taskID=70415228
Comment 1 Zbigniew Jędrzejewski-Szmek 2021-06-21 15:21:31 UTC 
I'm a bit torn about the name. "python-connection-pool" would possibly be nicer, though "connection_pool"
matches the module name, so it's also OK…

%description should end in ".". It's not clear from the description what this module does:
a pool of connections to what?

+ package name is OK
+ license is acceptable for Fedora (MIT)
+ license is specified correctly
+ builds and installs OK
+ BR/P/R look OK
+ fedora-review finds no issues

Package is APPROVED. Please enhance the %description a bit.
Comment 2 Aniket Pradhan 2021-06-21 15:27:06 UTC 
Thanks a lot Zbigniew for the review. I'll rewrite the description in my own words to make it more understandable.
Comment 3 Gwyn Ciesla 2021-06-21 16:12:33 UTC 
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/python-connection_pool
Comment 4 Fedora Update System 2021-06-22 11:13:10 UTC 
FEDORA-2021-a785c18b72 has been submitted as an update to Fedora 34. https://bodhi.fedoraproject.org/updates/FEDORA-2021-a785c18b72
Comment 5 Fedora Update System 2021-06-23 02:00:48 UTC 
FEDORA-2021-a785c18b72 has been pushed to the Fedora 34 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2021-a785c18b72 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2021-a785c18b72

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
Comment 6 Fedora Update System 2021-06-24 14:45:16 UTC 
FEDORA-2021-a159ca4c98 has been pushed to the Fedora 33 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2021-a159ca4c98 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2021-a159ca4c98

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
Comment 7 Fedora Update System 2021-07-01 01:13:16 UTC 
FEDORA-2021-a785c18b72 has been pushed to the Fedora 34 stable repository.
If problem still persists, please make note of it in this bug report.
Comment 8 Fedora Update System 2021-07-02 01:20:22 UTC 
FEDORA-2021-a159ca4c98 has been pushed to the Fedora 33 stable repository.
If problem still persists, please make note of it in this bug report.
Note You need to log in before you can comment on or make changes to this bug.