Red Hat Bugzilla – Bug 197739
Review Request: perl-DateTime-Event-Recurrence
Last modified: 2007-11-30 17:11:36 EST
Spec URL: http://ftp.kspei.com/pub/steve/rpms/perl-DateTime-Event-Recurrence/perl-DateTime-Event-Recurrence.spec
SRPM URL: http://ftp.kspei.com/pub/steve/rpms/perl-DateTime-Event-Recurrence-0.16-1.src.rpm
This module provides convenience methods that let you easily create
DateTime::Set objects for various recurrences, such as "once a month" or
"every day". You can also create more complicated recurrences, such as
"every Monday, Wednesday and Thursday at 10:00 AM and 2:00 PM".
Your two manual versioned dependencies are duplicated by unversioned
dependencies found by RPM; you will have to remove yours or filter RPM's.
* source files match upstream:
* package meets naming and packaging guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* dist tag is present.
* build root is correct.
* license field matches the actual license.
* license is open source-compatible. License text included in package.
* latest version is being packaged (0.16 12 May 2005)
* BuildRequires are proper.
* %clean is present.
* package builds in mock (development, x86_64) (with DateTime-Set and
Set-Infinite in my local repo)
* rpmlint is silent.
* noarch package, so no debuginfo.
X final provides and requires are sane:
perl(DateTime::Event::Recurrence) = 0.16
perl-DateTime-Event-Recurrence = 0.16-1.fc6
X perl(DateTime) >= 0.27
X perl(DateTime::Set) >= 0.17
* %check is present and all tests pass:
All tests successful.
Files=14, Tests=195, 16 wallclock secs (15.10 cusr + 0.35 csys = 15.45 CPU)
* no shared libraries are present.
* package is not relocatable.
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* no scriptlets present.
* code, not content.
* documentation is small, so no -docs subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.
* no headers.
* no pkgconfig files.
* no libtool .la droppings.
* not a GUI app.
(In reply to comment #1)
> Your two manual versioned dependencies are duplicated by unversioned
> dependencies found by RPM; you will have to remove yours or filter RPM's.
I dropped the manual dependencies.
Looks good now. The dependency list is now:
Imported into CVS, branches created, and builds requested.