Bug 197744 - Review Request: perl-DateTime-Event-ICal
Summary: Review Request: perl-DateTime-Event-ICal
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Jason Tibbitts
QA Contact: Fedora Package Reviews List
URL:
Whiteboard:
Depends On: 197739
Blocks: FE-ACCEPT 197745
TreeView+ depends on / blocked
 
Reported: 2006-07-05 21:49 UTC by Steven Pritchard
Modified: 2007-11-30 22:11 UTC (History)
0 users

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2006-07-13 20:35:09 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)

Description Steven Pritchard 2006-07-05 21:49:45 UTC
Spec URL: http://ftp.kspei.com/pub/steve/rpms/perl-DateTime-Event-ICal/perl-DateTime-Event-ICal.spec
SRPM URL: http://ftp.kspei.com/pub/steve/rpms/perl-DateTime-Event-ICal-0.09-1.src.rpm
Description:
This module provides convenience methods that let you easily create
DateTime::Set objects for rfc2445 style recurrences.

Comment 1 Jason Tibbitts 2006-07-08 02:51:35 UTC
* source files match upstream:
   a68e58f5aac48a739249118d078e9947  DateTime-Event-ICal-0.09.tar.gz
* package meets naming and packaging guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* dist tag is present.
* build root is correct.
* license field matches the actual license.
* license is open source-compatible.  License text included in package.
* latest version is being packaged.
* BuildRequires are proper.
* %clean is present.
* package builds in mock (development, x86_64, some dependencies added to local
repo)
* rpmlint is silent.
* noarch package, so no debuginfo.
* final provides and requires are sane:
   perl(DateTime::Event::ICal) = 0.09
   perl-DateTime-Event-ICal = 0.09-1.fc6
  =
   perl(:MODULE_COMPAT_5.8.8)
   perl(Carp)
   perl(DateTime)
   perl(DateTime::Event::Recurrence) >= 0.11
   perl(DateTime::Set)
   perl(DateTime::Span)
   perl(DateTime::SpanSet)
   perl(Exporter)
   perl(Params::Validate)
   perl(constant)
   perl(strict)
   perl(vars)
* %check is present and all tests pass:
   All tests successful.
   Files=6, Tests=68, 111 wallclock secs (110.89 cusr +  0.23 csys = 111.12 CPU)
* no shared libraries are present.
* package is not relocatable.
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* no scriptlets present.
* code, not content.
* documentation is small, so no -docs subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.
* no headers.
* no pkgconfig files.
* no libtool .la droppings.
* not a GUI app.

APPROVED

Comment 2 Steven Pritchard 2006-07-13 20:35:09 UTC
Imported into CVS, branches created, and builds requested.


Note You need to log in before you can comment on or make changes to this bug.