Spec URL: http://people.redhat.com/lmacken/python-configobj.spec SRPM URL: http://people.redhat.com/lmacken/python-configobj-4.3.2-1.src.rpm Description: ConfigObj is a simple but powerful config file reader and writer: an ini file round tripper. Its main feature is that it is very easy to use, with a straightforward programmer's interface and a simple syntax for config files. It has lots of other features though: * Nested sections (subsections), to any level * List values * Multiple line values * String interpolation (substitution) * Integrated with a powerful validation system o including automatic type checking/conversion o repeated sections o and allowing default values * All comments in the file are preserved * The order of keys/sections is preserved * No external dependencies * Full Unicode support * A powerful unrepr mode for storing basic datatypes
* typo in the url (it's dl.sf.net, not ds.sf.net) * add --single-version-externally-managed to the %install step, see http://fedoraproject.org/wiki/Packaging/Python for more info
(In reply to comment #1) > * typo in the url (it's dl.sf.net, not ds.sf.net) fixed. > * add --single-version-externally-managed to the %install step, see > http://fedoraproject.org/wiki/Packaging/Python for more info Looks like the setup.py doesn't support the flag: error: option --single-version-externally-managed not recognized error: Bad exit status from /var/tmp/rpm-tmp.90142 (%install) http://people.redhat.com/lmacken/python-configobj-4.3.2-2.src.rpm http://people.redhat.com/lmacken/python-configobj.spec
Review for release 2: * RPM name is OK * Source configobj-4.3.2.zip is the same as upstream * Builds fine in mock * rpmlint looks OK * File list looks OK * Works fine * According to http://peak.telecommunity.com/DevCenter/setuptools#install-command the --single-version-externally-managed option is automatically switched on when the --root option is used, so the guidelines are probably wrong here (or maybe it's a new feature ?) Anyway, APPROVED
Imported into CVS, added to owners.list, requested FC5 branch, tagged and built for FC6. Thanks!