Bug 198285 - Review Request: python-simplejson - Simple, fast, extensible JSON encoder/decoder for Python
Summary: Review Request: python-simplejson - Simple, fast, extensible JSON encoder/dec...
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: John Mahowald
QA Contact: Fedora Package Reviews List
URL:
Whiteboard:
Keywords:
Depends On:
Blocks: FE-ACCEPT 189338
TreeView+ depends on / blocked
 
Reported: 2006-07-10 20:44 UTC by Luke Macken
Modified: 2016-09-20 02:37 UTC (History)
2 users (show)

(edit)
Clone Of:
(edit)
Last Closed: 2006-08-14 20:06:30 UTC


Attachments (Terms of Use)

Description Luke Macken 2006-07-10 20:44:44 UTC
Spec URL: http://people.redhat.com/lmacken/python-simplejson.spec
SRPM URL: http://people.redhat.com/lmacken/python-simplejson-1.3-1.src.rpm
Description:
simplejson is a simple, fast, complete, correct and extensible
JSON <http://json.org> encoder and decoder for Python 2.3+.  It is
pure Python code with no dependencies.

simplejson was formerly known as simple_json, but changed its name to
comply with PEP 8 module naming guidelines.

The encoder may be subclassed to provide serialization in any kind of
situation, without any special support by the objects to be serialized
(somewhat like pickle).

The decoder can handle incoming JSON strings of any specified encoding
(UTF-8 by default).

Comment 1 Jason Tibbitts 2006-07-11 22:51:19 UTC
I'm not terribly well-versed in Python, but this looks to violate the guidelines:

Python packages that use setuptools need to add python-setuptools as a
BuildRequires and must either add --single-version-externally-managed to the
line invoking setup.py in %install, or must add a .pth file containing the path
to the egg or egg directory to %{python_sitelib}.

I don't believe either of those are being done.  In addition:

E: python-simplejson zero-length
/usr/lib/python2.4/site-packages/simplejson-1.3-py2.4.egg-info/zip-safe

In general the packaging here looks odd.  Why is the test suite included in the
installed module, but not called at all by a %check section in the spec?  What
about the contents of
/usr/lib/python2.4/site-packages/simplejson-1.3-py2.4.egg-info?  Shouldn't this
all be %doc, if it must be installed at all?

Comment 2 Luke Macken 2006-07-12 16:38:19 UTC
http://people.redhat.com/lmacken/python-simplejson-1.3-2.src.rpm
http://people.redhat.com/lmacken/python-simplejson.spec

Added --single-version-externally-managed flag to setup.py install.

The tests in the package all import the module itself, and are not setup to be
run from the command line, so I think it would require way too much hassle
(patches or much %{__python} -c uglyness) to deal with to get them running.

As for the egg-info directory, I don't believe there is any policy on this, and
every other python module I've seen packages up the directory and ignores the
empty file warnings.

Comment 3 John Mahowald 2006-08-14 18:00:44 UTC
rpmlint still says

E: python-simplejson zero-length
/usr/lib/python2.4/site-packages/simplejson-1.3-py2.4.egg-info/zip-safe

I agree it can be ignored.

Good:
+ sitelib macro
+ source matches
+ license (MIT)
+ mock builds on devel x86_64
+ proper %clean section
+ macro usage throughout
+ noarch

APPROVED

Comment 4 Luke Macken 2006-08-14 20:06:30 UTC
Imported to CVS, added to owners.list, FC-5 branch requested, tagged and built
for devel.  Thanks!


Note You need to log in before you can comment on or make changes to this bug.