Bug 198708 - Review Request: gnome-vfs2-monikers
Summary: Review Request: gnome-vfs2-monikers
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: David Cantrell
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: FC-ACCEPT
TreeView+ depends on / blocked
 
Reported: 2006-07-12 23:54 UTC by Matthias Clasen
Modified: 2013-01-10 01:27 UTC (History)
1 user (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2006-07-17 19:39:08 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)

Description Matthias Clasen 2006-07-12 23:54:17 UTC
Spec URL: http://people.redhat.com/mclasen/review/gnome-vfs2-monikers.spec
SRPM URL: http://people.redhat.com/mclasen/review/gnome-vfs2-monikers-2.15.3-1.src.rpm
Description: This is a part of the gnome-vfs2 package that has been split
out as a separate tarball upstream. I first wanted to keep it in the
gnome-vfs2 package, but that turned out to be not entirely trivial,
since gnome-vfs2-monikers buildrequires gnome-vfs2.

Comment 1 Jesse Keating 2006-07-13 02:56:54 UTC
NEEDSWORK:
- buildroot needs to follow guidelines
- if possible, Source0 should be a URL to the source.
- missing BR perl(XML::Parser)

rpmlint only has one complaint:
E: gnome-vfs2-monikers zero-length /usr/share/doc/gnome-vfs2-monikers-2.15.3/README

Comment 2 Matthias Clasen 2006-07-13 03:19:45 UTC
New revision, incorporates the feedback

Spec URL: http://people.redhat.com/mclasen/review/gnome-vfs2-monikers.spec
SRPM URL:
http://people.redhat.com/mclasen/review/gnome-vfs2-monikers-2.15.3-2.src.rpm


Comment 3 Jesse Keating 2006-07-13 03:21:57 UTC
Looks good.  Approving.

Since this is just a split-out of existing subpackage, approving for dist too.

Comment 4 Jesse Keating 2006-07-17 19:39:08 UTC
Built in rawhide.


Note You need to log in before you can comment on or make changes to this bug.