Bug 1992153 - consider splitting out logrotate config and dependency in a subpackage
Summary: consider splitting out logrotate config and dependency in a subpackage
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: rsyslog
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Attila Lakatos
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2021-08-10 16:34 UTC by Davide Cavalca
Modified: 2022-09-09 07:27 UTC (History)
12 users (show)

Fixed In Version: rsyslog-8.2102.0-8.fc36
Clone Of:
Environment:
Last Closed: 2021-10-07 06:00:47 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description Davide Cavalca 2021-08-10 16:34:57 UTC
rsyslog currently Requires: logrotate and installs a logrotate config as part of the main rsyslog package. This is fine in most cases, but it isn't ideal for minimal environments (that may not need/want logrotate) and for environments that use a different system (or a different logrotate configuration) for rotating logs (where the default config may conflict or fail). To this end, I'd like to request splitting the logrotate config and its dependency into a rsyslog-logrotate, and adding a Recommends for it to the main rsyslog package. This wouldn't change the default behavior, but it would provide the option to not install the logrotate config if one so desires.

Comment 1 Davide Cavalca 2021-08-10 16:36:58 UTC
I put up https://src.fedoraproject.org/rpms/rsyslog/pull-request/25 as an example for how this could be done.

Comment 2 Davide Cavalca 2021-08-10 16:38:44 UTC
https://bugzilla.redhat.com/show_bug.cgi?id=1992155 tracks the same request for CentOS Stream 9.

Comment 3 Fedora Admin user for bugzilla script actions 2021-08-16 12:09:08 UTC
This package has changed maintainer in Fedora. Reassigning to the new maintainer of this component.

Comment 4 Tobias Florek 2021-09-28 07:29:22 UTC
I'd really like to use rsyslog without logrotate dependency because it pulls in systemd, dbus and many more things not needed in a container.

Comment 5 Fedora Update System 2021-10-07 05:55:46 UTC
FEDORA-2021-246d74538a has been submitted as an update to Fedora 36. https://bodhi.fedoraproject.org/updates/FEDORA-2021-246d74538a

Comment 6 Fedora Update System 2021-10-07 06:00:47 UTC
FEDORA-2021-246d74538a has been pushed to the Fedora 36 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 7 Trevor Hemsley 2022-06-17 23:50:46 UTC
This update really wasn't thought through very well. The update to Fedora 36 that contained this will have just broken every installed system with a working rsyslog/logrotate setup. It just removed all my config files for me so none of my logs have rotated for over a month. Luckily this isn't a particularly "loggy" system but if it had been one of my work ones that has ~1GB per day, this would have broken it quite badly.

Comment 8 Michael S. 2022-07-15 12:08:15 UTC
I concur, we just had a outage due to that https://github.com/gluster/project-infrastructure/issues/168 

A IMHO better scheme would have been to have rsyslog-bin (or something similar), and have a meta rsyslog package that keep the existing functionality.

Comment 9 Attila Lakatos 2022-07-18 09:56:49 UTC
(In reply to Trevor Hemsley from comment #7)
> This update really wasn't thought through very well. The update to Fedora 36
> that contained this will have just broken every installed system with a
> working rsyslog/logrotate setup. It just removed all my config files for me
> so none of my logs have rotated for over a month. Luckily this isn't a
> particularly "loggy" system but if it had been one of my work ones that has
> ~1GB per day, this would have broken it quite badly.

What do you mean by all of your config files? Did you store all of your logrotate commands inside the /etc/logrotate.d/rsyslog file?

Comment 10 Trevor Hemsley 2022-07-18 10:17:56 UTC
Bad choice of words. Make that "Removed the config file that rotates most of my log files" - namely /var/log/cron* /var/log/maillog* /var/log/messages* /var/log/secure* /var/log/spooler*

Comment 11 James Cassell 2022-09-08 20:52:23 UTC
Even better would be to just get rid of the subpackage and make logrotate a weak dep of the main rsyslog package.  The (possibly unused) config files take up almost no space at all.

Comment 12 Attila Lakatos 2022-09-09 07:27:53 UTC
The problem is caused by the fact that owner of the %{buildroot}%{_sysconfdir}/logrotate.d/rsyslog file has changed. As the rsyslog-logrotate package has already been introduced, I would like to keep it. Thus, I propose to change back the ownership of the previously mentioned file to rsyslog(not rsyslog-logrotate). In that case, the file will not get removed/reinstalled while upgrading.

Let me know what you think.


Note You need to log in before you can comment on or make changes to this bug.