Spec URL: http://people.redhat.com/mharris/libutempter.spec SRPM URL: http://people.redhat.com/mharris/libutempter-1.1.4-1.src.rpm Description: libutempter is a replacement for the Red Hat 'utempter' package which is itself originally a fork of Red Hat utempter which has had numerous security enhancments to the Red Hat code, but provides full backward compatibility. Additionally, the new package follows Fedora packaging guidelines more closely by providing standard libfoo and libfoo-devel package naming. Note: This package makes use of two groups, the first 'utmp' which is already allocated and present in the Red Hat 'utempter' package as GID==22, and the second group 'utempter' which is currently unallocated. Once this package has been approved as a replacment for utempter, and any changes implemented which are deemed necessary, a request will be filed to allocate a new GID for the utempter helper utility. Once the GID is allocated, the package will be updated prior to being built in rawhide. After that, the legacy Red Hat 'utempter' package can be deprecated and removed from brew.
[Note to self] Once this is approved and package is built, close bug #193190 also.
Spec looks pretty good, here is some rpmlint output: E: libutempter-debuginfo tag-not-utf8 %changelog E: libutempter-devel tag-not-utf8 %changelog Find the offending changelog entry E: libutempter non-standard-dir-perm /usr/libexec/utempter 0710 E: libutempter non-standard-executable-perm /usr/libexec/utempter/utempter 02711 E: libutempter non-standard-executable-perm /usr/libexec/utempter/utempter 02711 E: libutempter non-standard-gid /usr/libexec/utempter utempter E: libutempter non-standard-gid /usr/libexec/utempter/utempter utmp I'm assuming because this has to run as utmpter and this is ignorable. E: libutempter non-utf8-spec-file libutempter.spec Because of the changelog E: libutempter setgid-binary /usr/libexec/utempter/utempter utmp 02711 Again because of utempter, ignore. E: libutempter tag-not-utf8 %changelog E: libutempter tag-not-utf8 %changelog Changelog again. W: libutempter-devel no-documentation Ignorable W: libutempter macro-in-%changelog _libdir W: libutempter macro-in-%changelog _libdir W: libutempter macro-in-%changelog _sbindir These are probably ignorable as well. Everything else looks OK, so approving. Bill Ack?
It's awfully late... aside from that, no complaints.
(In reply to comment #2) > Spec looks pretty good, here is some rpmlint output: > > E: libutempter-debuginfo tag-not-utf8 %changelog > E: libutempter-devel tag-not-utf8 %changelog Bero's last name was in ISO8859-1 in a changelog entry. Worked around via anglicization. > Find the offending changelog entry > > E: libutempter non-standard-dir-perm /usr/libexec/utempter 0710 Dir restricted to group utempter access for security. > E: libutempter non-standard-executable-perm /usr/libexec/utempter/utempter 02711 > E: libutempter non-standard-executable-perm /usr/libexec/utempter/utempter 02711 Binary restricted to group utempter, with perms for SGID binaries. > E: libutempter non-standard-gid /usr/libexec/utempter utempter This needs to be created once the package is approved, which it sounds like now from above. ;o) > E: libutempter non-standard-gid /usr/libexec/utempter/utempter utmp setuid utmp executable. The GID should be allocated already, if not I'll have to do that, but I assume it is, since RH utempter uses the same GID. > I'm assuming because this has to run as utmpter and this is ignorable. yup > E: libutempter non-utf8-spec-file libutempter.spec > > Because of the changelog yup, fixed. > E: libutempter setgid-binary /usr/libexec/utempter/utempter utmp 02711 > > Again because of utempter, ignore. yup > E: libutempter tag-not-utf8 %changelog > E: libutempter tag-not-utf8 %changelog > > Changelog again. Wow, it reports the same problem 3 different errors for the same issue. > W: libutempter-devel no-documentation Correct, there is no documentation except the README and COPYING. The rpmlint developers are free to submit manpages however. ;o) > W: libutempter macro-in-%changelog _libdir > W: libutempter macro-in-%changelog _libdir > W: libutempter macro-in-%changelog _sbindir > > These are probably ignorable as well. Actually I just noticed them a half hour ago or so and fixed them. Theoretically %_libdir et al. should always expand to a path of some form, however it is also theoretical that they could expand to something else, and macros are illegal in the changelog, so fixed. > Everything else looks OK, so approving. Good beans.
Committed to rawhide now.