Spec URL: https://ankursinha.fedorapeople.org/python-annexremote/python-annexremote.spec SRPM URL: https://ankursinha.fedorapeople.org/python-annexremote/python-annexremote-1.5.0-1.fc34.src.rpm Description: Helper module to easily develop special remotes for git annex. AnnexRemote handles all the protocol stuff for you, so you can focus on the remote itself. It implements the complete external special remote protocol and fulfils all specifications regarding whitespaces etc. This is ensured by an excessive test suite. Extensions to the protocol are normally added within hours after they have been published. Fedora Account System Username: ankursinha (Required for datalad, which is required for spikeextractors)
Suggestions: %if %{with tests} %pyproject_buildrequires -x test -r %else %pyproject_buildrequires -r %endif This can be shortened as: %pyproject_buildrequires -r %{?with_tests:-x test} ------------------------------------------ This makes the tests actually work with pytest, but I got 2 failures (I get the same with nose): # Replace nose with pytest sed -i "s/'nose'/'pytest'/" setup.py sed -i 's/ def Test/ def test_/' tests/test_*.py ------------------------------------------ %if %{with tests} export PYTHONPATH="%{buildroot}/%{python3_sitearch}:%{buildroot}/%{python3_sitelib}:%{pypi_name}" %{pytest} %endif The PYTHONPATH export should not be needed, %pytest already does that.
One more: BuildRequires: python3-setuptools This is not required, it is generated by %pyproject_buildrequires.
Thanks Miro, I've made the suggested changes and sent a patch upstream to fix the two failing tests. Updated spec/srpm: Spec URL: https://ankursinha.fedorapeople.org/python-annexremote/python-annexremote.spec SRPM URL: https://ankursinha.fedorapeople.org/python-annexremote/python-annexremote-1.5.0-1.fc34.src.rpm
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated Package APPROVED. Minor issues: 1) > # The tests are written for nose and pytest cannot find/collect them This comment is outdated now. 2) The license file is packaged twice, you can remove %license LICENSE: $ rpm -ql --licensefiles -p python3-annexremote-1.5.0-1.fc36.noarch.rpm /usr/lib/python3.10/site-packages/annexremote-1.5.0.dist-info/LICENSE /usr/share/licenses/python3-annexremote/LICENSE ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "*No copyright* GNU General Public License, Version 3", "GNU General Public License, Version 3", "*No copyright* [generated file]". [x]: License file installed when any subpackage combination is installed. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [X]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 1 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [x]: Python eggs must not download any dependencies during the build process. [x]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Packages MUST NOT have dependencies (either build-time or runtime) on packages named with the unversioned python- prefix unless no properly versioned package exists. Dependencies on Python packages instead MUST use names beginning with python2- or python3- as appropriate. [x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [-]: Fully versioned dependency in subpackages if applicable. [?]: Package functions as described. [?]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Patches link to upstream bugs/comments/lists or are otherwise justified. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [?]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [?]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: python3-annexremote-1.5.0-1.fc36.noarch.rpm python-annexremote-doc-1.5.0-1.fc36.noarch.rpm python-annexremote-1.5.0-1.fc36.src.rpm python3-annexremote.noarch: W: spelling-error %description -l en_US fulfils -> fulfills, fulfill, fistfuls python3-annexremote.noarch: W: spelling-error %description -l en_US whitespaces -> white spaces, white-spaces, whites paces python-annexremote.src: W: spelling-error %description -l en_US fulfils -> fulfills, fulfill, fistfuls python-annexremote.src: W: spelling-error %description -l en_US whitespaces -> white spaces, white-spaces, whites paces python-annexremote.src:84: W: macro-in-%changelog %autochangelog 3 packages and 0 specfiles checked; 0 errors, 5 warnings. Source checksums ---------------- https://files.pythonhosted.org/packages/source/a/annexremote/annexremote-1.5.0.tar.gz : CHECKSUM(SHA256) this package : 92f32b6f5461cbaeefe0c60b32f9c1e0c1dbe4e57b8ee425affb56f4060f64ef CHECKSUM(SHA256) upstream package : 92f32b6f5461cbaeefe0c60b32f9c1e0c1dbe4e57b8ee425affb56f4060f64ef Requires -------- python3-annexremote (rpmlib, GLIBC filtered): python(abi) python3.10dist(future) python-annexremote-doc (rpmlib, GLIBC filtered): Provides -------- python3-annexremote: python-annexremote python3-annexremote python3.10-annexremote python3.10dist(annexremote) python3dist(annexremote) python-annexremote-doc: python-annexremote-doc Generated by fedora-review 0.7.0 (fed5495) last change: 2019-03-17 Command line :try-fedora-review -b 2001678 -m fedora-rawhide-x86_64 --mock-options=--enablerepo=local Buildroot used: fedora-rawhide-x86_64 Active plugins: Shell-api, Python, Generic Disabled plugins: Perl, Java, C/C++, SugarActivity, Haskell, Ruby, Ocaml, R, fonts, PHP Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH
Thanks very much! I've made the remaining tweaks and requested SCM now. Updated spec/srpm: Spec URL: https://ankursinha.fedorapeople.org/python-annexremote/python-annexremote.spec SRPM URL: https://ankursinha.fedorapeople.org/python-annexremote/python-annexremote-1.5.0-1.fc34.src.rpm https://pagure.io/releng/fedora-scm-requests/issue/36705 Cheers,
(fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/python-annexremote
FEDORA-2021-928a8a7fa9 has been submitted as an update to Fedora 35. https://bodhi.fedoraproject.org/updates/FEDORA-2021-928a8a7fa9
FEDORA-2021-d149f41ccc has been submitted as an update to Fedora 34. https://bodhi.fedoraproject.org/updates/FEDORA-2021-d149f41ccc
FEDORA-2021-928a8a7fa9 has been pushed to the Fedora 35 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2021-928a8a7fa9 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2021-928a8a7fa9 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2021-d149f41ccc has been pushed to the Fedora 34 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2021-d149f41ccc \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2021-d149f41ccc See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2021-d149f41ccc has been pushed to the Fedora 34 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-2021-928a8a7fa9 has been pushed to the Fedora 35 stable repository. If problem still persists, please make note of it in this bug report.