Spec URL: http://kde-redhat.unl.edu/apt/kde-redhat/SPECS/kdeaddons.spec SRPM URL: http://kde-redhat.unl.edu/apt/kde-redhat/all/SRPMS.testing/kdeaddons-3.5.4-1.src.rpm Description: Plugins for some KDE applications that extend the functionality of Konqueror (web browser and file manager), noatun (media player), Kate (text editor), Kicker, knewsticker. %changelog * Tue Jul 25 2006 Rex Dieter <rexdieter[AT]users.sf.net> 3.5.4-1 - kde-3.5.4 * Wed Jun 07 2006 Rex Dieter <rexdieter[AT]users.sf.net> 3.5.3-2 - cleanup for Extras - %%doc: README, app docs (README, TODO, etc...) - follow icon spec - BR: desktop-file-utils * Tue Jun 06 2006 Than Ngo <than> 3.5.3-2 - BR on libtool, automake
This has a good chance of making FE/fc6.
Package Reviewed : http://kde-redhat.unl.edu/apt/kde-redhat/all/SRPMS.stable/kdeaddons-3.5.5-2.src.rpm) * RPM name is OK * Source kdeaddons-3.5.5.tar.bz2 is the same as upstream * Builds fine in mock * rpmlint of kdeaddons looks OK * rpmlint of kdeaddons-atlantikdesigner looks OK * rpmlint of kdeaddons-xmms looks OK * File list of kdeaddons looks OK * File list of kdeaddons-atlantikdesigner looks OK * File list of kdeaddons-xmms looks OK * Config files of kdeaddons looks OK * Works as expected Needs work: * The package should contain the text of the license (wiki: Packaging/ReviewGuidelines). It's in the COPYING-DOCS file. * Desktop file: the Categories tag should contain Application (wiki: PackagingGuidelines#desktop) (not sure it is really required, but IIRC it's needed to appear in the menu) Notes: * Desktop file: the Categories tag should not contain X-Fedora any more. It's harmless, but remember to remove it in the future.
Thanks, I'll fix things up shortly. (Though X-Fedora .desktop category is not required anymore, I'll have to check the Application bit too).
Spec URL: http://kde-redhat.unl.edu/apt/kde-redhat/SPECS/kdeaddons.spec SRPM URL: http://kde-redhat.unl.edu/apt/kde-redhat/all/SRPMS.stable/kdeaddons-3.5.6-2.src.rpm %changelog * Thu Jan 25 2007 Rex Dieter <rdieter[AT]fedoraproject.org> 3.5.6-2 - upstream privacy patch * Tue Jan 16 2007 Rex Dieter <rdieter[AT]fedoraproject.org> 3.5.6-1 - kde-3.5.6
i have merged the changes, added subpackage -extras and removed -xmms and -atlantikdesigner. It's already commited into CVS. The new kdeaddon-3.5.6-2.fc7 is built in rawhide.
Not approved (afaict), reopening.
Aurelien? review status?
Needs work: * The package should contain the text of the license (COPYING-DOCS) (wiki: Packaging/ReviewGuidelines) * Scriptlets: missing "Require(post): xdg-utils" and "Require(postun): xdg-utils" (on kdeaddons and kdeaddons-atlantikdesigner) * As kdeaddons ships icons in the hicolor directory, it should have "Requires: hicolor-icon-theme" (for both binary packages also) https://www.redhat.com/archives/fedora-extras-list/2006-September/msg00282.html Details: * mixed-use-of-spaces-and-tabs (spaces: line 97, tab: line 5) * privacy patch is chmod 744
Re: Requires: hicolor-icon-theme kdelibs already has that Requires, imo, it would be hugely redundant to have every kde apps Requires: it too.
Spec URL: http://kde-redhat.unl.edu/apt/kde-redhat/SPECS/kdeaddons.spec SRPM URL: http://kde-redhat.unl.edu/apt/kde-redhat/all/SRPMS.stable/kdeaddons-3.5.6-3.src.rpm %changelog * Tue Mar 06 2007 Rex Dieter <rdieter[AT]fedoraproject.org> 3.5.6-3 - +%%doc COPYING-DOCS - +Requires(post,postun): xdg-utils
Review for release 3.fc6: * RPM name is OK * Source kdeaddons-3.5.6.tar.bz2 is the same as upstream * Builds fine in mock * rpmlints look OK * File lists look OK * Works OK (39 automatic checks have been run by fedora-qa) APPROVED
i have committed the changes into CVS. Please take a look at kdeaddons-3_5_6-3_fc7. Thanks
Reopened (not merged yet).
rex, what is still missing?
missing: kde packages moved/merged into external cvs.
Please note that %config files in /usr will soon be disallowed : http://fedoraproject.org/wiki/PackagingDrafts/UsrConfigs
KDE is a reasonable exception to that new policy.