Bug 2002848 - Review Request: python-datalad - Keep code, data, containers under control with git and git-annex
Summary: Review Request: python-datalad - Keep code, data, containers under control wi...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Zbigniew Jędrzejewski-Szmek
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: fedora-neuro, NeuroFedora 1931183
TreeView+ depends on / blocked
 
Reported: 2021-09-09 20:20 UTC by Ankur Sinha (FranciscoD)
Modified: 2021-09-24 20:20 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2021-09-20 13:55:24 UTC
Type: ---
Embargoed:
zbyszek: fedora-review+


Attachments (Terms of Use)

Description Ankur Sinha (FranciscoD) 2021-09-09 20:20:33 UTC
Spec URL: https://ankursinha.fedorapeople.org/python-datalad/python-datalad.spec
SRPM URL: https://ankursinha.fedorapeople.org/python-datalad/python-datalad-0.14.7-1.fc34.src.rpm

Description:
DataLad makes data management and data distribution more accessible. To do
that, it stands on the shoulders of Git and Git-annex to deliver a
decentralized system for data exchange. This includes automated ingestion of
data from online portals and exposing it in readily usable form as Git(-annex)
repositories, so-called datasets. The actual data storage and permission
management, however, remains with the original data providers.

The full documentation is available at http://docs.datalad.org and
http://handbook.datalad.org provides a hands-on crash-course on DataLad

Extensions:

A number of extensions are available that provide additional functionality for
DataLad. Extensions are separate packages that are to be installed in addition
to DataLad. In order to install DataLad customized for a particular domain, one
can simply install an extension directly, and DataLad itself will be
automatically installed with it. An annotated list of extensions is available
in the DataLad handbook.

Support:

The documentation for this project is found here: http://docs.datalad.org

All bugs, concerns, and enhancement requests for this software can be submitted
here: https://github.com/datalad/datalad/issues

If you have a problem or would like to ask a question about how to use DataLad,
please submit a question to NeuroStars.org with a datalad tag. NeuroStars.org
is a platform similar to StackOverflow but dedicated to neuroinformatics.

All previous DataLad questions are available here:
http://neurostars.org/tags/datalad/

Fedora Account System Username: ankursinha

Comment 1 Ankur Sinha (FranciscoD) 2021-09-09 20:20:36 UTC
This package built on koji:  https://koji.fedoraproject.org/koji/taskinfo?taskID=75426623

Comment 2 Zbigniew Jędrzejewski-Szmek 2021-09-10 13:35:24 UTC
> The full documentation is available at http://docs.datalad.org and
> http://handbook.datalad.org provides a hands-on crash-course on DataLad
> https://neurostars.org/tag/datalad

https:// seems to work everywhere.

> All bugs, concerns, and enhancement requests for this software can be submitted
> here: https://github.com/datalad/datalad/issues

I don't think we want to direct *all* issue there. Maybe say that for packaging
issues, bugzilla should be used, but there's also an upstream bugtracker…

> %package -n python3-datalad

I think it's appropriate to call this with the python3- prefix, since it's
provides a python module, and people might use that module from other code.
But maybe add "Provides: datalad" to match the executable name?

+ package name is OK
+ license is acceptable for Fedora (MIT)
+ license is specified correctly (*)
+ builds and installs OK
+ BR/R/P look correct
+ fedora-review is happy
+ rpmlint shows only bogus spelling complaints, as usual

(*) There's a GPLv3 file in sources, but it doesn't appear in the built package.

Package is APPROVED.

Comment 3 Ankur Sinha (FranciscoD) 2021-09-10 14:30:25 UTC
Thanks very much for the review Zbigniew!

(In reply to Zbigniew Jędrzejewski-Szmek from comment #2)
> > The full documentation is available at http://docs.datalad.org and
> > http://handbook.datalad.org provides a hands-on crash-course on DataLad
> > https://neurostars.org/tag/datalad
> 
> https:// seems to work everywhere.

Updated all links to use https

> 
> > All bugs, concerns, and enhancement requests for this software can be submitted
> > here: https://github.com/datalad/datalad/issues
> 
> I don't think we want to direct *all* issue there. Maybe say that for
> packaging
> issues, bugzilla should be used, but there's also an upstream bugtracker…

I've just removed that line. The main documentation at datalad.org already notes their GitHub etc. 

> 
> > %package -n python3-datalad
> 
> I think it's appropriate to call this with the python3- prefix, since it's
> provides a python module, and people might use that module from other code.
> But maybe add "Provides: datalad" to match the executable name?

Added.

> 
> + package name is OK
> + license is acceptable for Fedora (MIT)
> + license is specified correctly (*)
> + builds and installs OK
> + BR/R/P look correct
> + fedora-review is happy
> + rpmlint shows only bogus spelling complaints, as usual
> 
> (*) There's a GPLv3 file in sources, but it doesn't appear in the built
> package.
> 
> Package is APPROVED.

Cheers,

Requested SCM now.

Comment 5 Gwyn Ciesla 2021-09-10 14:31:27 UTC
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/python-datalad

Comment 6 Fedora Update System 2021-09-10 15:29:14 UTC
FEDORA-2021-a68dc4be69 has been submitted as an update to Fedora 35. https://bodhi.fedoraproject.org/updates/FEDORA-2021-a68dc4be69

Comment 7 Fedora Update System 2021-09-10 15:29:15 UTC
FEDORA-2021-3902f1860d has been submitted as an update to Fedora 34. https://bodhi.fedoraproject.org/updates/FEDORA-2021-3902f1860d

Comment 8 Fedora Update System 2021-09-10 22:12:38 UTC
FEDORA-2021-a68dc4be69 has been pushed to the Fedora 35 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2021-a68dc4be69 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2021-a68dc4be69

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 9 Fedora Update System 2021-09-13 03:54:40 UTC
FEDORA-2021-3902f1860d has been pushed to the Fedora 34 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2021-3902f1860d \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2021-3902f1860d

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 10 Fedora Update System 2021-09-20 13:55:24 UTC
FEDORA-2021-3902f1860d has been pushed to the Fedora 34 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 11 Hunor Csomortáni 2021-09-23 11:51:09 UTC
Little bit late to the party, but as I was checking out this package it seems to me that parts of the code have a different license (Python and BSD-3), as specified in [datalad/COPYING] '3rd Party Code'. Shouldn't the 'License' field follow the [Multiple Licensing Scenario] in this case?

[datalad/COPYING]: https://github.com/datalad/datalad/blob/master/COPYING#L32
[Multiple Licensing Scenario]: https://docs.fedoraproject.org/en-US/packaging-guidelines/LicensingGuidelines/#_multiple_licensing_scenarios

Comment 12 Ankur Sinha (FranciscoD) 2021-09-23 12:31:15 UTC
Hi Hunor,

Thanks for the note. You are looking at the master branch, but we're still on 0.14.7 in Fedora where the third party code is MIT or BSD licensed:
https://github.com/datalad/datalad/blob/0.14.7/COPYING

I've just double-checked the licenses in the tar too, just to be sure:

$ licensecheck -r . | sed '/UNKNOWN/ d'
./datalad-0.14.7/.zenodo.json: MIT License
./datalad-0.14.7/COPYING: MIT License
./datalad-0.14.7/README.md: *No copyright* MIT License
./datalad-0.14.7/setup.py: *No copyright* MIT License
./datalad-0.14.7/versioneer.py: *No copyright* Public domain
./datalad-0.14.7/datalad/utils.py: *No copyright* MIT License
./datalad-0.14.7/sandbox/git-annex-remote-gitobjects: GNU General Public License, Version 3
./datalad-0.14.7/tools/mimic_merges: MIT License
./datalad-0.14.7/tools/mimic_repo: MIT License
./datalad-0.14.7/tools/monitor-interrupts.py: MIT License
./datalad-0.14.7/tools/urlinfo: MIT License
./datalad-0.14.7/datalad/interface/rerun.py: *No copyright*  [generated file]
./datalad-0.14.7/datalad/support/collections.py: *No copyright* MIT License
./datalad-0.14.7/datalad/support/configparserinc.py: *No copyright* MIT License
./datalad-0.14.7/datalad/plugin/tests/test_plugins.py: *No copyright* Open Data Commons Public Domain Dedication & License
./datalad-0.14.7/datalad/support/tests/test_locking.py: *No copyright* MIT License
./datalad-0.14.7/datalad/support/third/nda_aws_token_generator.py: *No copyright* MIT License
./datalad-0.14.7/datalad/resources/website/assets/js/jquery-2.2.4.js: MIT License
./datalad-0.14.7/datalad/resources/website/assets/js/jquery.dataTables-1.10.12.js: MIT License
./datalad-0.14.7/datalad/resources/website/assets/js/md5-2.3.0.js: MIT License
./datalad-0.14.7/datalad/resources/website/tests/qunit/qunit-2.0.1.css: MIT License
./datalad-0.14.7/datalad/resources/website/tests/qunit/qunit-2.0.1.js: MIT License

When we update to the next release, we'll have to check the license again etc. and update the spec accordingly.
Thanks for pointing it out---good to have it noted.

Cheers,

Comment 13 Ankur Sinha (FranciscoD) 2021-09-23 12:42:53 UTC
I've opened this bug now. Since it's bundling a few bits which do end up in the rpm, I need to mention them in the spec: https://bugzilla.redhat.com/show_bug.cgi?id=2007263

Comment 14 Fedora Update System 2021-09-24 20:20:58 UTC
FEDORA-2021-a68dc4be69 has been pushed to the Fedora 35 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.