Bug 2009418 - Review Request: golang-github-cli-browser - Go helpers to open URLs, files, or readers in a web browser
Summary: Review Request: golang-github-cli-browser - Go helpers to open URLs, files, o...
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Maxwell G
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 1803302 2009419 2010367
TreeView+ depends on / blocked
 
Reported: 2021-09-30 15:32 UTC by Mikel Olasagasti Uranga
Modified: 2021-12-10 20:32 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2021-12-10 20:32:12 UTC
Type: ---
Embargoed:
maxwell: fedora-review+

Attachments (Terms of Use)

Description Mikel Olasagasti Uranga 2021-09-30 15:32:52 UTC 
Spec URL: https://mikel.olasagasti.info/tmp/fedora/golang-github-cli-browser.spec
SRPM URL: https://mikel.olasagasti.info/tmp/fedora/golang-github-cli-browser-1.1.0-1.fc34.src.rpm
Description: Go helpers to open URLs, files, or readers in a web browser
Fedora Account System Username: mikelo2
Comment 1 Maxwell G 2021-12-10 03:06:20 UTC 
I am not going to go through the whole fedora-review template, as this package
uses go2rpm. I reviewed based on this copr build:
https://download.copr.fedorainfracloud.org/results/mikelo2/github-cli/fedora-rawhide-x86_64/03005885-golang-github-cli-browser/

- The specfile is sane.
- License is correct
- Builds successfully in mock
- All rpmlint errors are spurious
- %check section passes
- The latest version is packaged

Package approved!

When you import this package, don't forget to add `Fixes rhbz#2009418` to the
rpm changelog and/or manually add this bug to the Bodhi update so it gets
marked as CLOSED. I also added your package to Antiya/release-monitoring.org. I
think you should give go-sig admin privileges when the package is
imported, as well.
Comment 2 Gwyn Ciesla 2021-12-10 14:36:43 UTC 
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-github-cli-browser
Note You need to log in before you can comment on or make changes to this bug.