Bug 2009487 - Review Request: golang-github-yuin-goldmark-emoji - An emoji extension for the goldmark markdown parser
Summary: Review Request: golang-github-yuin-goldmark-emoji - An emoji extension for th...
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Maxwell G
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 1803302 2009520 2010367
TreeView+ depends on / blocked
 
Reported: 2021-09-30 18:55 UTC by Mikel Olasagasti Uranga
Modified: 2021-12-07 23:03 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2021-12-07 23:03:02 UTC
Type: ---
Embargoed:
maxwell: fedora-review+


Attachments (Terms of Use)

Description Mikel Olasagasti Uranga 2021-09-30 18:55:49 UTC
Spec URL: https://mikel.olasagasti.info/tmp/fedora/golang-github-yuin-goldmark-emoji.spec
SRPM URL: https://mikel.olasagasti.info/tmp/fedora/golang-github-yuin-goldmark-emoji-1.0.1-1.fc34.src.rpm
Description: An emoji extension for the goldmark markdown parser
Fedora Account System Username: mikelo2

Comment 1 Maxwell G 2021-12-05 04:11:50 UTC
> %files
> %license LICENSE
> %doc README.md

You should remove this. This package does not include any binaries, so only the `-devel` subpackage is necessary.

Comment 2 Mikel Olasagasti Uranga 2021-12-06 20:28:54 UTC
Spec URL: https://mikel.olasagasti.info/tmp/fedora/golang-github-yuin-goldmark-emoji.spec
SRPM URL: https://mikel.olasagasti.info/tmp/fedora/golang-github-yuin-goldmark-emoji-1.0.1-1.fc35.src.rpm

Removed %files section. It was a leftover for the cli tool detected by go2rpm

Comment 3 Maxwell G 2021-12-07 20:20:46 UTC
I am not going to go through the whole fedora-review template, as this package uses go2rpm. I reviewed based on this copr build: https://download.copr.fedorainfracloud.org/results/mikelo2/github-cli/fedora-rawhide-x86_64/03007382-golang-github-yuin-goldmark-emoji/

- The specfile is sane.
- License is correct
- Builds successfully in mock
- All rpmlint errors are spurious
- %check section passes
- The latest version is packaged

Package approved!

When you import this package, don't forget to add `Fixes rhbz#2009487` to the
rpm changelog and/or manually add this bug to the Bodhi update so it gets
marked as CLOSED. I also added your package to Antiya/release-monitoring.org. I
think you should give go-sig admin privileges when the package is
imported, as well.

Comment 4 Gwyn Ciesla 2021-12-07 21:47:05 UTC
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-github-yuin-goldmark-emoji


Note You need to log in before you can comment on or make changes to this bug.