Spec URL: https://music.fedorapeople.org/python-mapbox-earcut.spec SRPM URL: https://music.fedorapeople.org/python-mapbox-earcut-0.12.10-1.fc34.src.rpm Description: Python bindings for the C++ implementation of the Mapbox Earcut library, which provides very fast and quite robust triangulation of 2D polygons. Original code: earcut.hpp Original description: The library implements a modified ear slicing algorithm, optimized by z-order curve hashing and extended to handle holes, twisted polygons, degeneracies and self-intersections in a way that doesn’t guarantee correctness of triangulation, but attempts to always produce acceptable results for practical data like geographical shapes. Fedora Account System Username: music This is a weak dependency for the existing python-trimesh package (a @neuro-sig package). Koji scratch builds: F36: https://koji.fedoraproject.org/koji/taskinfo?taskID=78072129 F35: https://koji.fedoraproject.org/koji/taskinfo?taskID=78072715 F34: https://koji.fedoraproject.org/koji/taskinfo?taskID=78072765
Updated with suggested improvements for PR#11 from upstream. Spec URL: https://music.fedorapeople.org/20211103/python-mapbox-earcut.spec SRPM URL: https://music.fedorapeople.org/20211103/python-mapbox-earcut-0.12.10-1.fc34.src.rpm Koji scratch builds: F36: https://koji.fedoraproject.org/koji/taskinfo?taskID=78294953 F35: https://koji.fedoraproject.org/koji/taskinfo?taskID=78294954 F34: https://koji.fedoraproject.org/koji/taskinfo?taskID=78294961
Upstream has released 1.0.0. I will prepare an updated submission.
Upstream has released version 1.0.0, which upstreams two patches and can be packaged much more cleanly. New spec URL: https://music.fedorapeople.org/20211104/python-mapbox-earcut.spec New SRPM URL: https://music.fedorapeople.org/20211104/python-mapbox-earcut-1.0.0-1.fc34.src.rpm F36: https://koji.fedoraproject.org/koji/taskinfo?taskID=78336410 F35: https://koji.fedoraproject.org/koji/taskinfo?taskID=78336411 F34: https://koji.fedoraproject.org/koji/taskinfo?taskID=78336412
#info from todays meeting: we'll take this up for review this/next week
Hello @code The build seems to be failing ERROR: Command errored out with exit status 1: /usr/bin/python3 /usr/lib/python3.10/site-packages/pip/_vendor/pep517/in_process/_in_process.py prepare_metadata_for_build_wheel /builddir/build/BUILD/mapbox_earcut_python-1.0.0/.pyproject-builddir/tmp4fhb13iz Check the logs for full command output. error: Bad exit status from /var/tmp/rpm-tmp.9CSpnI (%build)
It comes from: > # Keep pybind11 from automatically disabling debugging symbols. > sed -r -i \ > 's/^(setup\()/ext_modules[0]\.extra_compile_args.remove\("-g0"\)\n\1/' \ > setup.py Apparently, a new version of pybind11, built for Rawhide since I originally submitted this package, has stopped doing that. I have adjusted the spec file so that the setup.py patch is only applied in F34–F35, where it is still required for older pybind11 versions. New spec URL: https://music.fedorapeople.org/20220119/python-mapbox-earcut.spec New SRPM URL: https://music.fedorapeople.org/20220119/python-mapbox-earcut-1.0.0-1.fc35.src.rpm New koji scratch builds: F36: https://koji.fedoraproject.org/koji/taskinfo?taskID=81453910 F35: https://koji.fedoraproject.org/koji/taskinfo?taskID=81453912 F34: https://koji.fedoraproject.org/koji/taskinfo?taskID=81453915
This is a pre-review looks good. Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Dist tag is present. ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [ ]: Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files in private %_libdir subdirectory (see attachment). Verify they are not in ld path. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "ISC License". 10 files have unknown license. Detailed output of licensecheck in /home/vanessa/Desktop/reviews/2018705-python-mapbox- earcut/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [ ]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [x]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 1 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [x]: Python eggs must not download any dependencies during the build process. [x]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Packages MUST NOT have dependencies (either build-time or runtime) on packages named with the unversioned python- prefix unless no properly versioned package exists. Dependencies on Python packages instead MUST use names beginning with python2- or python3- as appropriate. [x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [ ]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in python3-mapbox-earcut [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- rpmlint: 2.1.0 configuration: /usr/lib/python3.10/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/licenses.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 31, packages: 1 python-mapbox-earcut.spec:90: W: macro-in-%changelog %autochangelog 1 packages and 0 specfiles checked; 0 errors, 1 warnings, 0 badness; has taken 4.3 s Rpmlint (installed packages) ---------------------------- Cannot parse rpmlint output: Unversioned so-files -------------------- python3-mapbox-earcut: /usr/lib64/python3.10/site-packages/mapbox_earcut.cpython-310-x86_64-linux-gnu.so Source checksums ---------------- https://github.com/skogler/mapbox_earcut_python/archive/v1.0.0/mapbox_earcut_python-1.0.0.tar.gz : CHECKSUM(SHA256) this package : 2b6da6d398ede7911390968c45418e60230456c9bc940f361f90d51a391feafe CHECKSUM(SHA256) upstream package : 2b6da6d398ede7911390968c45418e60230456c9bc940f361f90d51a391feafe Requires -------- python3-mapbox-earcut (rpmlib, GLIBC filtered): libc.so.6()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgcc_s.so.1(GCC_3.3.1)(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libstdc++.so.6(CXXABI_1.3.13)(64bit) libstdc++.so.6(CXXABI_1.3.2)(64bit) libstdc++.so.6(CXXABI_1.3.3)(64bit) libstdc++.so.6(CXXABI_1.3.5)(64bit) libstdc++.so.6(CXXABI_1.3.9)(64bit) python(abi) python3.10dist(numpy) rtld(GNU_HASH) python-mapbox-earcut-debugsource (rpmlib, GLIBC filtered): Provides -------- python3-mapbox-earcut: python-mapbox-earcut python3-mapbox-earcut python3-mapbox-earcut(x86-64) python3.10-mapbox-earcut python3.10dist(mapbox-earcut) python3dist(mapbox-earcut) python-mapbox-earcut-debugsource: python-mapbox-earcut-debugsource python-mapbox-earcut-debugsource(x86-64) Generated by fedora-review 0.7.6 (b083f91) last change: 2020-11-10 Command line :/usr/bin/fedora-review -b 2018705 Buildroot used: fedora-rawhide-x86_64 Active plugins: Python, C/C++, Generic, Shell-api Disabled plugins: Haskell, PHP, R, Ocaml, Java, Perl, SugarActivity, fonts Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH
Vanessa, if you're happy with the package, please approve it also. The steps to follow are here: https://docs.fedoraproject.org/en-US/package-maintainers/Package_Review_Process/#_reviewer
This package is approved
Thank you!
(fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/python-mapbox-earcut
FEDORA-2022-91c60c77d6 has been submitted as an update to Fedora 36. https://bodhi.fedoraproject.org/updates/FEDORA-2022-91c60c77d6
FEDORA-2022-91c60c77d6 has been pushed to the Fedora 36 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-2022-6cd25da316 has been submitted as an update to Fedora 35. https://bodhi.fedoraproject.org/updates/FEDORA-2022-6cd25da316
FEDORA-2022-12ca3ade13 has been submitted as an update to Fedora 34. https://bodhi.fedoraproject.org/updates/FEDORA-2022-12ca3ade13
FEDORA-2022-12ca3ade13 has been pushed to the Fedora 34 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2022-12ca3ade13 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-12ca3ade13 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2022-6cd25da316 has been pushed to the Fedora 35 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2022-6cd25da316 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-6cd25da316 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2022-12ca3ade13 has been pushed to the Fedora 34 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-2022-6cd25da316 has been pushed to the Fedora 35 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-EPEL-NEXT-2022-0a99709231 has been submitted as an update to Fedora EPEL 9 Next. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-NEXT-2022-0a99709231
FEDORA-EPEL-NEXT-2022-0a99709231 has been pushed to the Fedora EPEL 9 Next testing repository. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-NEXT-2022-0a99709231 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-EPEL-NEXT-2022-0a99709231 has been pushed to the Fedora EPEL 9 Next stable repository. If problem still persists, please make note of it in this bug report.