Spec URL: http://people.redhat.com/~katzj/xeninst/python-xeninst.spec SRPM URL: http://people.redhat.com/~katzj/xeninst/python-xeninst-0.9-1.src.rpm Description: Set of python modules to create and install Xen guests. Note that this is a refactoring of the xenguest-install code currently included in the xen package itself. It's being split out to ease maintenance as well as to make it easier for other things (virt-manager) to use it.
Everything looks good. rpmlint complains about the #! in some .py files. Do these .py files have an init or main? Do they do anything if executed on their own? E: python-xeninst non-executable-script /usr/lib/python2.4/site-packages/xeninst/util.py 0644 E: python-xeninst non-executable-script /usr/lib/python2.4/site-packages/xeninst/FullVirtGuest.py 0644 E: python-xeninst non-executable-script /usr/lib/python2.4/site-packages/xeninst/XenGuest.py 0644 E: python-xeninst non-executable-script /usr/lib/python2.4/site-packages/xeninst/ParaVirtGuest.py 0644
Nope, but you want python -tt at the top to make it easier to a) add some test coverage (not there yet, but I do actually want to write a little bit of that :-) and b) so that you can always be sure that tabs/spaces are being used consistently in files.
Ok, I can waive on that. Approved. I'll let you make the ocmps changes (: Added to dist-fc6.
Built and comps change made (well, as soon as intltool finishes translation merging anyway)