Bug 2030895 - Review Request: python-shortuuid - A generator library for concise, unambiguous and URL-safe UUIDs
Summary: Review Request: python-shortuuid - A generator library for concise, unambiguo...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Neal Gompa
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: MailmanTracker 2030898
TreeView+ depends on / blocked
 
Reported: 2021-12-09 23:59 UTC by Michel Lind
Modified: 2021-12-17 01:12 UTC (History)
3 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2021-12-17 01:12:12 UTC
Type: ---
Embargoed:
ngompa13: fedora-review+


Attachments (Terms of Use)

Description Michel Lind 2021-12-09 23:59:26 UTC
Spec URL: https://salimma.fedorapeople.org/specs/python/python-shortuuid.spec
SRPM URL: https://salimma.fedorapeople.org/specs/python/python-shortuuid-1.0.8-1.fc35.src.rpm
Description:
shortuuid is a simple python library that generates concise, unambiguous,
URL-safe UUIDs.

Often, one needs to use non-sequential IDs in places where users will see them,
but the IDs must be as concise and easy to use as possible. shortuuid solves
this problem by generating uuids using Python's built-in uuid module and then
translating them to base57 using lowercase and uppercase letters and digits, and
removing similar-looking characters such as l, 1, I, O and 0.

Fedora Account System Username: salimma

Comment 1 Neal Gompa 2021-12-10 00:19:44 UTC
Review notes:

[x]: Package follows Fedora Python Packaging Guidelines
[x]: Package builds and installs
[x]: No serious issues from rpmlint
[x]: License is correctly identified and installed

PACKAGE APPROVED.

Comment 2 Michel Lind 2021-12-10 00:50:55 UTC
~ took 3s 
❯ fedpkg request-repo python-shortuuid 2030895
https://pagure.io/releng/fedora-scm-requests/issue/39254

Comment 3 Miro Hrončok 2021-12-10 01:26:43 UTC
BuildRequires:  python%{python3_pkgversion}-setuptools

This should *not* be needed if you use %pyproject_buildrequires.

Comment 4 Michel Lind 2021-12-11 04:42:07 UTC
(In reply to Miro Hrončok from comment #3)
> BuildRequires:  python%{python3_pkgversion}-setuptools
> 
> This should *not* be needed if you use %pyproject_buildrequires.

thanks, will fix when importing

Package was unretired but f35 branch is still blocked: https://pagure.io/releng/issue/10455

Comment 5 Fedora Update System 2021-12-15 19:20:05 UTC
FEDORA-2021-f19f2ab745 has been submitted as an update to Fedora 35. https://bodhi.fedoraproject.org/updates/FEDORA-2021-f19f2ab745

Comment 6 Fedora Update System 2021-12-16 02:08:53 UTC
FEDORA-2021-f19f2ab745 has been pushed to the Fedora 35 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2021-f19f2ab745 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2021-f19f2ab745

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 7 Fedora Update System 2021-12-17 01:12:12 UTC
FEDORA-2021-f19f2ab745 has been pushed to the Fedora 35 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.