Spec URL: https://ffmancera.fedorapeople.org/rust-netlink-packet-generic/rust-netlink-packet-generic.spec SRPM URL: https://ffmancera.fedorapeople.org/rust-netlink-packet-generic/rust-netlink-packet-generic-0.1.0-1.fc35.src.rpm Description: Rust netlink library used to identify and manage generic netlink packet types. Fedora Account System Username: ffmancera
Please, notice that this package is required to upgrade nispor, which is an existing fedora package. https://koji.fedoraproject.org/koji/buildinfo?buildID=1836976
Taking this review. Package in general looks acceptable, but the .crate source file from your SRPM does not match one downloaded from crates.io. What did you do?
(In reply to Fabio Valentini from comment #2) > Taking this review. > > Package in general looks acceptable, but the .crate source file from your > SRPM does not match one downloaded from crates.io. What did you do? Hi! Thank you for the review. I adjusted some dependencies versions but I noticed these changes are not needed. I have updated the SRPM. Please, check it out, thanks!
Right. Changing Cargo.lock is not necessary since that file is disregarded during builds. === Package was generated with rust2rpm, simplifying the review. - package builds and installs without errors on rawhide - test suite is run and all unit tests pass - latest version of the crate is packaged - license matches upstream specification and is acceptable for Fedora - license file is included with %license in %files - package complies with Rust Packaging Guidelines Package APPROVED. === Recommended post-import rust-sig tasks: - add package to rust-sig with "commit" access - set bugzilla assignee overrides to @rust-sig (optional) - set up package on release-monitoring.org: project: $crate homepage: https://crates.io/crates/$crate backend: crates.io version scheme: semantic version filter: alpha;beta;rc;pre - track package in koschei for all built branches
*** Bug 2012041 has been marked as a duplicate of this bug. ***
(fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-netlink-packet-generic
It looks like you imported a spec file that was already parsed by rpmautospec, not sure if that will break things or not. Please make sure that you remove the generated header and changelog, and that Release and %changelog match "rust2rpm -a" again.
I also recommend that you complete the "Recommended post-import rust-sig tasks" I mentioned in Comment 4. It makes maintaining thousands of Rust packages in Fedora much easier for me.
Oh, I will fix the spec file. The build succeed and there is no problem when installing the package, anyway, I will fix that right now. About the "Recommended post-import rust-sig tasks" only adding the package to rust-sig is missing, I will do it. Thank you!
(In reply to Fabio Valentini from comment #8) > I also recommend that you complete the "Recommended post-import rust-sig > tasks" I mentioned in Comment 4. > It makes maintaining thousands of Rust packages in Fedora much easier for me. I have added the package to rust-sig with commit access. I think https://bugzilla.redhat.com/show_bug.cgi?id=2033058 is available for review.