Please, notice this must be built with https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=2033058 and https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=2033035. This package is required to upgrade nispor, which is an existing fedora package. https://koji.fedoraproject.org/koji/buildinfo?buildID=1836976

Taking this for a review too.

Seems like most of the points from https://bugzilla.redhat.com/show_bug.cgi?id=2033058 apply here too, so I'll hold back until the points are resolved.

I have rebased the package to the last version.

Spec URL: https://ffmancera.fedorapeople.org/rust-ethtool/rust-ethtool.spec
SRPM URL: https://ffmancera.fedorapeople.org/rust-ethtool/rust-ethtool-0.2.1-1.fc36.src.rpm

Notice that you will need:

SRPM: https://ffmancera.fedorapeople.org/rust-genetlink/rust-genetlink-0.2.1-1.fc36.src.rpm

* Package named appropriately
* Packaging the latest version
* SPEC file clean and legible
* Macros used consistently
* Builds fine in mock
* MIT license is good for inclusion in Fedora
* Filelists sane (as far as Rust packaging goes anyway)
* Provides/Requires sane
* rpmlint is reasonably happy

rpmlint warns about this:

rust-ethtool-devel.noarch: W: files-duplicate /usr/share/doc/rust-ethtool-devel/README.md /usr/share/cargo/registry/ethtool-0.2.1/README.md

I guess that's okay for now. If possible, %exclude one of the copy and make
sure the remaining one is marked %doc. No big deal if you choose not to
though.

0.) License needs clarification

It seems that the package was intended to be licensed under the "MIT" license terms, but the terms are missing.
What's coloqually known as "MIT" license typically includes this clause:

  The above copyright notice and this permission notice shall be included
  in all copies or substantial portions of the Software.

That would be difficult to comply with given upstream doesn't include the license text.
(In fact I'm calling the police right now, expect a knock on your door soon.)

The Licensing Guidelines have a suggestion on how to deal with this:

https://docs.fedoraproject.org/en-US/packaging-guidelines/LicensingGuidelines/#_license_text

In short, you should just ask upstream to clarify things. In case they fail
to do so, copy the license text you believe upstream intended to use from a
canonical source and add it to the package.

Hi! I clarified this with upstream community in: https://github.com/little-dude/netlink/commit/4171970cacf911477aa81d71c26bcc3afbcc7c49

But we cannot wait for upstream release. What do you think about adding LICENSE-MIT as source temporarily and add this to the specfile?

 %files          devel
 %doc README.md
+%license LICENSE-MIT
 %{cargo_registry}/%{crate}-%{version_no_tilde}/

Thanks!

Yeah, you can include that file with something like:

# license file was added upstream but is not included published crates yet
Source1: https://github.com/little-dude/netlink/raw/4171970/LICENSE-MIT

This way it's documented where the file comes from, and "spectool -g *.spec" can even get the file for you.

You'll also need this in %prep:
cp %{SOURCE1} .

and in %files, as you mentioned:
%license LICENSE-MIT

This arrangement is fine until the file is included in a published version of the crate.

Thank you.

The package is APPROVED

(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-ethtool

FEDORA-2022-1f9732ce73 has been submitted as an update to Fedora 36. https://bodhi.fedoraproject.org/updates/FEDORA-2022-1f9732ce73

FEDORA-2022-1f9732ce73 has been pushed to the Fedora 36 stable repository.
If problem still persists, please make note of it in this bug report.