Bug 2038469 - Review Request: rust-nu-ansi-term - Library for ANSI terminal colors and styles (bold, underline)
Summary: Review Request: rust-nu-ansi-term - Library for ANSI terminal colors and styl...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Davide Cavalca
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: 2038468
Blocks: 2038505 2038644 2038648 2038653 2038789
TreeView+ depends on / blocked
 
Reported: 2022-01-08 00:04 UTC by Michel Lind
Modified: 2022-04-09 18:03 UTC (History)
3 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2022-04-05 00:16:56 UTC
Type: ---
Embargoed:
davide: fedora-review+


Attachments (Terms of Use)

Description Michel Lind 2022-01-08 00:04:12 UTC
Spec URL: https://salimma.fedorapeople.org/specs/rust/rust-nu-ansi-term.spec
SRPM URL: https://salimma.fedorapeople.org/specs/rust/rust-nu-ansi-term-0.42.0-1.fc35.src.rpm
Description:
Library for ANSI terminal colors and styles (bold, underline).

Fedora Account System Username: salimma

Comment 1 Fabio Valentini 2022-01-21 21:34:24 UTC
Package was generated with rust2rpm, simplifying the review.

- package builds and installs without errors on rawhide
- test suite is run and all unit tests pass
! latest version of the crate is NOT packaged
- license matches upstream specification (MIT) and is acceptable for Fedora
- license file is included with %license in %files
- package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks:

- add package to rust-sig with "commit" access

- set bugzilla assignee overrides to @rust-sig (optional)

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version filter: alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- track package in koschei for all built branches

===

Please update to version 0.43.0, if possible.
Also include a descriptive comment above the patch, something like:

# * drop Windows-specific dependencies

But those two points don't block the review, so APPROVED it is.

Comment 2 Davide Cavalca 2022-03-31 18:10:45 UTC
Looks like this review expired

Comment 3 Davide Cavalca 2022-03-31 18:11:32 UTC
Reapproved.

Comment 4 Michel Lind 2022-03-31 18:13:14 UTC
Thanks both!

specs/rust on  master [?]
❯ fedpkg request-repo rust-nu-ansi-term 2038469
https://pagure.io/releng/fedora-scm-requests/issue/43301

specs/rust on  master [?] took 15s
❯ fedpkg request-repo rust-nu-ansi-term 2038469^C

specs/rust on  master [?] took 15s
❯ fedpkg request-branch --dry-run --repo rust-nu-ansi-term --all-releases
Would have filed: New Branch "f36" for "rpms/rust-nu-ansi-term"
```
{
 "action": "new_branch",
 "branch": "f36",
 "namespace": "rpms",
 "repo": "rust-nu-ansi-term",
 "create_git_branch": true
}
```

Would have filed: New Branch "f35" for "rpms/rust-nu-ansi-term"
```
{
 "action": "new_branch",
 "branch": "f35",
 "namespace": "rpms",
 "repo": "rust-nu-ansi-term",
 "create_git_branch": true
}
```

Would have filed: New Branch "f34" for "rpms/rust-nu-ansi-term"
```
{
 "action": "new_branch",
 "branch": "f34",
 "namespace": "rpms",
 "repo": "rust-nu-ansi-term",
 "create_git_branch": true
}
```


specs/rust on  master [?]
❯ fedpkg request-branch --repo rust-nu-ansi-term --all-releases
https://pagure.io/releng/fedora-scm-requests/issue/43302
https://pagure.io/releng/fedora-scm-requests/issue/43303
https://pagure.io/releng/fedora-scm-requests/issue/43304

Comment 5 Mohan Boddu 2022-03-31 19:03:18 UTC
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-nu-ansi-term

Comment 6 Fedora Update System 2022-04-01 04:28:31 UTC
FEDORA-2022-d6bcfee763 has been submitted as an update to Fedora 35. https://bodhi.fedoraproject.org/updates/FEDORA-2022-d6bcfee763

Comment 7 Fedora Update System 2022-04-01 04:28:32 UTC
FEDORA-2022-98d68cea03 has been submitted as an update to Fedora 36. https://bodhi.fedoraproject.org/updates/FEDORA-2022-98d68cea03

Comment 8 Fedora Update System 2022-04-01 04:28:33 UTC
FEDORA-2022-a8d29865fb has been submitted as an update to Fedora 34. https://bodhi.fedoraproject.org/updates/FEDORA-2022-a8d29865fb

Comment 9 Fedora Update System 2022-04-02 01:25:04 UTC
FEDORA-2022-98d68cea03 has been pushed to the Fedora 36 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2022-98d68cea03 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-98d68cea03

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 10 Fedora Update System 2022-04-02 02:41:21 UTC
FEDORA-2022-d6bcfee763 has been pushed to the Fedora 35 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2022-d6bcfee763 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-d6bcfee763

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 11 Fedora Update System 2022-04-02 02:46:45 UTC
FEDORA-2022-a8d29865fb has been pushed to the Fedora 34 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2022-a8d29865fb \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-a8d29865fb

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 12 Fedora Update System 2022-04-05 00:16:56 UTC
FEDORA-2022-98d68cea03 has been pushed to the Fedora 36 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 13 Fedora Update System 2022-04-09 17:36:36 UTC
FEDORA-2022-d6bcfee763 has been pushed to the Fedora 35 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 14 Fedora Update System 2022-04-09 18:03:54 UTC
FEDORA-2022-a8d29865fb has been pushed to the Fedora 34 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.