Bug 2038653 - Review Request: rust-nu-engine - Core commands for nushell
Summary: Review Request: rust-nu-engine - Core commands for nushell
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Fabio Valentini
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: 2038469 2038612 2038636 2038652 2075626
Blocks: 2038638 2038736
TreeView+ depends on / blocked
 
Reported: 2022-01-09 07:47 UTC by Michel Lind
Modified: 2022-05-07 04:26 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2022-04-28 05:50:43 UTC
Type: ---
Embargoed:
decathorpe: fedora-review+


Attachments (Terms of Use)

Description Michel Lind 2022-01-09 07:47:14 UTC
Spec URL: https://salimma.fedorapeople.org/specs/rust/rust-nu-engine.spec
SRPM URL: https://salimma.fedorapeople.org/specs/rust/rust-nu-engine-0.42.0-1.fc35.src.rpm
Description: Core commands for nushell.
Fedora Account System Username: salimma

Comment 2 Fabio Valentini 2022-04-14 19:08:54 UTC
Make sure to build rust-nu-glob and rust-nu-protocol before this package, otherwise it will have broken dependencies.

Did you disable the "plugin" feature on purpose, or did you just not regenerate the .spec file for 0.61.0?

+%package     -n %{name}+plugin-devel
+Summary:        %{summary}
+BuildArch:      noarch
+
+%description -n %{name}+plugin-devel %{_description}
+
+This package contains library source intended for building other packages which
+use the "plugin" feature of the "%{crate}" crate.
+
+%files       -n %{name}+plugin-devel
+%ghost %{crate_instdir}/Cargo.toml
+

Comment 3 Michel Lind 2022-04-14 22:56:01 UTC
I disabled plugin on purpose, as it depends on nu-plugin which depends on nu-engine: https://crates.io/crates/nu-plugin/0.61.0/dependencies

Comment 4 Fabio Valentini 2022-04-14 23:04:59 UTC
Package was generated with rust2rpm, simplifying the review.

- package builds and installs without errors on rawhide
- test suite is run and all unit tests pass
- latest version of the crate is packaged
- license matches upstream specification (MIT) and is acceptable for Fedora
- license file is included with %license in %files
- package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks:

- add @rust-sig with "commit" access as package co-maintainer

- set bugzilla assignee overrides to @rust-sig (optional)

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version filter: alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- track package in koschei for all built branches

Comment 5 Michel Lind 2022-04-14 23:12:20 UTC
Thanks!

❯ fedpkg request-repo rust-nu-engine 2038653
https://pagure.io/releng/fedora-scm-requests/issue/43716

❯ fedpkg request-branch --repo rust-nu-engine --all-releases
https://pagure.io/releng/fedora-scm-requests/issue/43717
https://pagure.io/releng/fedora-scm-requests/issue/43718
https://pagure.io/releng/fedora-scm-requests/issue/43719

Comment 6 Gwyn Ciesla 2022-04-15 04:33:01 UTC
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-nu-engine

Comment 7 Fedora Update System 2022-04-18 21:29:20 UTC
FEDORA-2022-4f48ae2d1a has been submitted as an update to Fedora 36. https://bodhi.fedoraproject.org/updates/FEDORA-2022-4f48ae2d1a

Comment 8 Fedora Update System 2022-04-18 21:30:35 UTC
FEDORA-2022-40a68fac9c has been submitted as an update to Fedora 35. https://bodhi.fedoraproject.org/updates/FEDORA-2022-40a68fac9c

Comment 9 Fedora Update System 2022-04-18 21:31:24 UTC
FEDORA-2022-43bd74ffd7 has been submitted as an update to Fedora 34. https://bodhi.fedoraproject.org/updates/FEDORA-2022-43bd74ffd7

Comment 10 Fedora Update System 2022-04-19 17:27:28 UTC
FEDORA-2022-4f48ae2d1a has been pushed to the Fedora 36 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2022-4f48ae2d1a \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-4f48ae2d1a

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 11 Fedora Update System 2022-04-20 20:24:56 UTC
FEDORA-2022-43bd74ffd7 has been pushed to the Fedora 34 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2022-43bd74ffd7 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-43bd74ffd7

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 12 Fedora Update System 2022-04-20 20:25:58 UTC
FEDORA-2022-40a68fac9c has been pushed to the Fedora 35 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2022-40a68fac9c \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-40a68fac9c

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 13 Fedora Update System 2022-04-28 05:50:43 UTC
FEDORA-2022-40a68fac9c has been pushed to the Fedora 35 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 14 Fedora Update System 2022-04-28 05:53:54 UTC
FEDORA-2022-43bd74ffd7 has been pushed to the Fedora 34 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 15 Fedora Update System 2022-05-07 04:26:59 UTC
FEDORA-2022-4f48ae2d1a has been pushed to the Fedora 36 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.