Bug 2038788 - Review Request: rust-nu-json - Fork of serde-hjson
Summary: Review Request: rust-nu-json - Fork of serde-hjson
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Fabio Valentini
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: 2038636 2038637
Blocks:
TreeView+ depends on / blocked
 
Reported: 2022-01-10 06:03 UTC by Michel Lind
Modified: 2022-05-07 04:20 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2022-04-17 22:21:18 UTC
Type: ---
Embargoed:
decathorpe: fedora-review+


Attachments (Terms of Use)

Description Michel Lind 2022-01-10 06:03:35 UTC
Spec URL: https://salimma.fedorapeople.org/specs/rust/rust-nu-json.spec
SRPM URL: https://salimma.fedorapeople.org/specs/rust/rust-nu-json-0.42.0-1.fc35.src.rpm
Description: Fork of serde-hjson.
Fedora Account System Username: salimma

Comment 1 Fabio Valentini 2022-01-10 14:25:57 UTC
(fixed bug title)

Comment 2 Fabio Valentini 2022-01-10 14:39:31 UTC
"problems with paths" is not a very descriptive comment as to why the tests are disabled.

Maybe use something like "logic for finding test assets in nu_test_support is broken"?
Or try to fix the asset finding logic in nu_test_support? :)

Other than that, the package looks good.

===

Package was generated with rust2rpm, simplifying the review.

- package builds and installs without errors on rawhide
- test suite is disabled (explanation *why* it is disabled could be better)
- latest version of the crate is packaged
- license matches upstream specification (MIT) and is acceptable for Fedora
- license file is included with %license in %files
- package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks:

- add package to rust-sig with "commit" access

- set bugzilla assignee overrides to @rust-sig (optional)

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version filter: alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- track package in koschei for all built branches

Comment 3 Michel Lind 2022-01-11 00:07:25 UTC
(In reply to Fabio Valentini from comment #2)
> "problems with paths" is not a very descriptive comment as to why the tests
> are disabled.

agreed, I'll make it more descriptive when importing, thanks.
> 
> Maybe use something like "logic for finding test assets in nu_test_support
> is broken"?
> Or try to fix the asset finding logic in nu_test_support? :)
> 
oh yeah, I'll definitely do that once all this is in :) Thanks!

❯ fedpkg request-repo rust-nu-json 2038788
https://pagure.io/releng/fedora-scm-requests/issue/40741

Comment 4 Gwyn Ciesla 2022-01-11 15:03:30 UTC
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-nu-json

Comment 5 Fedora Update System 2022-04-08 22:31:52 UTC
FEDORA-2022-a7b8406617 has been submitted as an update to Fedora 36. https://bodhi.fedoraproject.org/updates/FEDORA-2022-a7b8406617

Comment 6 Fedora Update System 2022-04-08 22:32:54 UTC
FEDORA-2022-00805ead9b has been submitted as an update to Fedora 34. https://bodhi.fedoraproject.org/updates/FEDORA-2022-00805ead9b

Comment 7 Fedora Update System 2022-04-08 22:33:42 UTC
FEDORA-2022-f12eda9c87 has been submitted as an update to Fedora 35. https://bodhi.fedoraproject.org/updates/FEDORA-2022-f12eda9c87

Comment 8 Fedora Update System 2022-04-09 17:11:07 UTC
FEDORA-2022-f12eda9c87 has been pushed to the Fedora 35 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2022-f12eda9c87 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-f12eda9c87

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 9 Fedora Update System 2022-04-09 17:16:21 UTC
FEDORA-2022-00805ead9b has been pushed to the Fedora 34 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2022-00805ead9b \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-00805ead9b

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 10 Fedora Update System 2022-04-10 16:32:57 UTC
FEDORA-2022-a7b8406617 has been pushed to the Fedora 36 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2022-a7b8406617 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-a7b8406617

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 11 Fedora Update System 2022-04-17 22:21:18 UTC
FEDORA-2022-00805ead9b has been pushed to the Fedora 34 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 12 Fedora Update System 2022-04-17 22:42:17 UTC
FEDORA-2022-f12eda9c87 has been pushed to the Fedora 35 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 13 Fedora Update System 2022-05-07 04:20:41 UTC
FEDORA-2022-a7b8406617 has been pushed to the Fedora 36 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.