Bug 2038636 - Review Request: rust-nu-path - Path handling library for Nushell
Summary: Review Request: rust-nu-path - Path handling library for Nushell
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Davide Cavalca
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 2038637 2038648 2038652 2038653 2038736 2038788
TreeView+ depends on / blocked
 
Reported: 2022-01-09 05:49 UTC by Michel Lind
Modified: 2022-05-07 04:20 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2022-04-17 22:21:12 UTC
Type: ---
Embargoed:
davide: fedora-review+


Attachments (Terms of Use)

Description Michel Lind 2022-01-09 05:49:26 UTC
Spec URL: https://salimma.fedorapeople.org/specs/rust/rust-nu-path.spec
SRPM URL: https://salimma.fedorapeople.org/specs/rust/rust-nu-path-0.42.0-1.fc35.src.rpm
Description: Path handling library for Nushell.
Fedora Account System Username: salimma

Comment 1 Fabio Valentini 2022-01-10 14:23:04 UTC
There's no LICENSE file in published crates. That is not acceptable wrt/ the MIT license, as it requires redistributed sources to contain the license text.

If there's a license file in the upstream repository, you can include it from there as a second Source file, until upstream fixes things and published crates contain the LICENSE file.

In any case, please report this issue with upstream (but I think you already did).

Comment 3 Davide Cavalca 2022-04-05 23:08:33 UTC
Taking this review

Comment 4 Davide Cavalca 2022-04-05 23:25:53 UTC
Package was generated with rust2rpm, simplifying the review.

- package builds and installs without errors on rawhide
- latest version of the crate is packaged
- license matches upstream specification and is acceptable for Fedora
- license file is included with %license in %files
- package complies with Rust Packaging Guidelines

Package APPROVED.

Comment 5 Michel Lind 2022-04-06 03:40:42 UTC
Thanks!

src/fedora/pkgs-sig-rust
❯ fedpkg request-repo rust-nu-path 2038636
https://pagure.io/releng/fedora-scm-requests/issue/43506

src/fedora/pkgs-sig-rust took 6s
❯ fedpkg request-branch --repo rust-nu-path --all-releases
https://pagure.io/releng/fedora-scm-requests/issue/43507
https://pagure.io/releng/fedora-scm-requests/issue/43508
https://pagure.io/releng/fedora-scm-requests/issue/43509

Comment 6 Gwyn Ciesla 2022-04-06 15:23:48 UTC
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-nu-path

Comment 7 Fedora Update System 2022-04-08 22:31:49 UTC
FEDORA-2022-a7b8406617 has been submitted as an update to Fedora 36. https://bodhi.fedoraproject.org/updates/FEDORA-2022-a7b8406617

Comment 8 Fedora Update System 2022-04-08 22:32:51 UTC
FEDORA-2022-00805ead9b has been submitted as an update to Fedora 34. https://bodhi.fedoraproject.org/updates/FEDORA-2022-00805ead9b

Comment 9 Fedora Update System 2022-04-08 22:33:38 UTC
FEDORA-2022-f12eda9c87 has been submitted as an update to Fedora 35. https://bodhi.fedoraproject.org/updates/FEDORA-2022-f12eda9c87

Comment 10 Fedora Update System 2022-04-09 17:11:04 UTC
FEDORA-2022-f12eda9c87 has been pushed to the Fedora 35 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2022-f12eda9c87 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-f12eda9c87

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 11 Fedora Update System 2022-04-09 17:16:20 UTC
FEDORA-2022-00805ead9b has been pushed to the Fedora 34 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2022-00805ead9b \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-00805ead9b

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 12 Fedora Update System 2022-04-10 16:32:55 UTC
FEDORA-2022-a7b8406617 has been pushed to the Fedora 36 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2022-a7b8406617 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-a7b8406617

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 13 Fedora Update System 2022-04-17 22:21:12 UTC
FEDORA-2022-00805ead9b has been pushed to the Fedora 34 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 14 Fedora Update System 2022-04-17 22:42:16 UTC
FEDORA-2022-f12eda9c87 has been pushed to the Fedora 35 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 15 Fedora Update System 2022-05-07 04:20:39 UTC
FEDORA-2022-a7b8406617 has been pushed to the Fedora 36 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.