Spec URL: http://people.redhat.com/johnp/files/orca/orca.spec SRPM URL: http://people.redhat.com/johnp/files/orca/orca-0.9.0-1.src.rpm Description: A flexible, scriptable, extensible screen reader for the GNOME platform that provides access via speech synthesis, braille, and magnification. This is a 200%+ better accessibility library than gnopernicus of which it replaces and has been adopted upstream by GNOME to replace gnopernicus.
just to clarify: orca is replacing both gnopernicus and gnome-mag, right ?
Yes it does. I need to add teh obsolete.
NEEDSWORK: - python_sitelib isn't used, don't define it. - Requires: python-abi = %(%{__python} -c "import sys ; print sys.version[:3]") is no longer needed. Automagically done. - Summary could lose "Orca is a", and the period at the end. - description should have 80char~ linefeeds - Missing BR: perl(XML::Parser) gnome-python2-bonobo gettext - Does orca provide a 'drop in replacement' for gnopernicus? Should it Provides: gnopernicus for upgrade paths? (ditto gnome-mag) - Group listed isn't a standard group from the RPM docs. - Some of the BuildRequires lines have tabs, some have spaces. Pick one (:
Spec URL: http://people.redhat.com/johnp/files/orca/orca.spec SRPM URL: http://people.redhat.com/johnp/files/orca/orca-0.9.0-2.src.rpm I changed the Groups tag but I belive there should be an accessability group as it is an important segment that we must support. Having the group makes our support that much more visible
Actually the Group tag is used by NOTHING. Anaconda doesn't use it, pirut doesn't use it, yum doesn't use it, etc... It's actually on the chopping block to go away. Comps.xml is where the things get sorted into groups and presented as such. Hrm, looks like I missed it in the first review. Summary is more than 79 chars, it needs to be shortened. Could probably drop everything from 'for people' on, and caps the first word. Thats silly stuff you can fix once you import. Approving. I'm assuming that at the same time I should be blocking gnopernicus and gnome-mag from the collection (and removing from comps if its there)?
Yes block away.
> Actually the Group tag is used by NOTHING. I think it is still used by apt-rpm and frontends (e.g. Synaptic).
They should be fixed to not use it. Its inconsistant, there is no real control mechanism, there is no support for conditional includes (only include this package if this other package has been selected), etc... Consider it deprecated.
This package has already been approved and imported into Fedora Core but this review report has not been closed yet. Closing it now.