Spec URL: http://piedmont.homelinux.org/fedora/telepathy/libtelepathy.spec SRPM URL: http://piedmont.homelinux.org/fedora/telepathy/libtelepathy-0.0.31-1.src.rpm Description: The Telepathy project aims to provide a unified framework for all forms of real time conversations, including instant messaging, IRC, voice calls and video calls. It uses the DBus messaging system to provide a simple interface for client applications, allowing them to quickly benefit from Telepathy's functionality. libtelepathy is a glib library to ease writing telepathy clients.
{Not Official Reviewer} packaging looks ok. + Mockbuild is successfull for i386 FC6 + rpmlint on binary rpm is silent + dist tag is present + Buildroot is correct + source URL is correct + BR is correct + License used is GPL + License file COPYING is included + devel package is handled correctly + MD5 sum on tarball is matching upstream tarball 31e24aed049c60aa18a47cbc19a1d69e libtelepathy-0.0.31.tar.gz + No duplicate files Not tested package.
Spec URL: http://piedmont.homelinux.org/fedora/telepathy/libtelepathy.spec SRPM URL: http://piedmont.homelinux.org/fedora/telepathy/libtelepathy-0.0.37-1.src.rpm * Tue Sep 12 2006 Brian Pepple <bpepple> - 0.0.37-1 - Update to 0.0.37.
{Not Official Reviewer} packaging looks ok. + Mockbuild is successfull for i386 FC6 + rpmlint on binary rpm is silent + dist tag is present + Buildroot is correct + source URL is correct + BR is correct + License used is GPL + License file COPYING is included + devel package is handled correctly + MD5 sum on tarball is matching upstream tarball 98cd5963b02396a7698b064cf5097dcd libtelepathy-0.0.37.tar.gz + No duplicate files Not tested package.
I will review this later.
Before checking 0.0.37-1 : I cannot rebuild this on FC5. DEBUG: Executing /usr/sbin/mock-helper chroot /var/lib/mock/fedora-5-i386-core/root /sbin/runuser - root -c "/sbin/runuser -c 'rpmbuild -bs --target i386 --nodeps /builddir/build/SPECS/libtelepathy.spec' mockbuild" warning: Could not canonicalize hostname: halo.mtk.ioa.s.u-tokyo.ac.jp Building target platforms: i386 Building for target i386 Wrote: /builddir/build/SRPMS/libtelepathy-0.0.37-1.fc5.src.rpm DEBUG: ensuring dir /var/lib/mock/fedora-5-i386-core/root/proc DEBUG: mounting proc in /var/lib/mock/fedora-5-i386-core/root/proc DEBUG: Executing /usr/sbin/mock-helper mount -t proc proc /var/lib/mock/fedora-5-i386-core/root/proc mount: proc already mounted or /var/lib/mock/fedora-5-i386-core/root/proc busy mount: according to mtab, proc is mounted on /proc DEBUG: ensuring dir /var/lib/mock/fedora-5-i386-core/root/dev/pts DEBUG: mounting devpts in /var/lib/mock/fedora-5-i386-core/root/dev/pts DEBUG: Executing /usr/sbin/mock-helper mount -t devpts devpts /var/lib/mock/fedora-5-i386-core/root/dev/pts mount: devpts already mounted or /var/lib/mock/fedora-5-i386-core/root/dev/pts busy mount: according to mtab, devpts is mounted on /dev/pts DEBUG: yum: command /usr/sbin/mock-helper yum --installroot /var/lib/mock/fedora-5-i386-core/root resolvedep 'dbus-devel' 'dbus-glib-devel' DEBUG: Executing /usr/sbin/mock-helper yum --installroot /var/lib/mock/fedora-5-i386-core/root resolvedep 'dbus-devel' 'dbus-glib-devel' No Package Found for dbus-glib-devel 0:dbus-devel-0.61-3.fc5.1.i386 Cannot find build req dbus-glib-devel. Exiting. ending DEBUG: Executing /usr/sbin/mock-helper umount /var/lib/mock/fedora-5-i386-core/root/proc DEBUG: Executing /usr/sbin/mock-helper umount /var/lib/mock/fedora-5-i386-core/root/dev/pts done See the argument on bug 206576 (this bug is marked as DEFERRED)
Build this under FC6. The spec isn't set-up for FC5, which will require dbus-glib-devel to be changed to dbus-glib.
(In reply to comment #6) > Build this under FC6. The spec isn't set-up for FC5, which will require > dbus-glib-devel to be changed to dbus-glib. I mean that this spec file requires a "switch" to be built under both FC6-devel and FC5.
I'm not really planning on targetting FC5 at the moment, and if so will modify the FC5 branch, and not use a switch.
1. From http://fedoraproject.org/wiki/Packaging/Guidelines : * Use rpmlint - rpmlint is not silent. W: libtelepathy mixed-use-of-spaces-and-tabs Well, unify space/tab. For this case, don't use tabs in spec file. sed -i -e 's|\t| |g' foo.spec is the most simple way to remove tabs. W: libtelepathy-devel no-documentation (I think this can be ignored.) 2. From http://fedoraproject.org/wiki/Packaging/ReviewGuidelines = Nothing. 3. Other things I have noticed: = Nothing. Fix space/tab issue on spec file. However, I cannot find any problem aside this. ----------------------------------------------------------------------- This package (libtelepathy) is APPROVED by me.