Bug 2046211 - [OSP13->OSP16.2] Leapp actors directory change impacting in the upgrade
Summary: [OSP13->OSP16.2] Leapp actors directory change impacting in the upgrade
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat OpenStack
Classification: Red Hat
Component: openstack-tripleo-heat-templates
Version: 16.2 (Train)
Hardware: Unspecified
OS: Unspecified
medium
medium
Target Milestone: z2
: 16.2 (Train on RHEL 8.4)
Assignee: Sergii Golovatiuk
QA Contact: Jason Grosso
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2022-01-26 12:17 UTC by Jose Luis Franco
Modified: 2022-03-23 22:30 UTC (History)
8 users (show)

Fixed In Version: openstack-tripleo-heat-templates-11.6.1-2.20220116004910.el8ost
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2022-03-23 22:30:16 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
OpenStack gerrit 826393 0 None MERGED Change the path according to leapp-0.13 2022-02-07 14:27:52 UTC
OpenStack gerrit 827056 0 None MERGED [train-only] Increase scope for actor removal. 2022-02-07 14:27:49 UTC
OpenStack gerrit 828699 0 None MERGED [train-only][ci] Increase scope for actor removal 2022-02-11 12:22:08 UTC
Red Hat Issue Tracker OSP-12300 0 None None None 2022-01-26 12:18:08 UTC
Red Hat Issue Tracker UPG-4942 0 None None None 2022-01-26 14:54:00 UTC
Red Hat Product Errata RHSA-2022:0995 0 None None None 2022-03-23 22:30:41 UTC

Description Jose Luis Franco 2022-01-26 12:17:10 UTC
Description of problem:

The mechanism used by Leapp to identify issues during the RHEL upgrade relies on some python clases named as actors. These actors block the upgrade in case of wrong configuration, or wrong interface names ,etc ... However, RHOSP required to workaround some of these actors to allow customers continue with their upgrade in specific situations, as well as to make faster our CI testing.

For that reason, a block of code was included in tht that would allow us, if required, to remove some of these actors at the time of upgrading Overcloud nodes:
https://github.com/openstack/tripleo-heat-templates/blob/stable/train/deployment/tripleo-packages/tripleo-packages-baremetal-puppet.yaml#L408

            - name: Remove leapp actors to prevent them inhibiting the upgrade
              vars:
                actors_to_remove: { get_attr: [RoleParametersValue, value, 'upgrade_leapp_actors_to_remove']}
              file:
                path: /usr/share/leapp-repository/repositories/system_upgrade/el7toel8/actors/{{ item }}/actor.py
                state: absent
              loop: "{{ actors_to_remove }}"

This code was introduced in:
16.2: https://bugzilla.redhat.com/show_bug.cgi?id=1984875
16.1: https://bugzilla.redhat.com/show_bug.cgi?id=1984873

In version leapp-0.13.0-100 the location of these actors was changed from:

/usr/share/leapp-repository/repositories/system_upgrade/el7toel8/actors/
into
/usr/share/leapp-repository/repositories/system_upgrade/common/actors/

making the block of code referenced above irrelevant, as no file will be removed from that directory and at the same time, making fail the other mechanism put in place to allow the upgrade with unsupported drivers:

https://github.com/openstack/tripleo-heat-templates/blob/stable/train/deployment/tripleo-packages/tripleo-packages-baremetal-puppet.yaml#L404-L411

We need to change the references to the directories or come up with a more robust solution which will work even if there are directory changes in the future.

This BZ impacts to all our CI jobs, making them fail:

http://rhos-ci-logs.lab.eng.tlv2.redhat.com/logs/rcj/DFG-upgrades-ffu-16.1-from-13-latest_cdn-3cont_3hci-ipv4-ovs_dvr/249/undercloud-0/home/stack/overcloud_system_upgrade-controller-0.log.gz


Version-Release number of selected component (if applicable):


How reproducible:

Run any FFU CI job from OSP13 to OSP16.2

Comment 13 errata-xmlrpc 2022-03-23 22:30:16 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Moderate: Red Hat OpenStack Platform 16.2 (openstack-tripleo-heat-templates) security update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2022:0995


Note You need to log in before you can comment on or make changes to this bug.