Bug 205304 (perl-Sub-Identify) - Review Request: perl-Sub-Identify - Retrieve names of code references
Summary: Review Request: perl-Sub-Identify - Retrieve names of code references
Keywords:
Status: CLOSED NEXTRELEASE
Alias: perl-Sub-Identify
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Patrice Dumas
QA Contact: Fedora Package Reviews List
URL: http://search.cpan.org/dist/Sub-Ident...
Whiteboard:
Depends On:
Blocks: FE-ACCEPT perl-SUPER
TreeView+ depends on / blocked
 
Reported: 2006-09-05 22:07 UTC by Chris Weyl
Modified: 2007-11-30 22:11 UTC (History)
0 users

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2006-09-06 14:51:38 UTC
Type: ---
Embargoed:
jwboyer: fedora-cvs+


Attachments (Terms of Use)

Description Chris Weyl 2006-09-05 22:07:44 UTC
SRPM URL: http://home.comcast.net/~ckweyl/perl-Sub-Identify-0.02-1.fc5.src.rpm
SPEC URL: http://home.comcast.net/~ckweyl/perl-Sub-Identify.spec

Description:
Sub::Identify allows you to retrieve the real name of code references. For
this, it uses perl's introspection mechanism, provided by the B module.

Comment 1 Patrice Dumas 2006-09-06 09:59:07 UTC
* rpmlint is silent
* package named according to guidelines
* free software, without licence files included
* meets packaging guidelines
* spec legible
* source match upstream
5efae626e447e064f804e712e5fb03f2  Sub-Identify-0.02.tar.gz
* sane provides
Provides: perl(Sub::Identify) = 0.02
* %files right

APPROVED

You could add BuildRequires perl(B) (and maybe Tests::More) but since 
it is in perl core, it is not really important.

Comment 2 Chris Weyl 2006-09-06 14:51:38 UTC
+Import to CVS
+Add to owners.list
+Bump release, build for devel
+devel build succeeds
+Request branching (FC-5)
+Close bug

Thanks for the review! :)

Comment 3 Chris Weyl 2007-04-19 20:43:26 UTC
Please branch for EL-4, EL-5.


Note You need to log in before you can comment on or make changes to this bug.