SRPM URL: http://home.comcast.net/~ckweyl/perl-SUPER-1.14-1.fc5.src.rpm SPEC URL: http://home.comcast.net/~ckweyl/perl-SUPER.spec Description: When subclassing a class, you occasionally want to dispatch control to the superclass -- at least conditionally and temporarily. The Perl syntax for calling your superclass is ugly and unwieldy:
The description ends with a :, this is certainly wrong... perl(DB) should certainly filtered out. It may be relevant to Requires: perl(DB) perl(UNIVERSAL) even if they are in perl core, maybe with a explanatory comment. Otherwise * rpmlint ignorable: W: perl-SUPER strange-permission filter-provides.sh 0755 * package named according to guidelines * free software, without licence files included * meets packaging guidelines * spec legible * source match upstream 591389c353df308ee9e70d38f0e3570b SUPER-1.14.tar.gz X insane provides Provides: perl(DB) perl(SUPER) = 1.14 * %files right
Updated: SRPM URL: http://home.comcast.net/~ckweyl/perl-SUPER-1.14-2.fc5.src.rpm SPEC URL: http://home.comcast.net/~ckweyl/perl-SUPER.spec I'm not explicitly requiring perl(DB) perl(UNIVERSAL) right now as a) they don't look to be required, and b) in any case they're in core, so I can quash this question on the ground it's moot anyways ;)
The provides are right now, but the description is still weird...
That's what I get for being too literal and not reading the text I'm fixing. I'll update to: "When subclassing a class, you occasionally want to dispatch control to the superclass -- at least conditionally and temporarily. This module provides an easier, cleaner way for class methods to access their ancestor's implementation."
Updated: SRPM URL: http://home.comcast.net/~ckweyl/perl-SUPER-1.14-3.fc5.src.rpm SPEC URL: http://home.comcast.net/~ckweyl/perl-SUPER.spec
APPROVED
+Import to CVS +Add to owners.list +Bump release, build for devel +Request branching +Close bug Thanks for the review! :)
Please branch for EL-4, EL-5.