Bug 2054456 - Review Request: rust-infer - Small crate to infer file types
Summary: Review Request: rust-infer - Small crate to infer file types
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Zbigniew Jędrzejewski-Szmek
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: 2054439
Blocks: 2049188
TreeView+ depends on / blocked
 
Reported: 2022-02-15 00:47 UTC by Rémi Lauzier
Modified: 2022-02-23 22:54 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2022-02-23 22:54:04 UTC
Type: ---
Embargoed:
zbyszek: fedora-review+


Attachments (Terms of Use)

Description Rémi Lauzier 2022-02-15 00:47:07 UTC
Spec URL: https://download.copr.fedorainfracloud.org/results/remilauzier/infer/fedora-rawhide-x86_64/03495497-rust-infer/rust-infer.spec
SRPM URL: https://download.copr.fedorainfracloud.org/results/remilauzier/infer/fedora-rawhide-x86_64/03495497-rust-infer/rust-infer-0.6.0-1.fc37.src.rpm
Description: Small crate to infer file types based on its magic number signature
Fedora Account System Username: remilauzier

Comment 2 Zbigniew Jędrzejewski-Szmek 2022-02-15 09:20:18 UTC
> Small crate to infer file types based on its magic number signature

Grammar is wrong here. "Small crate to infer file type based on magic number signatures" ?

It'd be nice to mention how this relates for file and its magic database.

Please update to the latest version (0.7.0).

Comment 3 Rémi Lauzier 2022-02-15 17:37:49 UTC
The update is up there on comment 1.
For the grammar i am not the one controlling the software and my English is too bad for that.
can always make a pr for that if that is a necessity.

Comment 4 Zbigniew Jędrzejewski-Szmek 2022-02-15 18:27:12 UTC
(In reply to Rémi Lauzier from comment #3)
> The update is up there on comment 1.
Oh, indeed.

> For the grammar i am not the one controlling the software and my English is
> too bad for that.

Yes, but the description on the Fedora package is under your control.
Fixing and covering mistakes by upstream is a significant part of maintainership.
Why not just use the suggestion I provided above?

> can always make a pr for that if that is a necessity.

Sorry, but I don't think I should have to make a pull request myself. I'm just
the reviewer here, and you can easily adjust the description text in the spec
file.

Comment 6 Zbigniew Jędrzejewski-Szmek 2022-02-15 19:23:46 UTC
Thanks!

Hmm, the builds fails:
Provides: crate(infer) = 0.7.0 rust-infer-devel = 0.7.0-1.fc36
Requires(rpmlib): rpmlib(CompressedFileNames) <= 3.0.4-1 rpmlib(FileDigests) <= 4.6.0-1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
Requires: /usr/bin/bash cargo
error: Arch dependent binaries in noarch package
    Arch dependent binaries in noarch package

This seems like a false positive. Maybe it is caused by
/usr/share/cargo/registry/infer-0.7.0/testdata/sample_*?
This needs some workaround.

Comment 7 Zbigniew Jędrzejewski-Szmek 2022-02-15 19:30:01 UTC
Please consider adding a comment with the link to the PR so it is not forgotten.

Add "%global _binaries_in_noarch_packages_terminate_build 0" to avoid the issue
with rpm refusing the sample files.

+ package name is OK
+ latest version
+ latest rust2rpm was used
+ license is acceptable for Fedora (MIT)
+ license is specified correctly
+ builds and installs OK
+ fedora-review and rpmlint find nothing interesting

Package is APPROVED.

Comment 8 Gwyn Ciesla 2022-02-15 20:16:04 UTC
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-infer

Comment 9 Fedora Update System 2022-02-23 22:51:35 UTC
FEDORA-2022-7b17a1a992 has been submitted as an update to Fedora 37. https://bodhi.fedoraproject.org/updates/FEDORA-2022-7b17a1a992

Comment 10 Fedora Update System 2022-02-23 22:54:04 UTC
FEDORA-2022-7b17a1a992 has been pushed to the Fedora 37 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.