Spec URL: https://petersen.fedorapeople.org/reviews/koji-tool/koji-tool.spec SRPM URL: https://petersen.fedorapeople.org/reviews/koji-tool/koji-tool-0.8.1-1.fc35.src.rpm Description: Koji-tool is a CLI interface to Koji with commands to query builds, tasks, install rpms, and track buildlog sizes. Koji is the RPM-based buildsystem of Fedora Linux and CentOS.
Copr builds are available at https://copr.fedorainfracloud.org/coprs/petersen/koji-tool/ Spec: https://download.copr.fedorainfracloud.org/results/petersen/koji-tool/fedora-rawhide-x86_64/03811062-koji-tool/koji-tool.spec Srpm: https://download.copr.fedorainfracloud.org/results/petersen/koji-tool/fedora-rawhide-x86_64/03811062-koji-tool/koji-tool-0.8.1-1.fc37.src.rpm
Thank you for moving this to Fedora! The format-numbers-0.1.0.1/format-numbers.cabal seems to be MIT, so the the overall license should be BSD and MIT? Btw., how about the library bundling nowadays in Fedora? There's this check, in the fedora-review template: [ ]: Package contains no bundled libraries without FPC exception.
(In reply to Pavel Raiskup from comment #2) > Btw., how about the library bundling nowadays in Fedora? There's this check, > in the fedora-review template: > [ ]: Package contains no bundled libraries without FPC exception. Okay you are right: I think here my recollection of the Packaging Guidelines was too liberal. (https://docs.fedoraproject.org/en-US/packaging-guidelines/#bundling) So I will submit the dependency as a separate package. (In this case I will probably switch to a more popular general formatting library (like fmt or formatting). My only weak defense was that I have a number of other packaging reviews languishing for many months, so I wondered if going with bundling could work;) I will try to do a quick 0.8.2 release soon, and link the dependency review to this. Thank you for the initial review!
'formatting' looks pretty good, though it does have one missing dependency on double-conversion alas, which I have opened first in: https://bugzilla.redhat.com/show_bug.cgi?id=2066841
Spec URL: https://petersen.fedorapeople.org/reviews/koji-tool/koji-tool.spec SRPM URL: https://petersen.fedorapeople.org/reviews/koji-tool/koji-tool-0.8.2-1.fc35.src.rpm updated to 0.8.2 release Koji scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=84880630
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "BSD 3-Clause License", "*No copyright* BSD 3-Clause License". 9 files have unknown license. Detailed output of licensecheck in /tmp/2066552-koji-tool/licensecheck.txt [x]: %build honors applicable compiler flags or justifies otherwise. praiskup: %ghc_ macros used [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [-]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 20480 bytes in 3 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [ ]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [?]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Cannot parse rpmlint output: Rpmlint (installed packages) ---------------------------- Cannot parse rpmlint output: Source checksums ---------------- https://hackage.haskell.org/package/koji-tool-0.8.2/koji-tool-0.8.2.tar.gz : CHECKSUM(SHA256) this package : 0fff9c85d449a2861fa1e17de43264bf6a45dda58636bbaa6791aa0436e21742 CHECKSUM(SHA256) upstream package : 0fff9c85d449a2861fa1e17de43264bf6a45dda58636bbaa6791aa0436e21742 Requires -------- koji-tool (rpmlib, GLIBC filtered): libc.so.6()(64bit) libcrypto.so.3()(64bit) libcrypto.so.3(OPENSSL_3.0.0)(64bit) libdouble-conversion.so.3()(64bit) libffi.so.8()(64bit) libffi.so.8(LIBFFI_BASE_8.0)(64bit) libffi.so.8(LIBFFI_CLOSURE_8.0)(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgmp.so.10()(64bit) libm.so.6()(64bit) libssl.so.3()(64bit) libssl.so.3(OPENSSL_3.0.0)(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libz.so.1()(64bit) rtld(GNU_HASH) Provides -------- koji-tool: koji-tool koji-tool(x86-64) Generated by fedora-review 0.7.6 (b083f91) last change: 2020-11-10 Command line :/usr/bin/fedora-review -b 2066552 Buildroot used: fedora-rawhide-x86_64 Active plugins: Shell-api, Generic, Haskell Disabled plugins: Perl, SugarActivity, fonts, Ocaml, C/C++, R, PHP, Java, Python Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH
Thank you for the review, Pavel! https://pagure.io/releng/fedora-scm-requests/issue/43426
(fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/koji-tool
https://pagure.io/releng/fedora-scm-requests/issue/43546
was also built for F35+ (I forget why not attached to the bodhi updates)