SPEC: https://pbrobinson.fedorapeople.org/rust-ciborium-io.spec SRPM: https://pbrobinson.fedorapeople.org/rust-ciborium-io-0.2.0-1.fc36.src.rpm Description: Simplified Read/Write traits for no_std usage koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=84851013 FAS: pbrobinson
This crate does not contain license files. Both the MIT and Apache-2.0 licenses require redistributed sources to contain a copy of the license text. It looks like dcavalca fixed this issue upstream, but there's no release that has this change yet: https://github.com/enarx/ciborium/commit/b77f979c35a00f1fc65fb09bcf452e6ce0a90bcf In the meantime, please include the LICENSE* files from the upstream project as separate sources in this package.
*edit: This crate is Apache-2.0-only, sorry about the confusion. Including the *one* LICENSE file is enough. :)
They fixed the license issue upstream: https://github.com/enarx/ciborium/commit/b77f979c35a00f1fc65fb09bcf452e6ce0a90bcf
I'll add the license as a source in the mean time
Updated/fixed (not sure how review bumps work with autospec but they're updated on the original links)
> not sure how review bumps work with autospec but they're updated on the original links That's fine with me. > Source2: https://github.com/enarx/ciborium/blob/main/ciborium/LICENSE This is a link to an HTML page on GitHub you probably meant to use the URL to the raw file: Source2: https://github.com/enarx/ciborium/raw/b77f979/ciborium/LICENSE Please fix this before importing the package (and you could use Source1 instead of Source2, since there is no Source1). You can also drop this (now inaccurate) comment from the .spec file's %files section: # FIXME: no license files detected And please use "%license %{crate_instdir}/LICENSE" instead of "%license LICENSE". This will result in the file being included only once in the built RPM files instead of twice. That string also matches what will be generated once the published crate will contain the LICENSE file. But these are all minor issues that you can fix when importing the package, otherwise LGTM. === Package was generated with rust2rpm, simplifying the review. - package builds and installs without errors on rawhide - test suite is run and all unit tests pass - latest version of the crate is packaged - license matches upstream specification (MIT) and is acceptable for Fedora - license file is included with %license in %files - package complies with Rust Packaging Guidelines Package APPROVED. === Recommended post-import rust-sig tasks: - add @rust-sig with "commit" access as package co-maintainer - set bugzilla assignee overrides to @rust-sig (optional) - set up package on release-monitoring.org: project: $crate homepage: https://crates.io/crates/$crate backend: crates.io version scheme: semantic version filter: alpha;beta;rc;pre distro: Fedora Package: rust-$crate - track package in koschei for all built branches
SCM repo created (cleaned up after backtrace manually)
Small bits fixed, imported
You still imported the GitHub HTML page for the LICENSE instead of the raw plain text. Please fix this.
Fixed, not exactly sure what went wrong there, it wasn't intentional: https://src.fedoraproject.org/rpms/rust-ciborium-io/c/6ba148a18bb52f99cf7657fe58fe6786f06c2449?branch=rawhide