Bug 2069415 (rust-ciborium-ll) - Review Request: rust-ciborium-ll - Low-level CBOR codec primitives
Summary: Review Request: rust-ciborium-ll - Low-level CBOR codec primitives
Keywords:
Status: CLOSED RAWHIDE
Alias: rust-ciborium-ll
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Fabio Valentini
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: rust-ciborium-io
Blocks: rust-ciborium
TreeView+ depends on / blocked
 
Reported: 2022-03-28 20:57 UTC by Peter Robinson
Modified: 2022-05-13 06:29 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2022-05-13 06:29:31 UTC
Type: Bug
Embargoed:
decathorpe: fedora-review+


Attachments (Terms of Use)

Description Peter Robinson 2022-03-28 20:57:53 UTC
SPEC: https://pbrobinson.fedorapeople.org/rust-ciborium-ll.spec
SRPM: https://pbrobinson.fedorapeople.org/rust-ciborium-ll-0.2.0-1.fc36.src.rpm

Description:
Low-level CBOR codec primitives

FAS: pbrobinson

Comment 1 Fabio Valentini 2022-05-08 14:53:53 UTC
You replaced the link to the LICENSE file with the correct one, but the SRPM still contains the GitHub HTML page, same as what happened with the ciborium-io package. Please fix this.

Comment 2 Peter Robinson 2022-05-09 13:41:25 UTC
(In reply to Fabio Valentini from comment #1)
> You replaced the link to the LICENSE file with the correct one, but the SRPM
> still contains the GitHub HTML page, same as what happened with the
> ciborium-io package. Please fix this.

Fixed

Comment 3 Fabio Valentini 2022-05-12 15:35:10 UTC
Package was generated with rust2rpm, simplifying the review.

- package builds and installs without errors on rawhide
- test suite is run and all unit tests pass
- latest version of the crate is packaged
- license matches upstream specification (ASL 2.0) and is acceptable for Fedora
- license file is included with %license in %files
- package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks:

- add @rust-sig with "commit" access as package co-maintainer

- set bugzilla assignee overrides to @rust-sig (optional)

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version filter: alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- track package in koschei for all built branches

Comment 4 Gwyn Ciesla 2022-05-12 18:00:39 UTC
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-ciborium-ll


Note You need to log in before you can comment on or make changes to this bug.