Bug 2080547 - Metrics kubevirt_hco_out_of_band_modifications_count, does not reflect correct modification count when label is added to priorityclass/kubevirt-cluster-critical in a loop
Summary: Metrics kubevirt_hco_out_of_band_modifications_count, does not reflect correc...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Container Native Virtualization (CNV)
Classification: Red Hat
Component: Metrics
Version: 4.11.0
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
: 4.11.0
Assignee: Nahshon Unna-Tsameret
QA Contact: Satyajit Bulage
URL:
Whiteboard:
Depends On:
Blocks: 2091972
TreeView+ depends on / blocked
 
Reported: 2022-04-30 02:29 UTC by Debarati Basu-Nag
Modified: 2023-11-13 08:18 UTC (History)
4 users (show)

Fixed In Version: v4.11.0-462
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
: 2091972 (view as bug list)
Environment:
Last Closed: 2022-09-14 19:31:19 UTC
Target Upstream Version:
Embargoed:

Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Github kubevirt hyperconverged-cluster-operator pull 1995 0 None Merged Fix BZ-2080547: mis-read the priority class after update 2022-06-15 10:03:06 UTC
Github kubevirt hyperconverged-cluster-operator pull 2002 0 None Merged [release-1.7] Fix BZ-2080547: mis-read the priority class after update 2022-06-15 10:03:06 UTC
Red Hat Issue Tracker CNV-17900 0 None None None 2023-11-13 08:18:55 UTC
Red Hat Product Errata RHSA-2022:6526 0 None None None 2022-09-14 19:31:34 UTC

Comment 1 Nahshon Unna-Tsameret 2022-06-01 10:29:04 UTC 
There is no way to update the PriorityClass (it's emutable). So in case of update, HCO delete and recreate it. 

I guess since it's modified in loops, there is some timing issue that causes HCO to fail to read the priority class in the next loop, and then it fails and miss the metric update. I'm not sure it worth to fix this issue. 

@stirabos - what do you think?
Comment 2 Simone Tiraboschi 2022-06-15 10:04:09 UTC 
The proposed fix looks safe and robust.
Comment 4 Satyajit Bulage 2022-06-24 09:56:18 UTC 
I have added label to priority class --> kubevirt-cluster-critical, waited to 15+mins to reconcile. But it didn't happened.
Also, count didn't get increased.
Comment 5 Satyajit Bulage 2022-06-24 14:03:33 UTC 
Tried on another cluster and worked as expected.
Component: priorityclass/kubevirt-cluster-critical is reconciling and count is updating properly.
Verifying BZ.
Comment 8 errata-xmlrpc 2022-09-14 19:31:19 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Important: OpenShift Virtualization 4.11.0 Images security and bug fix update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2022:6526
Note You need to log in before you can comment on or make changes to this bug.