(project formerly known as "bonfire") Spec URL: http://www.poolshark.org/src/brasero.spec SRPM URL: http://www.poolshark.org/src/brasero-0.4.4-1.src.rpm Description: Simple and easy to use CD/DVD burning application for the Gnome desktop.
Here's a quick items: 1. Why are you redefining %version? 2. Duplicate BuildRequires: glib2-devel (by gtk2-devel), libxml2-devel (by libgnome-devel), gnome-vfs2-devel (by libgnome-devel), gtk2-devel (by libgnomeui-devel), libgnome-devel (by libgnomeui-devel)
1. *bonk*. fixed 2. fixed. Spec URL: http://www.poolshark.org/src/brasero.spec SRPM URL: http://www.poolshark.org/src/brasero-0.4.4-2.src.rpm
Humm. I can't make much from the URL and Source0 links here. Do they need to be updated? The URL points to a graphic design web site with lots of flash and javascript, but no mention of open source software I can see. The Source0 url on sourceforge doesn't seem to point to any files... ;(
Homepage changes yes thx. Fixed. http://www.poolshark.org/src/brasero.spec http://www.poolshark.org/src/brasero-0.4.4-3.src.rpm
ok. That looks much better. ;) Look for a full review later today...
OK - Package name OK - Spec file matches base package name. OK - Meets Packaging Guidelines. OK - License (GPL) OK - License field in spec matches OK - License file included in package OK - Spec in American English OK - Spec is legible. OK - Sources match upstream md5sum: 1ef6ae66677ed9136634692d8bc1cc7a brasero-0.4.4.tar.bz2 1ef6ae66677ed9136634692d8bc1cc7a brasero-0.4.4.tar.bz2.1 OK - Package compiles and builds on at least one arch. OK - BuildRequires correct OK - Spec handles locales/find_lang OK - Package owns all the directories it creates. OK - Package has no duplicate files in %files. OK - Package has %defattr and permissions on files is good. OK - Package has a correct %clean section. OK - Spec has consistant macro usage. OK - Package is code or permissible content. OK - Packages %doc files don't affect runtime. OK - Package is a GUI app and has a .desktop file OK - Package doesn't own any directories other packages own. OK - No rpmlint output. SHOULD Items: OK - Should include License or ask upstream to include it. OK - Should build in mock. Issues: 1. 0.4.91 seems to be out but it looks like thats a unstable testing version (hard to be sure). No other blockers I can see... this package is APPROVED. Please remember to close this package NEXTRELEASE once it's been imported and built. Consider reviewing another waiting package to help spread the reviewing load. :)
I'll test the unstable release and consider them for upgrades. I'm actually working on this upstream project at the moment. Built. Thanks for the review!