Spec URL: https://github.com/BuddiesOfBudgie/fedora-pkg/raw/main/budgie-control-center/budgie-control-center.spec SRPM URL: https://github.com/BuddiesOfBudgie/fedora-pkg/raw/main/budgie-control-center/budgie-control-center-1.0.2-1.fc37.src.rpm Description: A fork of GNOME Control Center for the Budgie 10 Series Fedora Account System Username: joshstrobl
Taking this review.
Initial spec review: > mkdir -p $RPM_BUILD_ROOT%{_datadir}/budgie/wm-properties > rm -rf $RPM_BUILD_ROOT%{_datadir}/budgie/autostart > rm -rf $RPM_BUILD_ROOT%{_datadir}/budgie/cursor-fonts > chrpath --delete $RPM_BUILD_ROOT%{_bindir}/budgie-control-center Please use "%{buildroot}" instead of "$RPM_BUILD_ROOT". The former is an RPM macro and the latter is a shell variable and macros are preferred here. > %{_datadir}/applications/*.desktop Please add a %check section and validate all desktop files with desktop-file-validate. See: https://docs.fedoraproject.org/en-US/packaging-guidelines/#_desktop_file_install_usage > %{_datadir}/metainfo/budgie-control-center.appdata.xml Same guidance as for desktop files. See: https://docs.fedoraproject.org/en-US/packaging-guidelines/AppData/#_app_data_validate_usage
Issues raised should now be addressed. Using buildroot and check section with app data and desktop file validation. The srpm was rebuild when performing all the validation & building. Thanks for the quick review!
This needs fixing: > URL: https://github.com/BuddiesOfBudgie/budgie-control-center > Source0: https://github.com/BuddiesOfBudgie/budgie-control-center/releases/download/v1.0.2/budgie-control-center-1.0.2.tar.xz It should look like this: > URL: https://github.com/BuddiesOfBudgie/budgie-control-center > Source0: %{url}/releases/download/v%{version}/%{name}-%{version}.tar.xz This makes it easier for future version updates.
Dropping FE-NEEDSPONSOR because Josh is sponsored already.
(In reply to Neal Gompa from comment #4) > This needs fixing: > > > URL: https://github.com/BuddiesOfBudgie/budgie-control-center > > Source0: https://github.com/BuddiesOfBudgie/budgie-control-center/releases/download/v1.0.2/budgie-control-center-1.0.2.tar.xz > > It should look like this: > > > URL: https://github.com/BuddiesOfBudgie/budgie-control-center > > Source0: %{url}/releases/download/v%{version}/%{name}-%{version}.tar.xz > > This makes it easier for future version updates. Done!
> Source0: %{url}/releases/download/%{version}/%{name}-%{version}.tar.xz Part of the URL is wrong, it should be "/v%{version}/" instead of "/%{version}/".
That is not correct. fossfreedom tags that one without the "v" prefix.
Ah nvm. Yea not sure why he used v for the tag but not tarball. Fixing. Just check back in like 2min and it will be fixed :P
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Header files in -devel subpackage, if present. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "GNU General Public License, Version 2", "*No copyright* GNU General Public License, Version 2", "GNU General Public License v2.0 or later", "GNU General Public License v3.0 or later", "GNU General Public License, Version 3 GNU General Public License v2.0 or later", "*No copyright* Public domain", "GNU General Public License v2.0 or later [obsolete FSF postal address (Temple Place)]", "GNU Library General Public License v2 or later", "GNU General Public License v2.0 or later [obsolete FSF postal address (Mass Ave)]", "GNU Lesser General Public License v2.1 or later", "GNU General Public License", "GNU Lesser General Public License, Version 2.1", "*No copyright* GNU Lesser General Public License, Version 2.1", "MIT License", "*No copyright* [generated file]", "GNU Lesser General Public License, Version 2.1 GNU Library General Public License v2 or later", "*No copyright* GNU Library General Public License, Version 2.0". 911 files have unknown license. Detailed output of licensecheck in /home/ngompa/2086265-budgie-control-center/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [!]: Package requires other packages for directories it uses. Note: No known owner of /usr/share/budgie-control-center/keybindings, /usr/share/budgie-control-center, /usr/share/sounds/budgie/default, /usr/share/locale/mjw/LC_MESSAGES, /usr/share/locale/mjw, /usr/share/sounds/budgie, /usr/share/budgie, /usr/share/sounds/budgie/default/alerts [!]: Package must own all directories that it creates. Note: Directories without known owners: /usr/share/sounds/budgie, /usr/share/locale/mjw/LC_MESSAGES, /usr/share/budgie-control-center, /usr/share/sounds/budgie/default, /usr/share/locale/mjw, /usr/share/dbus-1/services, /usr/share/sounds/budgie/default/alerts, /usr/share/budgie-control-center/keybindings, /usr/share/budgie, /usr/share/dbus-1 [!]: Package does not own files or directories owned by other packages. Note: Dirs in package are owned also by: /usr/share/icons/hicolor(freedroidrpg, kgraphviewer, hicolor-icon- theme, klatexformula, lammps-data, tuxanci, mono-tools, vim-X11, vacuum-im, android-file-transfer, wesnoth-data, qmmp, wdisplays, redeclipse, autokey-common, nedit, xchm, fedora-logos, pdfmod, qtl866, massif-visualizer, swappy, qemu-common), /usr/share/icons/hicolor/scalable(lxqt-powermanagement, pdfmod, qmmp, freedroidrpg, qtl866, dxf2gcode, massif-visualizer, hicolor-icon- theme, wdisplays, klatexformula, tuxanci, autokey-common, keepassx, eom, swappy, korganizer, fedora-logos, qemu-common), /usr/share/icons/hicolor/scalable/apps(pdfmod, qmmp, freedroidrpg, qtl866, dxf2gcode, massif-visualizer, hicolor-icon-theme, wdisplays, klatexformula, tuxanci, autokey-common, keepassx, eom, swappy, korganizer, qucs, fedora-logos, qemu-common), /usr/share/icons/hicolor/scalable/categories(hicolor-icon-theme), /usr/share/icons/hicolor/scalable/emblems(hicolor-icon-theme), /usr/share/icons/hicolor/scalable/status(hicolor-icon-theme), /usr/share/icons/hicolor/symbolic(hicolor-icon-theme), /usr/share/icons/hicolor/symbolic/apps(hicolor-icon-theme) [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: The spec file handles locales properly. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 1 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package contains desktop file if it is a GUI application. [x]: Package installs a %{name}.desktop using desktop-file-install or desktop-file-validate if there is such a file. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [!]: The placement of pkgconfig(.pc) files are correct. Note: budgie-control-center : /usr/share/pkgconfig/budgie- keybindings.pc [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [!]: Spec use %global instead of %define unless justified. Note: %define requiring justification: %define cheese_version 3.28.0, %define glib2_version 2.64, %define gnome_online_accounts_version 3.44.0, %define gnome_stack 42.0, %define gtk3_version 3.24, %define polkit_version 0.105, %define upower_version 0.99.8, %define vala_version 0.52.5 [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Fully versioned dependency in subpackages if applicable. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. ===== EXTRA items ===== Generic: [!]: Large data in /usr/share should live in a noarch subpackage if package is arched. Note: Arch-ed rpms have a total of 17418240 bytes in /usr/share budgie-control-center-1.0.2-1.fc37.x86_64.rpm:17418240 See: https://fedoraproject.org/wiki/Packaging:ReviewGuidelines#Package_Review_Guidelines [x]: Rpmlint is run on debuginfo package(s). Note: There are rpmlint messages (see attachment). [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Cannot parse rpmlint output: Rpmlint (debuginfo) ------------------- Cannot parse rpmlint output: Rpmlint (installed packages) ---------------------------- Cannot parse rpmlint output: Source checksums ---------------- https://github.com/BuddiesOfBudgie/budgie-control-center/releases/download/v1.0.2/budgie-control-center-1.0.2.tar.xz : CHECKSUM(SHA256) this package : 8de5b98ecee719d52f938eec858788b59402caf0f48b76002375c6555c6383d3 CHECKSUM(SHA256) upstream package : 8de5b98ecee719d52f938eec858788b59402caf0f48b76002375c6555c6383d3 Requires -------- budgie-control-center (rpmlib, GLIBC filtered): /usr/bin/pkg-config accountsservice alsa-lib cheese-libs(x86-64) colord cups-pk-helper dbus glib2(x86-64) glx-utils gnome-bluetooth(x86-64) gnome-desktop3(x86-64) gnome-online-accounts(x86-64) gnome-settings-daemon(x86-64) gsettings-desktop-schemas(x86-64) gtk3(x86-64) iso-codes libX11.so.6()(64bit) libXi.so.6()(64bit) libaccountsservice.so.0()(64bit) libatk-1.0.so.0()(64bit) libc.so.6()(64bit) libcairo.so.2()(64bit) libcheese-gtk.so.25()(64bit) libcheese.so.8()(64bit) libcolord-gtk.so.1()(64bit) libcolord.so.2()(64bit) libcups.so.2()(64bit) libepoxy.so.0()(64bit) libfontconfig.so.1()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgcc_s.so.1(GCC_3.3.1)(64bit) libgcr-base-3.so.1()(64bit) libgdk-3.so.0()(64bit) libgdk_pixbuf-2.0.so.0()(64bit) libgio-2.0.so.0()(64bit) libglib-2.0.so.0()(64bit) libgnome-bluetooth.so.13()(64bit) libgnome-desktop-3.so.19()(64bit) libgoa-1.0.so.0()(64bit) libgoa-backend-1.0.so.1()(64bit) libgobject-2.0.so.0()(64bit) libgsound.so.0()(64bit) libgtk-3.so.0()(64bit) libgtop-2.0.so.11()(64bit) libgudev-1.0.so.0()(64bit) libhandy-1.so.0()(64bit) libhandy-1.so.0(LIBHANDY_1_0)(64bit) libibus-1.0.so.5()(64bit) libkrb5.so.3()(64bit) libkrb5.so.3(krb5_3_MIT)(64bit) libm.so.6()(64bit) libmalcontent-0.so.0()(64bit) libmm-glib.so.0()(64bit) libnm.so.0()(64bit) libnm.so.0(libnm_1_0_0)(64bit) libnm.so.0(libnm_1_12_0)(64bit) libnm.so.0(libnm_1_24_0)(64bit) libnm.so.0(libnm_1_2_0)(64bit) libnma.so.0()(64bit) libnma.so.0(libnma_1_2_0)(64bit) libpango-1.0.so.0()(64bit) libpangocairo-1.0.so.0()(64bit) libpolkit-gobject-1.so.0()(64bit) libpulse-mainloop-glib.so.0()(64bit) libpulse-mainloop-glib.so.0(PULSE_0)(64bit) libpulse.so.0()(64bit) libpulse.so.0(PULSE_0)(64bit) libpwquality.so.1()(64bit) libpwquality.so.1(LIBPWQUALITY_1.0)(64bit) libsecret-1.so.0()(64bit) libsmbclient.so.0()(64bit) libsmbclient.so.0(SMBCLIENT_0.1.0)(64bit) libsoup-2.4.so.1()(64bit) libudisks2.so.0()(64bit) libupower-glib.so.3()(64bit) libwacom.so.9()(64bit) libwacom.so.9(LIBWACOM_2.0)(64bit) libxml2.so.2()(64bit) libxml2.so.2(LIBXML2_2.4.30)(64bit) malcontent malcontent-control rtld(GNU_HASH) upower(x86-64) budgie-control-center-debuginfo (rpmlib, GLIBC filtered): budgie-control-center-debugsource (rpmlib, GLIBC filtered): Provides -------- budgie-control-center: application() application(budgie-applications-panel.desktop) application(budgie-background-panel.desktop) application(budgie-bluetooth-panel.desktop) application(budgie-camera-panel.desktop) application(budgie-color-panel.desktop) application(budgie-control-center.desktop) application(budgie-datetime-panel.desktop) application(budgie-default-apps-panel.desktop) application(budgie-diagnostics-panel.desktop) application(budgie-display-panel.desktop) application(budgie-info-overview-panel.desktop) application(budgie-keyboard-panel.desktop) application(budgie-location-panel.desktop) application(budgie-microphone-panel.desktop) application(budgie-mouse-panel.desktop) application(budgie-multitasking-panel.desktop) application(budgie-network-panel.desktop) application(budgie-notifications-panel.desktop) application(budgie-online-accounts-panel.desktop) application(budgie-power-panel.desktop) application(budgie-printers-panel.desktop) application(budgie-region-panel.desktop) application(budgie-removable-media-panel.desktop) application(budgie-sharing-panel.desktop) application(budgie-sound-panel.desktop) application(budgie-thunderbolt-panel.desktop) application(budgie-universal-access-panel.desktop) application(budgie-usage-panel.desktop) application(budgie-user-accounts-panel.desktop) application(budgie-wacom-panel.desktop) application(budgie-wifi-panel.desktop) application(budgie-wwan-panel.desktop) budgie-control-center budgie-control-center(x86-64) metainfo() metainfo(budgie-control-center.appdata.xml) pkgconfig(budgie-keybindings) budgie-control-center-debuginfo: budgie-control-center-debuginfo budgie-control-center-debuginfo(x86-64) debuginfo(build-id) budgie-control-center-debugsource: budgie-control-center-debugsource budgie-control-center-debugsource(x86-64) Generated by fedora-review 0.8.0 (e988316) last change: 2022-04-07 Command line :/usr/bin/fedora-review -b 2086265 -m fedora-rawhide-x86_64 Buildroot used: fedora-rawhide-x86_64 Active plugins: Shell-api, C/C++, Generic Disabled plugins: PHP, Haskell, R, fonts, Python, Ocaml, Perl, Java, SugarActivity Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH
So I know it has been a fair bit since the last update on this, but I believe this is ready for review again. I have been using fedora-review to aid me in identifying issues and I believe I have addressed the most crucial ones. Sources: https://github.com/BuddiesOfBudgie/fedora-pkg/tree/main/budgie-control-center This has been built under both f37 and f36, with active usage under f36.
Yeah, things look good to me now, so... PACKAGE APPROVED.
(fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/budgie-control-center
Package is now in repositories, closing review.