Depends on https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=2086267 and https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=2086268

Taking this review.

*** Bug 2003783 has been marked as a duplicate of this bug. ***

Initial spec review:

> # Seems to ship /usr/lib/.build-id* otherwise
> %define _build_id_links none

Please remove this, as it breaks proper debuginfo subpackage generation.

Issue raised should now be addressed. Thanks for the quick review!

I've sponsored joshstrobl as part of the budgie-screensaver package review.

Updated to use macros for source to ease maintainability :)

Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated


Issues:
=======
- If your application is a C or C++ application you must list a
  BuildRequires against gcc, gcc-c++ or clang.
  Note: No gcc, gcc-c++ or clang found in BuildRequires
  See: https://docs.fedoraproject.org/en-US/packaging-guidelines/C_and_C++/
- Development (unversioned) .so files in -devel subpackage, if present.
  Note: Unversioned so-files directly in %_libdir.
  See: https://docs.fedoraproject.org/en-US/packaging-
  guidelines/#_devel_packages


===== MUST items =====

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Header files in -devel subpackage, if present.
[x]: ldconfig not called in %post and %postun for Fedora 28 and later.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "Unknown or generated", "GNU General Public License, Version
     2", "GNU Lesser General Public License, Version 2.1", "GNU Lesser
     General Public License, Version 2.1 GNU General Public License,
     Version 2 Creative Commons Attribution-ShareAlike 3.0", "*No
     copyright* GNU General Public License, Version 2", "*No copyright*
     [generated file]", "GNU Lesser General Public License v2.1 or later",
     "GNU General Public License, Version 2 Creative Commons Attribution-
     ShareAlike 4.0", "GNU General Public License v2.0 or later". 342 files
     have unknown license. Detailed output of licensecheck in
     /home/ngompa/2086269-budgie-desktop/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: If the package is under multiple licenses, the licensing breakdown
     must be documented in the spec.
[!]: Package requires other packages for directories it uses.
     Note: No known owner of /usr/lib64/budgie-desktop/plugins,
     /usr/share/locale/be_Latn, /usr/share/locale/fr_BE,
     /usr/share/locale/fr_BE/LC_MESSAGES,
     /usr/share/locale/be_Latn/LC_MESSAGES, /usr/lib64/budgie-desktop,
     /usr/share/backgrounds/budgie, /usr/share/budgie
[!]: Package must own all directories that it creates.
     Note: Directories without known owners:
     /usr/share/locale/fr_BE/LC_MESSAGES, /usr/lib64/budgie-
     desktop/plugins, /usr/share/gir-1.0, /usr/lib64/budgie-desktop,
     /usr/share/budgie, /usr/share/locale/fr_BE,
     /usr/share/backgrounds/budgie, /usr/share/locale/be_Latn,
     /usr/share/locale/be_Latn/LC_MESSAGES
[!]: Package does not own files or directories owned by other packages.
     Note: Dirs in package are owned also by: /usr/share/gtk-doc(clutter-
     doc, gtkdatabox-devel, clutter-gst3-devel, gtranslator, gnome-
     bluetooth-libs-devel, iio-sensor-proxy-docs, glib2-doc, gom-devel,
     libgdl-devel, libxslt-devel, libgweather-devel, garcon-devel, gcr-
     devel, switcheroo-control-docs, glade-devel, libsoup3-doc,
     libmodulemd1-devel, dconf-devel, libgxps-devel, gegl04-devel-docs,
     nautilus-devel, power-profiles-daemon-docs, flatpak-devel,
     libgtop2-devel, libfm-devel-docs, libarrow-glib-doc, poppler-glib-doc,
     libgnome-devel, gnome-autoar-devel, tumbler-devel, gobject-
     introspection-devel, rasqal-devel, gtk2-devel-docs, libdazzle-devel,
     amtk-devel, low-memory-monitor-doc, libglib-testing-devel, clipsmm-
     doc, libgnt-doc, gsound-devel, redland-devel, geoclue2-devel, vips-
     devel, libchamplain-devel, libcloudproviders-devel, libgda-devel,
     libmodulemd-devel, appstream-compose-devel, anaconda-widgets-devel,
     libnma-devel, libwnck-devel, exo-devel, libxklavier-devel,
     libwnck3-devel, libgdata-devel, libu2f-host-devel, graphene-devel,
     libinsane-gobject-devel, gupnp-igd-devel, libcryptui-devel,
     gsequencer-devel-doc, harfbuzz-devel, libsoup-doc, gnome-online-
     accounts-devel, unique-devel, gupnp-av-docs, ibus-devel-docs,
     libgnome-keyring-devel, geocode-glib-devel, libunity-gtk-parser-devel,
     parole-devel, cutter-devel, libxfce4util-devel, vte291-devel, gedit-
     devel, gupnp-dlna-docs, gupnp-docs, libgit2-glib-devel, rygel-devel,
     gfbgraph-devel, template-glib-devel, gspell-doc, raptor2-devel,
     ORBit2-devel, nautilus-python-devel, tomoe-devel, libdbusmenu-doc,
     cheese-libs-devel, libgpod-doc, xfconf-devel, gmime30-devel,
     unique3-docs, gtk-doc, p11-kit-devel, gdk-pixbuf2-xlib-devel, anjuta-
     devel, dbus-doc, gtksourceview4-devel, libxml2-devel, webkit2gtk3-doc,
     gtkspell3-devel, libxmlb-devel, gnome-bluetooth3.34-libs-devel, gimp-
     devel, buildstream-docs, libgexiv2-devel, libldm-devel,
     goocanvas2-devel, libcanberra-devel, bamf-devel, gtkimageview-devel,
     upower-devel-docs, gnome-desktop3-devel, fprintd-devel, gnome-panel-
     devel, udisks-devel, lasem-devel, playerctl-docs, polkit-docs,
     libxfce4ui-devel, colord-gtk-devel, libidn2-devel, gtk3-devel-docs,
     libjcat-devel, eog-devel), /usr/share/gtk-doc/html(clutter-doc,
     gtkdatabox-devel, clutter-gst3-devel, gtranslator, gnome-bluetooth-
     libs-devel, iio-sensor-proxy-docs, glib2-doc, gom-devel, libgdl-devel,
     libxslt-devel, libgweather-devel, garcon-devel, gcr-devel, switcheroo-
     control-docs, glade-devel, libsoup3-doc, libmodulemd1-devel, dconf-
     devel, libgxps-devel, gegl04-devel-docs, nautilus-devel, power-
     profiles-daemon-docs, flatpak-devel, libgtop2-devel, libfm-devel-docs,
     libarrow-glib-doc, poppler-glib-doc, libgnome-devel, gnome-autoar-
     devel, tumbler-devel, gobject-introspection-devel, rasqal-devel,
     gtk2-devel-docs, libdazzle-devel, amtk-devel, low-memory-monitor-doc,
     libglib-testing-devel, clipsmm-doc, libgnt-doc, gsound-devel, redland-
     devel, geoclue2-devel, vips-devel, libchamplain-devel,
     libcloudproviders-devel, libgda-devel, libmodulemd-devel, appstream-
     compose-devel, anaconda-widgets-devel, libnma-devel, libwnck-devel,
     exo-devel, libxklavier-devel, libwnck3-devel, libgdata-devel,
     libu2f-host-devel, graphene-devel, libinsane-gobject-devel, gupnp-igd-
     devel, libcryptui-devel, gsequencer-devel-doc, harfbuzz-devel,
     libsoup-doc, gnome-online-accounts-devel, unique-devel, gupnp-av-docs,
     ibus-devel-docs, libgnome-keyring-devel, geocode-glib-devel, libunity-
     gtk-parser-devel, parole-devel, cutter-devel, libxfce4util-devel,
     vte291-devel, gedit-devel, gupnp-dlna-docs, gupnp-docs, libgit2-glib-
     devel, rygel-devel, gfbgraph-devel, template-glib-devel, gspell-doc,
     raptor2-devel, ORBit2-devel, nautilus-python-devel, tomoe-devel,
     libdbusmenu-doc, cheese-libs-devel, libgpod-doc, xfconf-devel,
     gmime30-devel, unique3-docs, p11-kit-devel, gdk-pixbuf2-xlib-devel,
     anjuta-devel, dbus-doc, gtksourceview4-devel, libxml2-devel,
     webkit2gtk3-doc, gtkspell3-devel, libxmlb-devel, gnome-
     bluetooth3.34-libs-devel, xed-doc, gimp-devel, buildstream-docs,
     libgexiv2-devel, libldm-devel, goocanvas2-devel, libcanberra-devel,
     bamf-devel, gtkimageview-devel, gnome-desktop3-devel, fprintd-devel,
     gnome-panel-devel, udisks-devel, lasem-devel, playerctl-docs, polkit-
     docs, libxfce4ui-devel, colord-gtk-devel, libidn2-devel, gtk3-devel-
     docs, libjcat-devel, eog-devel), /usr/share/vala(gtksourceview4-devel,
     libgnome-keyring-devel, gitg-devel, libgda-ui-devel, pulseaudio-libs-
     devel, libgee06-devel, vala, caribou-devel, gmime-devel, gnome-autoar-
     devel, gegl04-devel, babl-devel, gupnp-av-devel, ibus-devel,
     vte291-devel, gedit-devel, libdazzle-devel, appstream-devel,
     libgexiv2-devel, gtksourceview5-devel, libgit2-glib-devel,
     libsoup3-devel, libdmapsharing-devel, libcanberra-devel, bamf-devel,
     libtranslit-devel, rygel-devel, zeitgeist-devel, librsvg2-devel,
     gsound-devel, gspell-devel, gssdp-devel, libgweather-devel, template-
     glib-devel, libmanette-devel, jsonrpc-glib-devel, libsoup-devel,
     folks-devel, geoclue2-devel, gcr-devel, gupnp-dlna-devel, tracker-
     devel, libgnome-games-support-devel, gplugin-vala, libgda-devel,
     gtksourceview3-devel, libosinfo-devel, gnome-calculator-devel, gupnp-
     devel, libhandy-devel, dconf-devel, gmime30-devel, libgdata-devel,
     libjcat-devel, grilo-devel, libdmapsharing4-devel, libgee-devel,
     libsecret-devel, gnome-online-accounts-devel, rhythmbox-devel,
     libgweather4-devel), /usr/share/vala/vapi(gtksourceview4-devel,
     libgnome-keyring-devel, gitg-devel, libgda-ui-devel, pulseaudio-libs-
     devel, libgee06-devel, vala, caribou-devel, gmime-devel, gnome-autoar-
     devel, gegl04-devel, babl-devel, gupnp-av-devel, ibus-devel,
     vte291-devel, gedit-devel, libdazzle-devel, appstream-devel,
     libgexiv2-devel, gtksourceview5-devel, libgit2-glib-devel,
     libsoup3-devel, libdmapsharing-devel, libcanberra-devel, bamf-devel,
     libtranslit-devel, rygel-devel, zeitgeist-devel, librsvg2-devel,
     gsound-devel, gspell-devel, gssdp-devel, libgweather-devel, template-
     glib-devel, libmanette-devel, jsonrpc-glib-devel, libsoup-devel,
     folks-devel, geoclue2-devel, gcr-devel, gupnp-dlna-devel,
     libzeitgeist-devel, tracker-devel, libgnome-games-support-devel,
     gplugin-vala, libgda-devel, gtksourceview3-devel, libosinfo-devel,
     gnome-calculator-devel, gupnp-devel, libhandy-devel, dconf-devel,
     gmime30-devel, libgdata-devel, libjcat-devel, grilo-devel,
     libdmapsharing4-devel, libgee-devel, libsecret-devel, gnome-online-
     accounts-devel, rhythmbox-devel, libgweather4-devel, fwupd-devel),
     /usr/share/icons/hicolor(massif-visualizer, nedit, qemu-common,
     autokey-common, qmmp, redeclipse, tuxanci, wesnoth-data,
     klatexformula, wdisplays, mono-tools, lammps-data, android-file-
     transfer, xchm, hicolor-icon-theme, kgraphviewer, vacuum-im, vim-X11,
     pdfmod, qtl866, swappy, freedroidrpg, fedora-logos),
     /usr/share/icons/hicolor/scalable(massif-visualizer, qemu-common,
     wdisplays, lxqt-powermanagement, autokey-common, freedroidrpg, qmmp,
     eom, keepassx, swappy, tuxanci, dxf2gcode, fedora-logos, pdfmod,
     klatexformula, qtl866, korganizer, hicolor-icon-theme),
     /usr/share/icons/hicolor/scalable/actions(hicolor-icon-theme),
     /usr/share/icons/hicolor/scalable/apps(massif-visualizer, qemu-common,
     qucs, swappy, autokey-common, freedroidrpg, qmmp, eom, keepassx,
     wdisplays, tuxanci, dxf2gcode, fedora-logos, pdfmod, klatexformula,
     qtl866, korganizer, hicolor-icon-theme),
     /usr/share/icons/hicolor/scalable/status(hicolor-icon-theme)
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: The spec file handles locales properly.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package contains desktop file if it is a GUI application.
[x]: Package installs a %{name}.desktop using desktop-file-install or
     desktop-file-validate if there is such a file.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

===== SHOULD items =====

Generic:
[-]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Patches link to upstream bugs/comments/lists or are otherwise
     justified.
[-]: Sources are verified with gpgverify first in %prep if upstream
     publishes signatures.
     Note: gpgverify is not used.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
     files.
[!]: Spec use %global instead of %define unless justified.
     Note: %define requiring justification: %define glib2_version 2.64,
     %define gnome_stack 42.0, %define gtk3_version 3.24, %define
     polkit_version 0.105, %define vala_version 0.52.5
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Fully versioned dependency in subpackages if applicable.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: The placement of pkgconfig(.pc) files are correct.
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.

===== EXTRA items =====

Generic:
[!]: Spec file according to URL is the same as in SRPM.
     Note: Spec file as given by url is not the same as in SRPM (see
     attached diff).
     See: (this test has no URL)
[!]: Large data in /usr/share should live in a noarch subpackage if package
     is arched.
     Note: Arch-ed rpms have a total of 2580480 bytes in /usr/share
[x]: Rpmlint is run on debuginfo package(s).
     Note: There are rpmlint messages (see attachment).
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).


Rpmlint
-------
Cannot parse rpmlint output:


Rpmlint (debuginfo)
-------------------
Cannot parse rpmlint output:



Rpmlint (installed packages)
----------------------------
Cannot parse rpmlint output:


Unversioned so-files
--------------------
budgie-desktop: /usr/lib64/budgie-desktop/libgvc.so
budgie-desktop: /usr/lib64/budgie-desktop/plugins/org.budgie-desktop.applet.budgie-menu/libbudgiemenuapplet.so
budgie-desktop: /usr/lib64/budgie-desktop/plugins/org.budgie-desktop.applet.caffeine/libcaffeineapplet.so
budgie-desktop: /usr/lib64/budgie-desktop/plugins/org.budgie-desktop.applet.clock/libclockapplet.so
budgie-desktop: /usr/lib64/budgie-desktop/plugins/org.budgie-desktop.applet.icon-tasklist/libicontasklistapplet.so
budgie-desktop: /usr/lib64/budgie-desktop/plugins/org.budgie-desktop.applet.keyboard-layout/libkeyboardlayoutapplet.so
budgie-desktop: /usr/lib64/budgie-desktop/plugins/org.budgie-desktop.applet.lock-keys/liblockkeysapplet.so
budgie-desktop: /usr/lib64/budgie-desktop/plugins/org.budgie-desktop.applet.night-light/libnightlightapplet.so
budgie-desktop: /usr/lib64/budgie-desktop/plugins/org.budgie-desktop.applet.notifications/libnotificationsapplet.so
budgie-desktop: /usr/lib64/budgie-desktop/plugins/org.budgie-desktop.applet.places-indicator/libplacesindicator.so
budgie-desktop: /usr/lib64/budgie-desktop/plugins/org.budgie-desktop.applet.raven-trigger/libraventriggerapplet.so
budgie-desktop: /usr/lib64/budgie-desktop/plugins/org.budgie-desktop.applet.separator/libseparatorapplet.so
budgie-desktop: /usr/lib64/budgie-desktop/plugins/org.budgie-desktop.applet.show-desktop/libshowdesktopapplet.so
budgie-desktop: /usr/lib64/budgie-desktop/plugins/org.budgie-desktop.applet.spacer/libspacerapplet.so
budgie-desktop: /usr/lib64/budgie-desktop/plugins/org.budgie-desktop.applet.status/libstatusapplet.so
budgie-desktop: /usr/lib64/budgie-desktop/plugins/org.budgie-desktop.applet.tasklist/libtasklistapplet.so
budgie-desktop: /usr/lib64/budgie-desktop/plugins/org.budgie-desktop.applet.tray/libtrayapplet.so
budgie-desktop: /usr/lib64/budgie-desktop/plugins/org.budgie-desktop.applet.user-indicator/libuserindicator.so
budgie-desktop: /usr/lib64/budgie-desktop/plugins/org.budgie-desktop.applet.workspaces/libworkspacesapplet.so
budgie-desktop: /usr/lib64/libbudgie-plugin.so
budgie-desktop: /usr/lib64/libbudgie-private.so
budgie-desktop: /usr/lib64/libbudgietheme.so
budgie-desktop: /usr/lib64/libraven.so

Source checksums
----------------
https://github.com/BuddiesOfBudgie/budgie-desktop/releases/download/v10.6.1/budgie-desktop-v10.6.1.tar.xz :
  CHECKSUM(SHA256) this package     : b320cfdff8fab37286f0ca6669ef2907f551fa2a38cabd764cbf7b9e6181e166
  CHECKSUM(SHA256) upstream package : b320cfdff8fab37286f0ca6669ef2907f551fa2a38cabd764cbf7b9e6181e166


Requires
--------
budgie-desktop (rpmlib, GLIBC filtered):
    /usr/bin/sh
    budgie-desktop-view
    budgie-screensaver
    glib2(x86-64)
    gnome-bluetooth3.34-libs
    gnome-session
    gtk3(x86-64)
    libGLESv2.so.2()(64bit)
    libX11.so.6()(64bit)
    libXcomposite.so.1()(64bit)
    libasound.so.2()(64bit)
    libasound.so.2(ALSA_0.9)(64bit)
    libbudgie-plugin.so.0()(64bit)
    libbudgie-private.so.0()(64bit)
    libbudgietheme.so.0()(64bit)
    libc.so.6()(64bit)
    libcairo.so.2()(64bit)
    libgdk-3.so.0()(64bit)
    libgdk_pixbuf-2.0.so.0()(64bit)
    libgio-2.0.so.0()(64bit)
    libgirepository-1.0.so.1()(64bit)
    libglib-2.0.so.0()(64bit)
    libgnome-bluetooth.so.13()(64bit)
    libgnome-desktop-3.so.19()(64bit)
    libgnome-menu-3.so.0()(64bit)
    libgobject-2.0.so.0()(64bit)
    libgtk-3.so.0()(64bit)
    libgvc.so()(64bit)
    libibus-1.0.so.5()(64bit)
    libm.so.6()(64bit)
    libmutter-10.so.0()(64bit)
    libmutter-clutter-10.so.0()(64bit)
    libmutter-cogl-10.so.0()(64bit)
    libnotify.so.4()(64bit)
    libpeas-1.0.so.0()(64bit)
    libpolkit-agent-1.so.0()(64bit)
    libpolkit-gobject-1.so.0()(64bit)
    libpulse-mainloop-glib.so.0()(64bit)
    libpulse-mainloop-glib.so.0(PULSE_0)(64bit)
    libpulse.so.0()(64bit)
    libpulse.so.0(PULSE_0)(64bit)
    libraven.so.0()(64bit)
    libupower-glib.so.3()(64bit)
    libuuid.so.1()(64bit)
    libuuid.so.1(UUID_1.0)(64bit)
    libuuid.so.1(UUID_2.20)(64bit)
    libwnck-3.so.0()(64bit)
    lightdm
    rtld(GNU_HASH)
    slick-greeter

budgie-desktop-devel (rpmlib, GLIBC filtered):
    /usr/bin/pkg-config
    budgie-desktop(x86-64)
    libbudgie-plugin.so.0()(64bit)
    libbudgie-private.so.0()(64bit)
    libbudgietheme.so.0()(64bit)
    libraven.so.0()(64bit)
    pkgconfig(gio-unix-2.0)
    pkgconfig(glib-2.0)
    pkgconfig(gtk+-3.0)
    pkgconfig(libpeas-1.0)

budgie-desktop-docs (rpmlib, GLIBC filtered):
    budgie-desktop(x86-64)

budgie-desktop-debuginfo (rpmlib, GLIBC filtered):

budgie-desktop-debugsource (rpmlib, GLIBC filtered):



Provides
--------
budgie-desktop:
    application()
    application(budgie-daemon.desktop)
    application(budgie-desktop-settings.desktop)
    application(budgie-panel.desktop)
    application(budgie-polkit.desktop)
    application(budgie-wm.desktop)
    budgie-desktop
    budgie-desktop(x86-64)
    libbudgie-plugin.so.0()(64bit)
    libbudgie-private.so.0()(64bit)
    libbudgiemenuapplet.so()(64bit)
    libbudgietheme.so.0()(64bit)
    libcaffeineapplet.so()(64bit)
    libclockapplet.so()(64bit)
    libgvc.so()(64bit)
    libicontasklistapplet.so()(64bit)
    libkeyboardlayoutapplet.so()(64bit)
    liblockkeysapplet.so()(64bit)
    libnightlightapplet.so()(64bit)
    libnotificationsapplet.so()(64bit)
    libplacesindicator.so()(64bit)
    libraven.so.0()(64bit)
    libraventriggerapplet.so()(64bit)
    libseparatorapplet.so()(64bit)
    libshowdesktopapplet.so()(64bit)
    libspacerapplet.so()(64bit)
    libstatusapplet.so()(64bit)
    libtasklistapplet.so()(64bit)
    libtrayapplet.so()(64bit)
    libuserindicator.so()(64bit)
    libworkspacesapplet.so()(64bit)

budgie-desktop-devel:
    budgie-desktop-devel
    budgie-desktop-devel(x86-64)
    pkgconfig(budgie-1.0)
    pkgconfig(budgie-theme-1.0)

budgie-desktop-docs:
    budgie-desktop-docs
    budgie-desktop-docs(x86-64)

budgie-desktop-debuginfo:
    budgie-desktop-debuginfo
    budgie-desktop-debuginfo(x86-64)
    debuginfo(build-id)
    libbudgie-plugin.so.0.0.0-10.6.1-1.fc37.x86_64.debug()(64bit)
    libbudgie-private.so.0.0.0-10.6.1-1.fc37.x86_64.debug()(64bit)
    libbudgiemenuapplet.so-10.6.1-1.fc37.x86_64.debug()(64bit)
    libbudgietheme.so.0.0.0-10.6.1-1.fc37.x86_64.debug()(64bit)
    libcaffeineapplet.so-10.6.1-1.fc37.x86_64.debug()(64bit)
    libclockapplet.so-10.6.1-1.fc37.x86_64.debug()(64bit)
    libgvc.so-10.6.1-1.fc37.x86_64.debug()(64bit)
    libicontasklistapplet.so-10.6.1-1.fc37.x86_64.debug()(64bit)
    libkeyboardlayoutapplet.so-10.6.1-1.fc37.x86_64.debug()(64bit)
    liblockkeysapplet.so-10.6.1-1.fc37.x86_64.debug()(64bit)
    libnightlightapplet.so-10.6.1-1.fc37.x86_64.debug()(64bit)
    libnotificationsapplet.so-10.6.1-1.fc37.x86_64.debug()(64bit)
    libplacesindicator.so-10.6.1-1.fc37.x86_64.debug()(64bit)
    libraven.so.0.0.0-10.6.1-1.fc37.x86_64.debug()(64bit)
    libraventriggerapplet.so-10.6.1-1.fc37.x86_64.debug()(64bit)
    libseparatorapplet.so-10.6.1-1.fc37.x86_64.debug()(64bit)
    libshowdesktopapplet.so-10.6.1-1.fc37.x86_64.debug()(64bit)
    libspacerapplet.so-10.6.1-1.fc37.x86_64.debug()(64bit)
    libstatusapplet.so-10.6.1-1.fc37.x86_64.debug()(64bit)
    libtasklistapplet.so-10.6.1-1.fc37.x86_64.debug()(64bit)
    libtrayapplet.so-10.6.1-1.fc37.x86_64.debug()(64bit)
    libuserindicator.so-10.6.1-1.fc37.x86_64.debug()(64bit)
    libworkspacesapplet.so-10.6.1-1.fc37.x86_64.debug()(64bit)

budgie-desktop-debugsource:
    budgie-desktop-debugsource
    budgie-desktop-debugsource(x86-64)



Diff spec file in url and in SRPM
---------------------------------
--- /home/ngompa/2086269-budgie-desktop/srpm/budgie-desktop.spec	2022-05-16 17:46:57.409771747 -0400
+++ /home/ngompa/2086269-budgie-desktop/srpm-unpacked/budgie-desktop.spec	2022-05-15 17:08:17.000000000 -0400
@@ -12,5 +12,5 @@
 License:        GPLv2 and LGPLv2
 URL:            https://github.com/BuddiesOfBudgie/budgie-desktop
-Source0:        %{url}/releases/download/v%{version}/%{name}-v%{version}.tar.xz
+Source0:  %{url}/releases/download/v%{version}/%{name}-v%{version}.tar.xz
 
 # Drop unnecessary Comment in daemon desktop that produces warning.


Generated by fedora-review 0.8.0 (e988316) last change: 2022-04-07
Command line :/usr/bin/fedora-review -b 2086269 -m fedora-rawhide-x86_64 --mock-options=--enablerepo=local
Buildroot used: fedora-rawhide-x86_64
Active plugins: Generic, Shell-api, C/C++
Disabled plugins: R, SugarActivity, Perl, Haskell, PHP, Ocaml, fonts, Python, Java
Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH

Most of the issues listed in the fedora-review report are pretty understandable, but one needs more explanation.

> - Development (unversioned) .so files in -devel subpackage, if present.
>   Note: Unversioned so-files directly in %_libdir.
>   See: https://docs.fedoraproject.org/en-US/packaging-
>   guidelines/#_devel_packages

This is caused by a bad glob:

> %{_libdir}/lib*.so*

This should be enumerated properly to capture soversions.

See: https://docs.fedoraproject.org/en-US/packaging-guidelines/#_listing_shared_library_files

> %package docs
> Summary: Documentation for budgie-desktop
> Requires: %{name}%{?_isa} = %{version}-%{release}
> 
> %description docs
> Documentation for budgie-desktop

Your docs should not be archful. Add "BuildArch: noarch" and drop "%{?_isa}" from the Requires stanza.

I will be fixing the globbing itself but the SOs are not versioned at this time and are not development related (our plugins, Raven, Budgie Theme logic, etc. are in unique shared libraries). I am not opposed to that being worked on and filing an issue for action, but it would be a fairly significant task and would negatively impact the timeline for inclusion.

Currently working on the other items as well.

Hey there,

Budgie Desktop is now ready for re-review. The spec is available at https://raw.githubusercontent.com/BuddiesOfBudgie/fedora-pkg/main/budgie-desktop/budgie-desktop.spec and the SRPM for F37 is at https://github.com/BuddiesOfBudgie/fedora-pkg/raw/main/budgie-desktop/budgie-desktop-10.6.2-1.fc37.src.rpm

To help with any of the review process, I have pasted the review.txt from fedora-review below. I would like to draw your attention to the items regarding locales and get your insight if possible. I had added the ownership of those locale dirs with the %dir macro however it then was flagging that as something that needed to be fixed, but not having it also complains about it lacking ownership. I am not really sure how much of a problem it actually is, if at all, but it is something I wanted to bring up. The other items like the unversioned shared objects aren't really actionable items without quite literally breaking plugins for existing installs.

This has also been tested with a Koji scratch build and it passed all architecture builds. You can see it at https://koji.fedoraproject.org/koji/taskinfo?taskID=89545314

Anyways...

----


This is a review *template*. Besides handling the [ ]-marked tests you are
also supposed to fix the template before pasting into bugzilla:
- Add issues you find to the list of issues on top. If there isn't such
  a list, create one.
- Add your own remarks to the template checks.
- Add new lines marked [!] or [?] when you discover new things not
  listed by fedora-review.
- Change or remove any text in the template which is plain wrong. In this
  case you could also file a bug against fedora-review
- Remove the "[ ] Manual check required", you will not have any such lines
  in what you paste.
- Remove attachments which you deem not really useful (the rpmlint
  ones are mandatory, though)
- Remove this text



Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



===== MUST items =====

C/C++:
[ ]: Package does not contain kernel modules.
[ ]: Package contains no static executables.
[ ]: Development (unversioned) .so files in -devel subpackage, if present.
     Note: Unversioned so-files in private %_libdir subdirectory (see
     attachment). Verify they are not in ld path.
[x]: If your application is a C or C++ application you must list a
     BuildRequires against gcc, gcc-c++ or clang.
[x]: Header files in -devel subpackage, if present.
[x]: ldconfig not called in %post and %postun for Fedora 28 and later.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.

Generic:
[ ]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[ ]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "Unknown or generated", "GNU General Public License, Version
     2", "GNU Lesser General Public License, Version 2.1", "GNU Lesser
     General Public License, Version 2.1 GNU General Public License,
     Version 2 Creative Commons Attribution-ShareAlike 3.0", "*No
     copyright* GNU General Public License, Version 2", "*No copyright*
     [generated file]", "GNU Lesser General Public License v2.1 or later",
     "GNU General Public License, Version 2 Creative Commons Attribution-
     ShareAlike 4.0", "GNU General Public License v2.0 or later". 342 files
     have unknown license. Detailed output of licensecheck in
     /home/joshua/Code/BuddiesOfBudgie/fedora-pkg/budgie-desktop/review-
     budgie-desktop/licensecheck.txt
[ ]: License file installed when any subpackage combination is installed.
[ ]: If the package is under multiple licenses, the licensing breakdown
     must be documented in the spec.
[ ]: Package requires other packages for directories it uses.
     Note: No known owner of /usr/share/locale/fr_BE,
     /usr/share/locale/be_Latn, /usr/share/locale/fr_BE/LC_MESSAGES,
     /usr/share/locale/be_Latn/LC_MESSAGES
[ ]: Package must own all directories that it creates.
     Note: Directories without known owners: /usr/share/locale/fr_BE,
     /usr/share/locale/be_Latn, /usr/share/locale/fr_BE/LC_MESSAGES,
     /usr/share/locale/be_Latn/LC_MESSAGES
[ ]: Package does not own files or directories owned by other packages.
     Note: Dirs in package are owned also by: /usr/share/gtk-
     doc/html(glade-devel, libgnome-keyring-devel, gtkimageview-devel,
     colord-gtk-devel, exo-devel, unique-devel, unique3-docs, low-memory-
     monitor-doc, gnome-software-devel, iio-sensor-proxy-docs, garcon-
     devel, libgnome-devel, libarrow-glib-doc, libwnck3-devel, power-
     profiles-daemon-docs, xfconf-devel, clutter-gst3-devel, gupnp-docs,
     libwnck-devel, libxfce4ui-devel, playerctl-docs, switcheroo-control-
     docs, libgdl-devel, geocode-glib-devel, libinsane-gobject-devel,
     nautilus-python-devel, gimp-devel, libmodulemd-devel, gcr-devel,
     libdbusmenu-doc, parole-devel, ORBit2-devel, gdk-pixbuf2-xlib-devel,
     gnome-desktop3-devel, tumbler-devel, libgxps-devel, gtkdatabox-devel,
     cutter-devel, template-glib-devel, gupnp-dlna-docs, p11-kit-devel,
     libcryptui-devel, nautilus-devel, udisks-devel, libgda-devel, gupnp-
     igd-devel, libsoup3-doc, libgit2-glib-devel, eog-devel, libgpod-doc,
     buildstream-docs, graphene-devel, libglib-testing-devel, libldm-devel,
     libunity-gtk-parser-devel, raptor2-devel, libcloudproviders-devel,
     libcanberra-devel, gedit-devel, libgdata-devel, libsoup-doc, vips-
     devel, xed-doc, gmime30-devel, dconf-devel, anaconda-widgets-devel,
     goocanvas2-devel, gtksourceview4-devel, libxslt-devel,
     libmodulemd1-devel, libu2f-host-devel, bamf-devel, geoclue2-devel,
     gtranslator, lasem-devel, gfbgraph-devel, libxfce4util-devel, clutter-
     doc, dbus-doc, gtkspell3-devel, libnma-devel, cheese-libs-devel,
     libjcat-devel, libgnt-doc, gtk3-devel-docs, libgexiv2-devel, gupnp-av-
     docs, libidn2-devel, webkit2gtk3-doc, gom-devel, gnome-online-
     accounts-devel, vte291-devel, gnome-bluetooth3.34-libs-devel, amtk-
     devel, libchamplain-devel, polkit-docs, libgweather-devel, clipsmm-
     doc, fprintd-devel, appstream-compose-devel, glib2-doc, gnome-panel-
     devel, libxml2-devel, gsound-devel, rygel-devel, libdazzle-devel,
     poppler-glib-doc, harfbuzz-devel, gegl04-devel-docs, gnome-bluetooth-
     libs-devel, gobject-introspection-devel, rasqal-devel, redland-devel,
     ibus-devel-docs, gspell-doc, libgtop2-devel, anjuta-devel, flatpak-
     devel, libfm-devel-docs, geocode-glib2-devel, libxmlb-devel,
     gtk2-devel-docs, libxklavier-devel, gsequencer-devel-doc, gnome-
     autoar-devel, tomoe-devel), /usr/share/vala(libgweather-devel,
     libgee06-devel, gtksourceview4-devel, libdmapsharing4-devel, gupnp-
     devel, gssdp-devel, libgda-devel, gnome-calculator-devel,
     libsoup3-devel, libgnome-keyring-devel, libgit2-glib-devel, bamf-
     devel, geoclue2-devel, rygel-devel, gsound-devel, libdazzle-devel,
     gtksourceview5-devel, gupnp-av-devel, gegl04-devel, rhythmbox-devel,
     tracker-devel, libhandy-devel, libsoup-devel, libgee-devel,
     libgweather4-devel, babl-devel, appstream-devel, gspell-devel, gmime-
     devel, gtksourceview3-devel, gplugin-vala, gitg-devel, caribou-devel,
     libtranslit-devel, folks-devel, libcanberra-devel, libjcat-devel,
     vala, gedit-devel, grilo-devel, libgdata-devel, libgexiv2-devel, gcr-
     devel, gupnp-dlna-devel, zeitgeist-devel, libgda-ui-devel, libmanette-
     devel, librsvg2-devel, gnome-online-accounts-devel, pulseaudio-libs-
     devel, libsecret-devel, jsonrpc-glib-devel, libgnome-games-support-
     devel, libdmapsharing-devel, libosinfo-devel, template-glib-devel,
     gnome-autoar-devel, vte291-devel, ibus-devel, gmime30-devel, dconf-
     devel), /usr/share/vala/vapi(libgweather-devel, libgee06-devel,
     gtksourceview4-devel, libdmapsharing4-devel, gupnp-devel, gssdp-devel,
     libgda-devel, gnome-calculator-devel, libsoup3-devel, libgnome-
     keyring-devel, libzeitgeist-devel, libgit2-glib-devel, bamf-devel,
     geoclue2-devel, rygel-devel, gsound-devel, libdazzle-devel,
     gtksourceview5-devel, gupnp-av-devel, gegl04-devel, rhythmbox-devel,
     tracker-devel, libhandy-devel, libsoup-devel, libgee-devel,
     libgweather4-devel, babl-devel, appstream-devel, gspell-devel, gmime-
     devel, gtksourceview3-devel, gplugin-vala, gitg-devel, caribou-devel,
     libtranslit-devel, folks-devel, libcanberra-devel, libjcat-devel,
     vala, gedit-devel, grilo-devel, libgdata-devel, libgexiv2-devel, gcr-
     devel, gupnp-dlna-devel, zeitgeist-devel, libgda-ui-devel, fwupd-
     devel, libmanette-devel, librsvg2-devel, gnome-online-accounts-devel,
     pulseaudio-libs-devel, libsecret-devel, jsonrpc-glib-devel, libgnome-
     games-support-devel, libdmapsharing-devel, libosinfo-devel, template-
     glib-devel, gnome-autoar-devel, vte291-devel, ibus-devel,
     gmime30-devel, dconf-devel), /usr/share/budgie(budgie-control-center-
     common), /usr/share/gir-1.0(glade-devel, GConf2-devel,
     libdmapsharing4-devel, gupnp-devel, gssdp-devel, libgnome-keyring-
     devel, webkit2gtk3-devel, colord-gtk-devel, gplugin-gtk3-devel,
     tracker-devel, libhandy-devel, gplugin-gtk4-devel, gnome-menus-devel,
     gspell-devel, libgdl-devel, gtk2-devel, gitg-devel, libinsane-gobject-
     devel, libmodulemd-devel, fcitx-devel, gcr-devel, gupnp-dlna-devel,
     libgxps-devel, libmanette-devel, gtk4-devel, libpeas-devel, atk-devel,
     libsecret-devel, parquet-glib-devel, gplugin-devel, clutter-devel,
     template-glib-devel, libcryptui-devel, libadwaita-devel,
     libsoup3-devel, gupnp-igd-devel, libarrow-glib-devel, gucharmap-devel,
     totem-pl-parser-devel, webkit2gtk3-jsc-devel, gtksourceview5-devel,
     gupnp-av-devel, gst-devtools-devel, graphene-devel, libsoup-devel,
     grilo-devel, libgdata-devel, librsvg2-devel, vips-devel, jsonrpc-glib-
     devel, ibus-devel, gmime30-devel, vte-devel, goocanvas2-devel,
     libgee06-devel, gtksourceview4-devel, libarrow-dataset-glib-devel,
     libmodulemd1-devel, gtk3-devel, geoclue2-devel, bamf-devel,
     gegl04-devel, json-glib-devel, gfbgraph-devel, babl-devel, libmash-
     devel, at-spi2-core-devel, libjcat-devel, malcontent-ui-devel,
     libgexiv2-devel, gsequencer-devel, zbar-gi, gnome-online-accounts-
     devel, vte291-devel, clapper-devel, gnome-bluetooth3.34-libs-devel,
     amtk-devel, libmypaint-devel, libchamplain-devel, gdk-pixbuf2-devel,
     gnome-calculator-devel, rygel-devel, gsound-devel, libdazzle-devel,
     harfbuzz-devel, gnome-bluetooth-libs-devel, libgee-devel, appstream-
     devel, gobject-introspection-devel, libgepub-devel, fcitx5-gtk-devel,
     libgtop2-devel, libxmlb-devel, libxklavier-devel, gstreamer1-rtsp-
     server-devel, gdm-devel, gnome-autoar-devel, malcontent-devel),
     /usr/share/icons(filesystem, budgie-control-center-common),
     /usr/share/icons/hicolor(tuxanci, qtl866, xchm, nedit, vim-X11,
     lammps-data, hicolor-icon-theme, pdfmod, autokey-common, kgraphviewer,
     swappy, klatexformula, budgie-control-center-common, qemu-common,
     redeclipse, freedroidrpg, qmmp, massif-visualizer, wesnoth-data, mono-
     tools, fedora-logos, android-file-transfer, wdisplays, vacuum-im),
     /usr/share/icons/hicolor/scalable(budgie-control-center-common, qemu-
     common, dxf2gcode, hicolor-icon-theme, fedora-logos, pdfmod, autokey-
     common, freedroidrpg, korganizer, lxqt-powermanagement, qtl866,
     swappy, tuxanci, eom, qmmp, wdisplays, klatexformula, massif-
     visualizer), /usr/share/icons/hicolor/scalable/actions(hicolor-icon-
     theme), /usr/share/icons/hicolor/scalable/apps(budgie-control-center-
     common, qemu-common, dxf2gcode, hicolor-icon-theme, fedora-logos,
     qucs, pdfmod, autokey-common, freedroidrpg, korganizer, qtl866,
     swappy, tuxanci, eom, qmmp, wdisplays, klatexformula, massif-
     visualizer), /usr/share/icons/hicolor/scalable/status(budgie-control-
     center-common, hicolor-icon-theme)
[ ]: %build honors applicable compiler flags or justifies otherwise.
[ ]: Package contains no bundled libraries without FPC exception.
[ ]: Changelog in prescribed format.
[ ]: Sources contain only permissible code or content.
[ ]: Development files must be in a -devel package
[ ]: Package uses nothing in %doc for runtime.
[ ]: The spec file handles locales properly.
[ ]: Package consistently uses macros (instead of hard-coded directory
     names).
[ ]: Package is named according to the Package Naming Guidelines.
[ ]: Package does not generate any conflict.
[ ]: Package obeys FHS, except libexecdir and /usr/target.
[ ]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[ ]: Requires correct, justified where necessary.
[ ]: Spec file is legible and written in American English.
[ ]: Package contains systemd file(s) if in need.
[ ]: Useful -debuginfo package or justification otherwise.
[ ]: Package is not known to require an ExcludeArch tag.
[ ]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 10240 bytes in 1 files.
[ ]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package contains desktop file if it is a GUI application.
[x]: Package installs a %{name}.desktop using desktop-file-install or
     desktop-file-validate if there is such a file.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

===== SHOULD items =====

Generic:
[ ]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[ ]: Final provides and requires are sane (see attachments).
[ ]: Package functions as described.
[ ]: Latest version is packaged.
[ ]: Package does not include license text files separate from upstream.
[ ]: Package should compile and build into binary rpms on all supported
     architectures.
[ ]: %check is present and all tests pass.
[ ]: Packages should try to preserve timestamps of original installed
     files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Fully versioned dependency in subpackages if applicable.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: The placement of pkgconfig(.pc) files are correct.
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Sources are verified with gpgverify first in %prep if upstream
     publishes signatures.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[ ]: Large data in /usr/share should live in a noarch subpackage if package
     is arched.
     Note: Arch-ed rpms have a total of 2580480 bytes in /usr/share
[x]: Rpmlint is run on debuginfo package(s).
     Note: There are rpmlint messages (see attachment).
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Spec file according to URL is the same as in SRPM.


Rpmlint
-------
Cannot parse rpmlint output:


Rpmlint (debuginfo)
-------------------
Cannot parse rpmlint output:



Rpmlint (installed packages)
----------------------------
Cannot parse rpmlint output:


Unversioned so-files
--------------------
budgie-desktop: /usr/lib64/budgie-desktop/libgvc.so
budgie-desktop: /usr/lib64/budgie-desktop/plugins/org.budgie-desktop.applet.budgie-menu/libbudgiemenuapplet.so
budgie-desktop: /usr/lib64/budgie-desktop/plugins/org.budgie-desktop.applet.caffeine/libcaffeineapplet.so
budgie-desktop: /usr/lib64/budgie-desktop/plugins/org.budgie-desktop.applet.clock/libclockapplet.so
budgie-desktop: /usr/lib64/budgie-desktop/plugins/org.budgie-desktop.applet.icon-tasklist/libicontasklistapplet.so
budgie-desktop: /usr/lib64/budgie-desktop/plugins/org.budgie-desktop.applet.keyboard-layout/libkeyboardlayoutapplet.so
budgie-desktop: /usr/lib64/budgie-desktop/plugins/org.budgie-desktop.applet.lock-keys/liblockkeysapplet.so
budgie-desktop: /usr/lib64/budgie-desktop/plugins/org.budgie-desktop.applet.night-light/libnightlightapplet.so
budgie-desktop: /usr/lib64/budgie-desktop/plugins/org.budgie-desktop.applet.notifications/libnotificationsapplet.so
budgie-desktop: /usr/lib64/budgie-desktop/plugins/org.budgie-desktop.applet.places-indicator/libplacesindicator.so
budgie-desktop: /usr/lib64/budgie-desktop/plugins/org.budgie-desktop.applet.raven-trigger/libraventriggerapplet.so
budgie-desktop: /usr/lib64/budgie-desktop/plugins/org.budgie-desktop.applet.separator/libseparatorapplet.so
budgie-desktop: /usr/lib64/budgie-desktop/plugins/org.budgie-desktop.applet.show-desktop/libshowdesktopapplet.so
budgie-desktop: /usr/lib64/budgie-desktop/plugins/org.budgie-desktop.applet.spacer/libspacerapplet.so
budgie-desktop: /usr/lib64/budgie-desktop/plugins/org.budgie-desktop.applet.status/libstatusapplet.so
budgie-desktop: /usr/lib64/budgie-desktop/plugins/org.budgie-desktop.applet.tasklist/libtasklistapplet.so
budgie-desktop: /usr/lib64/budgie-desktop/plugins/org.budgie-desktop.applet.tray/libtrayapplet.so
budgie-desktop: /usr/lib64/budgie-desktop/plugins/org.budgie-desktop.applet.user-indicator/libuserindicator.so
budgie-desktop: /usr/lib64/budgie-desktop/plugins/org.budgie-desktop.applet.workspaces/libworkspacesapplet.so

Source checksums
----------------
https://joshuastrobl.com/pubkey.gpg :
  CHECKSUM(SHA256) this package     : 457b6bd60d99522ca3d202f55381f3d20e90a170f893591eecaf48e4b80dc501
  CHECKSUM(SHA256) upstream package : 457b6bd60d99522ca3d202f55381f3d20e90a170f893591eecaf48e4b80dc501
https://github.com/BuddiesOfBudgie/budgie-desktop/releases/download/v10.6.2/budgie-desktop-v10.6.2.tar.xz.asc :
  CHECKSUM(SHA256) this package     : 0b19e1610376ced186782c96098330b97f512937df137e6fcae8c1825d23c17b
  CHECKSUM(SHA256) upstream package : 0b19e1610376ced186782c96098330b97f512937df137e6fcae8c1825d23c17b
https://github.com/BuddiesOfBudgie/budgie-desktop/releases/download/v10.6.2/budgie-desktop-v10.6.2.tar.xz :
  CHECKSUM(SHA256) this package     : 42b2b359d0c7f7cf08fb869f3b616d8f1a4d643013b216aab39544035e6a9d64
  CHECKSUM(SHA256) upstream package : 42b2b359d0c7f7cf08fb869f3b616d8f1a4d643013b216aab39544035e6a9d64


Requires
--------
budgie-desktop (rpmlib, GLIBC filtered):
    /usr/bin/sh
    budgie-desktop-view
    budgie-screensaver
    glib2(x86-64)
    gnome-bluetooth3.34-libs
    gnome-session
    gnome-settings-daemon
    gsettings-desktop-schemas
    gtk3(x86-64)
    libGLESv2.so.2()(64bit)
    libX11.so.6()(64bit)
    libXcomposite.so.1()(64bit)
    libasound.so.2()(64bit)
    libasound.so.2(ALSA_0.9)(64bit)
    libbudgie-plugin.so.0()(64bit)
    libbudgie-private.so.0()(64bit)
    libbudgietheme.so.0()(64bit)
    libc.so.6()(64bit)
    libcairo.so.2()(64bit)
    libgdk-3.so.0()(64bit)
    libgdk_pixbuf-2.0.so.0()(64bit)
    libgio-2.0.so.0()(64bit)
    libgirepository-1.0.so.1()(64bit)
    libglib-2.0.so.0()(64bit)
    libgnome-bluetooth.so.13()(64bit)
    libgnome-desktop-3.so.19()(64bit)
    libgnome-menu-3.so.0()(64bit)
    libgobject-2.0.so.0()(64bit)
    libgtk-3.so.0()(64bit)
    libgvc.so()(64bit)
    libibus-1.0.so.5()(64bit)
    libm.so.6()(64bit)
    libmutter-10.so.0()(64bit)
    libmutter-clutter-10.so.0()(64bit)
    libmutter-cogl-10.so.0()(64bit)
    libnotify.so.4()(64bit)
    libpeas-1.0.so.0()(64bit)
    libpolkit-agent-1.so.0()(64bit)
    libpolkit-gobject-1.so.0()(64bit)
    libpulse-mainloop-glib.so.0()(64bit)
    libpulse-mainloop-glib.so.0(PULSE_0)(64bit)
    libpulse.so.0()(64bit)
    libpulse.so.0(PULSE_0)(64bit)
    libraven.so.0()(64bit)
    libupower-glib.so.3()(64bit)
    libuuid.so.1()(64bit)
    libuuid.so.1(UUID_1.0)(64bit)
    libuuid.so.1(UUID_2.20)(64bit)
    libwnck-3.so.0()(64bit)
    network-manager-applet
    rtld(GNU_HASH)
    xdotool

budgie-desktop-devel (rpmlib, GLIBC filtered):
    /usr/bin/pkg-config
    budgie-desktop(x86-64)
    libbudgie-plugin.so.0()(64bit)
    libbudgie-private.so.0()(64bit)
    libbudgietheme.so.0()(64bit)
    libraven.so.0()(64bit)
    pkgconfig(gio-unix-2.0)
    pkgconfig(glib-2.0)
    pkgconfig(gtk+-3.0)
    pkgconfig(libpeas-1.0)

budgie-desktop-docs (rpmlib, GLIBC filtered):
    budgie-desktop(x86-64)
    gtk-doc

budgie-desktop-debuginfo (rpmlib, GLIBC filtered):

budgie-desktop-debugsource (rpmlib, GLIBC filtered):



Provides
--------
budgie-desktop:
    application()
    application(budgie-daemon.desktop)
    application(budgie-desktop-settings.desktop)
    application(budgie-panel.desktop)
    application(budgie-polkit.desktop)
    application(budgie-wm.desktop)
    budgie-desktop
    budgie-desktop(x86-64)
    libbudgie-plugin.so.0()(64bit)
    libbudgie-private.so.0()(64bit)
    libbudgiemenuapplet.so()(64bit)
    libbudgietheme.so.0()(64bit)
    libcaffeineapplet.so()(64bit)
    libclockapplet.so()(64bit)
    libgvc.so()(64bit)
    libicontasklistapplet.so()(64bit)
    libkeyboardlayoutapplet.so()(64bit)
    liblockkeysapplet.so()(64bit)
    libnightlightapplet.so()(64bit)
    libnotificationsapplet.so()(64bit)
    libplacesindicator.so()(64bit)
    libraven.so.0()(64bit)
    libraventriggerapplet.so()(64bit)
    libseparatorapplet.so()(64bit)
    libshowdesktopapplet.so()(64bit)
    libspacerapplet.so()(64bit)
    libstatusapplet.so()(64bit)
    libtasklistapplet.so()(64bit)
    libtrayapplet.so()(64bit)
    libuserindicator.so()(64bit)
    libworkspacesapplet.so()(64bit)

budgie-desktop-devel:
    budgie-desktop-devel
    budgie-desktop-devel(x86-64)
    pkgconfig(budgie-1.0)
    pkgconfig(budgie-theme-1.0)

budgie-desktop-docs:
    budgie-desktop-docs
    budgie-desktop-docs(x86-64)

budgie-desktop-debuginfo:
    budgie-desktop-debuginfo
    budgie-desktop-debuginfo(x86-64)
    debuginfo(build-id)
    libbudgie-plugin.so.0.0.0-10.6.2-1.fc37.x86_64.debug()(64bit)
    libbudgie-private.so.0.0.0-10.6.2-1.fc37.x86_64.debug()(64bit)
    libbudgiemenuapplet.so-10.6.2-1.fc37.x86_64.debug()(64bit)
    libbudgietheme.so.0.0.0-10.6.2-1.fc37.x86_64.debug()(64bit)
    libcaffeineapplet.so-10.6.2-1.fc37.x86_64.debug()(64bit)
    libclockapplet.so-10.6.2-1.fc37.x86_64.debug()(64bit)
    libgvc.so-10.6.2-1.fc37.x86_64.debug()(64bit)
    libicontasklistapplet.so-10.6.2-1.fc37.x86_64.debug()(64bit)
    libkeyboardlayoutapplet.so-10.6.2-1.fc37.x86_64.debug()(64bit)
    liblockkeysapplet.so-10.6.2-1.fc37.x86_64.debug()(64bit)
    libnightlightapplet.so-10.6.2-1.fc37.x86_64.debug()(64bit)
    libnotificationsapplet.so-10.6.2-1.fc37.x86_64.debug()(64bit)
    libplacesindicator.so-10.6.2-1.fc37.x86_64.debug()(64bit)
    libraven.so.0.0.0-10.6.2-1.fc37.x86_64.debug()(64bit)
    libraventriggerapplet.so-10.6.2-1.fc37.x86_64.debug()(64bit)
    libseparatorapplet.so-10.6.2-1.fc37.x86_64.debug()(64bit)
    libshowdesktopapplet.so-10.6.2-1.fc37.x86_64.debug()(64bit)
    libspacerapplet.so-10.6.2-1.fc37.x86_64.debug()(64bit)
    libstatusapplet.so-10.6.2-1.fc37.x86_64.debug()(64bit)
    libtasklistapplet.so-10.6.2-1.fc37.x86_64.debug()(64bit)
    libtrayapplet.so-10.6.2-1.fc37.x86_64.debug()(64bit)
    libuserindicator.so-10.6.2-1.fc37.x86_64.debug()(64bit)
    libworkspacesapplet.so-10.6.2-1.fc37.x86_64.debug()(64bit)

budgie-desktop-debugsource:
    budgie-desktop-debugsource
    budgie-desktop-debugsource(x86-64)



Generated by fedora-review 0.8.0 (e988316) last change: 2022-04-07
Command line :/usr/bin/fedora-review --name budgie-desktop --define DISTTAG=fc37
Buildroot used: fedora-rawhide-x86_64
Active plugins: Generic, Shell-api, C/C++
Disabled plugins: PHP, Perl, Java, Ocaml, Haskell, Python, R, fonts, SugarActivity
Disabled flags: EPEL6, EPEL7, BATCH, EXARCH

> Your docs should not be archful. Add "BuildArch: noarch" and drop "%{?_isa}" from the Requires stanza.

Managed to miss this, fixing now :D

Updated review file for updates specs


This is a review *template*. Besides handling the [ ]-marked tests you are
also supposed to fix the template before pasting into bugzilla:
- Add issues you find to the list of issues on top. If there isn't such
  a list, create one.
- Add your own remarks to the template checks.
- Add new lines marked [!] or [?] when you discover new things not
  listed by fedora-review.
- Change or remove any text in the template which is plain wrong. In this
  case you could also file a bug against fedora-review
- Remove the "[ ] Manual check required", you will not have any such lines
  in what you paste.
- Remove attachments which you deem not really useful (the rpmlint
  ones are mandatory, though)
- Remove this text



Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



===== MUST items =====

C/C++:
[ ]: Package does not contain kernel modules.
[ ]: Package contains no static executables.
[ ]: Development (unversioned) .so files in -devel subpackage, if present.
     Note: Unversioned so-files in private %_libdir subdirectory (see
     attachment). Verify they are not in ld path.
[x]: If your application is a C or C++ application you must list a
     BuildRequires against gcc, gcc-c++ or clang.
[x]: Header files in -devel subpackage, if present.
[x]: ldconfig not called in %post and %postun for Fedora 28 and later.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.

Generic:
[ ]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[ ]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "Unknown or generated", "GNU General Public License, Version
     2", "GNU Lesser General Public License, Version 2.1", "GNU Lesser
     General Public License, Version 2.1 GNU General Public License,
     Version 2 Creative Commons Attribution-ShareAlike 3.0", "*No
     copyright* GNU General Public License, Version 2", "*No copyright*
     [generated file]", "GNU Lesser General Public License v2.1 or later",
     "GNU General Public License, Version 2 Creative Commons Attribution-
     ShareAlike 4.0", "GNU General Public License v2.0 or later". 342 files
     have unknown license. Detailed output of licensecheck in
     /home/joshua/Code/BuddiesOfBudgie/fedora-pkg/budgie-desktop/review-
     budgie-desktop/licensecheck.txt
[ ]: License file installed when any subpackage combination is installed.
[ ]: If the package is under multiple licenses, the licensing breakdown
     must be documented in the spec.
[ ]: Package requires other packages for directories it uses.
     Note: No known owner of /usr/share/locale/fr_BE/LC_MESSAGES,
     /usr/share/locale/fr_BE, /usr/share/locale/be_Latn,
     /usr/share/locale/be_Latn/LC_MESSAGES
[ ]: Package must own all directories that it creates.
     Note: Directories without known owners:
     /usr/share/locale/fr_BE/LC_MESSAGES,
     /usr/share/locale/be_Latn/LC_MESSAGES, /usr/share/locale/fr_BE,
     /usr/share/locale/be_Latn
[ ]: Package does not own files or directories owned by other packages.
     Note: Dirs in package are owned also by: /usr/share/gtk-
     doc/html(libfm-devel-docs, graphene-devel, gedit-devel, playerctl-
     docs, libglib-testing-devel, polkit-docs, gtk3-devel-docs, cheese-
     libs-devel, ibus-devel-docs, tomoe-devel, libmodulemd1-devel, eog-
     devel, gegl04-devel-docs, p11-kit-devel, rasqal-devel, parole-devel,
     redland-devel, glade-devel, libxfce4util-devel, xed-doc, tumbler-
     devel, dconf-devel, gtkimageview-devel, gsequencer-devel-doc,
     libgnome-keyring-devel, rygel-devel, libxklavier-devel, gnome-
     bluetooth3.34-libs-devel, libxmlb-devel, libmodulemd-devel, gsound-
     devel, clipsmm-doc, vte291-devel, libcanberra-devel, template-glib-
     devel, lasem-devel, appstream-compose-devel, gtkspell3-devel,
     libcloudproviders-devel, gimp-devel, udisks-devel, libgdl-devel,
     unique3-docs, libgit2-glib-devel, libxml2-devel, gnome-software-devel,
     gnome-panel-devel, switcheroo-control-docs, low-memory-monitor-doc,
     libldm-devel, bamf-devel, gnome-online-accounts-devel, gupnp-docs,
     gspell-doc, libwnck3-devel, nautilus-python-devel, gmime30-devel,
     nautilus-devel, cutter-devel, vips-devel, amtk-devel, flatpak-devel,
     gcr-devel, libgnome-devel, libgpod-doc, anjuta-devel, ORBit2-devel,
     garcon-devel, libcryptui-devel, libgda-devel, libgexiv2-devel,
     buildstream-docs, libwnck-devel, gtranslator, power-profiles-daemon-
     docs, xfconf-devel, libinsane-gobject-devel, exo-devel, libchamplain-
     devel, gdk-pixbuf2-xlib-devel, geoclue2-devel, gnome-bluetooth-libs-
     devel, libsoup-doc, glib2-doc, libgdata-devel, geocode-glib-devel,
     clutter-gst3-devel, libjcat-devel, libdazzle-devel, webkit2gtk3-doc,
     gfbgraph-devel, clutter-doc, libdbusmenu-doc, libgtop2-devel, gnome-
     autoar-devel, gupnp-igd-devel, libunity-gtk-parser-devel,
     gtksourceview4-devel, iio-sensor-proxy-docs, libxslt-devel, colord-
     gtk-devel, gom-devel, gtk2-devel-docs, dbus-doc, unique-devel,
     geocode-glib2-devel, libu2f-host-devel, gnome-desktop3-devel,
     libsoup3-doc, fprintd-devel, gupnp-dlna-docs, gobject-introspection-
     devel, gtkdatabox-devel, libgnt-doc, libarrow-glib-doc, libgxps-devel,
     raptor2-devel, libxfce4ui-devel, poppler-glib-doc, libgweather-devel,
     gupnp-av-docs, libnma-devel, goocanvas2-devel, harfbuzz-devel,
     libidn2-devel, anaconda-widgets-devel), /usr/share/budgie(budgie-
     control-center-common), /usr/share/gir-1.0(graphene-devel, malcontent-
     ui-devel, totem-pl-parser-devel, libgee06-devel, gtk3-devel,
     librsvg2-devel, gucharmap-devel, grilo-devel, libmodulemd1-devel,
     ibus-devel, zbar-gi, gegl04-devel, gspell-devel, fcitx5-gtk-devel,
     gtksourceview5-devel, glade-devel, gst-devtools-devel, gtk2-devel,
     rygel-devel, libgnome-keyring-devel, libpeas-devel, malcontent-devel,
     libxklavier-devel, fcitx-devel, gnome-bluetooth3.34-libs-devel,
     libxmlb-devel, gdk-pixbuf2-devel, libmodulemd-devel, babl-devel,
     gsound-devel, gsequencer-devel, atk-devel, vte291-devel, libadwaita-
     devel, template-glib-devel, gdm-devel, gstreamer1-rtsp-server-devel,
     tracker-devel, libarrow-glib-devel, libgdl-devel, GConf2-devel, gitg-
     devel, gplugin-gtk3-devel, webkit2gtk3-devel, appstream-devel, gupnp-
     dlna-devel, bamf-devel, gnome-online-accounts-devel, libgepub-devel,
     parquet-glib-devel, gmime30-devel, vips-devel, amtk-devel, gcr-devel,
     libsoup3-devel, gupnp-devel, libcryptui-devel, gnome-menus-devel,
     libgexiv2-devel, vte-devel, libinsane-gobject-devel, libchamplain-
     devel, geoclue2-devel, gnome-bluetooth-libs-devel, libgdata-devel,
     libgee-devel, libjcat-devel, libdazzle-devel, gtk4-devel, gplugin-
     gtk4-devel, gfbgraph-devel, jsonrpc-glib-devel, libgtop2-devel, gnome-
     autoar-devel, gupnp-igd-devel, clutter-devel, gtksourceview4-devel,
     libsecret-devel, webkit2gtk3-jsc-devel, colord-gtk-devel, gupnp-av-
     devel, gplugin-devel, libhandy-devel, libmypaint-devel, gobject-
     introspection-devel, at-spi2-core-devel, clapper-devel, libmanette-
     devel, libsoup-devel, libgxps-devel, libarrow-dataset-glib-devel,
     goocanvas2-devel, libmash-devel, gnome-calculator-devel, json-glib-
     devel, harfbuzz-devel, gssdp-devel, libdmapsharing4-devel),
     /usr/share/icons(filesystem, budgie-control-center-common),
     /usr/share/icons/hicolor(massif-visualizer, swappy, redeclipse, nedit,
     autokey-common, wesnoth-data, qemu-common, fedora-logos, kgraphviewer,
     pdfmod, wdisplays, budgie-control-center-common, freedroidrpg, qmmp,
     android-file-transfer, klatexformula, qtl866, xchm, vacuum-im, mono-
     tools, lammps-data, hicolor-icon-theme, tuxanci, vim-X11),
     /usr/share/icons/hicolor/scalable(autokey-common, massif-visualizer,
     qtl866, qemu-common, fedora-logos, dxf2gcode, pdfmod, klatexformula,
     swappy, wdisplays, budgie-control-center-common, lxqt-powermanagement,
     freedroidrpg, korganizer, hicolor-icon-theme, tuxanci, eom, qmmp),
     /usr/share/icons/hicolor/scalable/actions(hicolor-icon-theme),
     /usr/share/icons/hicolor/scalable/apps(autokey-common, massif-
     visualizer, qtl866, qucs, qemu-common, fedora-logos, dxf2gcode,
     pdfmod, klatexformula, swappy, wdisplays, budgie-control-center-
     common, freedroidrpg, korganizer, hicolor-icon-theme, tuxanci, eom,
     qmmp), /usr/share/icons/hicolor/scalable/status(hicolor-icon-theme,
     budgie-control-center-common), /usr/share/vala(libgda-ui-devel, babl-
     devel, gcr-devel, libgee06-devel, gsound-devel, gedit-devel,
     rhythmbox-devel, gupnp-av-devel, libsoup3-devel, vte291-devel,
     libcanberra-devel, gupnp-devel, folks-devel, libgnome-games-support-
     devel, caribou-devel, libgweather4-devel, template-glib-devel,
     zeitgeist-devel, librsvg2-devel, libgda-devel, libgexiv2-devel, vala,
     libhandy-devel, tracker-devel, pulseaudio-libs-devel, grilo-devel,
     ibus-devel, libmanette-devel, libtranslit-devel, gegl04-devel, gitg-
     devel, libgit2-glib-devel, libosinfo-devel, libsoup-devel, gspell-
     devel, gtksourceview4-devel, geoclue2-devel, appstream-devel,
     libgdata-devel, gplugin-vala, gtksourceview5-devel, gupnp-dlna-devel,
     gmime-devel, bamf-devel, gnome-online-accounts-devel, dconf-devel,
     libdazzle-devel, libdmapsharing-devel, libgee-devel, libgweather-
     devel, libjcat-devel, rygel-devel, libgnome-keyring-devel, jsonrpc-
     glib-devel, gnome-calculator-devel, gtksourceview3-devel, gnome-
     autoar-devel, gmime30-devel, libsecret-devel, gssdp-devel,
     libdmapsharing4-devel), /usr/share/vala/vapi(libgda-ui-devel, fwupd-
     devel, babl-devel, gcr-devel, gsound-devel, libgee06-devel, gedit-
     devel, rhythmbox-devel, gupnp-av-devel, libsoup3-devel, vte291-devel,
     libcanberra-devel, gupnp-devel, folks-devel, libgnome-games-support-
     devel, caribou-devel, libgweather4-devel, template-glib-devel,
     zeitgeist-devel, librsvg2-devel, libgda-devel, libgexiv2-devel, vala,
     libhandy-devel, tracker-devel, pulseaudio-libs-devel, grilo-devel,
     ibus-devel, libmanette-devel, libtranslit-devel, libzeitgeist-devel,
     gegl04-devel, gitg-devel, libgit2-glib-devel, libosinfo-devel,
     libsoup-devel, gspell-devel, gtksourceview4-devel, geoclue2-devel,
     appstream-devel, libgdata-devel, gplugin-vala, gtksourceview5-devel,
     gupnp-dlna-devel, gmime-devel, bamf-devel, gnome-online-accounts-
     devel, dconf-devel, libdazzle-devel, libdmapsharing-devel, libgee-
     devel, libgweather-devel, libjcat-devel, rygel-devel, libgnome-
     keyring-devel, jsonrpc-glib-devel, gnome-calculator-devel,
     gtksourceview3-devel, gnome-autoar-devel, gmime30-devel, libsecret-
     devel, gssdp-devel, libdmapsharing4-devel)
[ ]: %build honors applicable compiler flags or justifies otherwise.
[ ]: Package contains no bundled libraries without FPC exception.
[ ]: Changelog in prescribed format.
[ ]: Sources contain only permissible code or content.
[ ]: Development files must be in a -devel package
[ ]: Package uses nothing in %doc for runtime.
[ ]: The spec file handles locales properly.
[ ]: Package consistently uses macros (instead of hard-coded directory
     names).
[ ]: Package is named according to the Package Naming Guidelines.
[ ]: Package does not generate any conflict.
[ ]: Package obeys FHS, except libexecdir and /usr/target.
[ ]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[ ]: Requires correct, justified where necessary.
[ ]: Spec file is legible and written in American English.
[ ]: Package contains systemd file(s) if in need.
[ ]: Useful -debuginfo package or justification otherwise.
[ ]: Package is not known to require an ExcludeArch tag.
[ ]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 10240 bytes in 1 files.
[ ]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package contains desktop file if it is a GUI application.
[x]: Package installs a %{name}.desktop using desktop-file-install or
     desktop-file-validate if there is such a file.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

===== SHOULD items =====

Generic:
[ ]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[ ]: Final provides and requires are sane (see attachments).
[ ]: Fully versioned dependency in subpackages if applicable.
     Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in budgie-
     desktop-docs
[ ]: Package functions as described.
[ ]: Latest version is packaged.
[ ]: Package does not include license text files separate from upstream.
[ ]: Package should compile and build into binary rpms on all supported
     architectures.
[ ]: %check is present and all tests pass.
[ ]: Packages should try to preserve timestamps of original installed
     files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: The placement of pkgconfig(.pc) files are correct.
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Sources are verified with gpgverify first in %prep if upstream
     publishes signatures.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[ ]: Large data in /usr/share should live in a noarch subpackage if package
     is arched.
     Note: Arch-ed rpms have a total of 2406400 bytes in /usr/share
[x]: Rpmlint is run on debuginfo package(s).
     Note: There are rpmlint messages (see attachment).
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Spec file according to URL is the same as in SRPM.


Rpmlint
-------
Cannot parse rpmlint output:


Rpmlint (debuginfo)
-------------------
Cannot parse rpmlint output:



Rpmlint (installed packages)
----------------------------
Cannot parse rpmlint output:


Unversioned so-files
--------------------
budgie-desktop: /usr/lib64/budgie-desktop/libgvc.so
budgie-desktop: /usr/lib64/budgie-desktop/plugins/org.budgie-desktop.applet.budgie-menu/libbudgiemenuapplet.so
budgie-desktop: /usr/lib64/budgie-desktop/plugins/org.budgie-desktop.applet.caffeine/libcaffeineapplet.so
budgie-desktop: /usr/lib64/budgie-desktop/plugins/org.budgie-desktop.applet.clock/libclockapplet.so
budgie-desktop: /usr/lib64/budgie-desktop/plugins/org.budgie-desktop.applet.icon-tasklist/libicontasklistapplet.so
budgie-desktop: /usr/lib64/budgie-desktop/plugins/org.budgie-desktop.applet.keyboard-layout/libkeyboardlayoutapplet.so
budgie-desktop: /usr/lib64/budgie-desktop/plugins/org.budgie-desktop.applet.lock-keys/liblockkeysapplet.so
budgie-desktop: /usr/lib64/budgie-desktop/plugins/org.budgie-desktop.applet.night-light/libnightlightapplet.so
budgie-desktop: /usr/lib64/budgie-desktop/plugins/org.budgie-desktop.applet.notifications/libnotificationsapplet.so
budgie-desktop: /usr/lib64/budgie-desktop/plugins/org.budgie-desktop.applet.places-indicator/libplacesindicator.so
budgie-desktop: /usr/lib64/budgie-desktop/plugins/org.budgie-desktop.applet.raven-trigger/libraventriggerapplet.so
budgie-desktop: /usr/lib64/budgie-desktop/plugins/org.budgie-desktop.applet.separator/libseparatorapplet.so
budgie-desktop: /usr/lib64/budgie-desktop/plugins/org.budgie-desktop.applet.show-desktop/libshowdesktopapplet.so
budgie-desktop: /usr/lib64/budgie-desktop/plugins/org.budgie-desktop.applet.spacer/libspacerapplet.so
budgie-desktop: /usr/lib64/budgie-desktop/plugins/org.budgie-desktop.applet.status/libstatusapplet.so
budgie-desktop: /usr/lib64/budgie-desktop/plugins/org.budgie-desktop.applet.tasklist/libtasklistapplet.so
budgie-desktop: /usr/lib64/budgie-desktop/plugins/org.budgie-desktop.applet.tray/libtrayapplet.so
budgie-desktop: /usr/lib64/budgie-desktop/plugins/org.budgie-desktop.applet.user-indicator/libuserindicator.so
budgie-desktop: /usr/lib64/budgie-desktop/plugins/org.budgie-desktop.applet.workspaces/libworkspacesapplet.so

Source checksums
----------------
https://joshuastrobl.com/pubkey.gpg :
  CHECKSUM(SHA256) this package     : 457b6bd60d99522ca3d202f55381f3d20e90a170f893591eecaf48e4b80dc501
  CHECKSUM(SHA256) upstream package : 457b6bd60d99522ca3d202f55381f3d20e90a170f893591eecaf48e4b80dc501
https://github.com/BuddiesOfBudgie/budgie-desktop/releases/download/v10.6.2/budgie-desktop-v10.6.2.tar.xz.asc :
  CHECKSUM(SHA256) this package     : 0b19e1610376ced186782c96098330b97f512937df137e6fcae8c1825d23c17b
  CHECKSUM(SHA256) upstream package : 0b19e1610376ced186782c96098330b97f512937df137e6fcae8c1825d23c17b
https://github.com/BuddiesOfBudgie/budgie-desktop/releases/download/v10.6.2/budgie-desktop-v10.6.2.tar.xz :
  CHECKSUM(SHA256) this package     : 42b2b359d0c7f7cf08fb869f3b616d8f1a4d643013b216aab39544035e6a9d64
  CHECKSUM(SHA256) upstream package : 42b2b359d0c7f7cf08fb869f3b616d8f1a4d643013b216aab39544035e6a9d64


Requires
--------
budgie-desktop (rpmlib, GLIBC filtered):
    /usr/bin/sh
    budgie-desktop-view
    budgie-screensaver
    glib2(x86-64)
    gnome-bluetooth3.34-libs
    gnome-session
    gnome-settings-daemon
    gsettings-desktop-schemas
    gtk3(x86-64)
    libGLESv2.so.2()(64bit)
    libX11.so.6()(64bit)
    libXcomposite.so.1()(64bit)
    libasound.so.2()(64bit)
    libasound.so.2(ALSA_0.9)(64bit)
    libbudgie-plugin.so.0()(64bit)
    libbudgie-private.so.0()(64bit)
    libbudgietheme.so.0()(64bit)
    libc.so.6()(64bit)
    libcairo.so.2()(64bit)
    libgdk-3.so.0()(64bit)
    libgdk_pixbuf-2.0.so.0()(64bit)
    libgio-2.0.so.0()(64bit)
    libgirepository-1.0.so.1()(64bit)
    libglib-2.0.so.0()(64bit)
    libgnome-bluetooth.so.13()(64bit)
    libgnome-desktop-3.so.19()(64bit)
    libgnome-menu-3.so.0()(64bit)
    libgobject-2.0.so.0()(64bit)
    libgtk-3.so.0()(64bit)
    libgvc.so()(64bit)
    libibus-1.0.so.5()(64bit)
    libm.so.6()(64bit)
    libmutter-10.so.0()(64bit)
    libmutter-clutter-10.so.0()(64bit)
    libmutter-cogl-10.so.0()(64bit)
    libnotify.so.4()(64bit)
    libpeas-1.0.so.0()(64bit)
    libpolkit-agent-1.so.0()(64bit)
    libpolkit-gobject-1.so.0()(64bit)
    libpulse-mainloop-glib.so.0()(64bit)
    libpulse-mainloop-glib.so.0(PULSE_0)(64bit)
    libpulse.so.0()(64bit)
    libpulse.so.0(PULSE_0)(64bit)
    libraven.so.0()(64bit)
    libupower-glib.so.3()(64bit)
    libuuid.so.1()(64bit)
    libuuid.so.1(UUID_1.0)(64bit)
    libuuid.so.1(UUID_2.20)(64bit)
    libwnck-3.so.0()(64bit)
    network-manager-applet
    rtld(GNU_HASH)
    xdotool

budgie-desktop-devel (rpmlib, GLIBC filtered):
    /usr/bin/pkg-config
    budgie-desktop(x86-64)
    libbudgie-plugin.so.0()(64bit)
    libbudgie-private.so.0()(64bit)
    libbudgietheme.so.0()(64bit)
    libraven.so.0()(64bit)
    pkgconfig(gio-unix-2.0)
    pkgconfig(glib-2.0)
    pkgconfig(gtk+-3.0)
    pkgconfig(libpeas-1.0)

budgie-desktop-docs (rpmlib, GLIBC filtered):
    budgie-desktop
    gtk-doc

budgie-desktop-debuginfo (rpmlib, GLIBC filtered):

budgie-desktop-debugsource (rpmlib, GLIBC filtered):



Provides
--------
budgie-desktop:
    application()
    application(budgie-daemon.desktop)
    application(budgie-desktop-settings.desktop)
    application(budgie-panel.desktop)
    application(budgie-polkit.desktop)
    application(budgie-wm.desktop)
    budgie-desktop
    budgie-desktop(x86-64)
    libbudgie-plugin.so.0()(64bit)
    libbudgie-private.so.0()(64bit)
    libbudgiemenuapplet.so()(64bit)
    libbudgietheme.so.0()(64bit)
    libcaffeineapplet.so()(64bit)
    libclockapplet.so()(64bit)
    libgvc.so()(64bit)
    libicontasklistapplet.so()(64bit)
    libkeyboardlayoutapplet.so()(64bit)
    liblockkeysapplet.so()(64bit)
    libnightlightapplet.so()(64bit)
    libnotificationsapplet.so()(64bit)
    libplacesindicator.so()(64bit)
    libraven.so.0()(64bit)
    libraventriggerapplet.so()(64bit)
    libseparatorapplet.so()(64bit)
    libshowdesktopapplet.so()(64bit)
    libspacerapplet.so()(64bit)
    libstatusapplet.so()(64bit)
    libtasklistapplet.so()(64bit)
    libtrayapplet.so()(64bit)
    libuserindicator.so()(64bit)
    libworkspacesapplet.so()(64bit)

budgie-desktop-devel:
    budgie-desktop-devel
    budgie-desktop-devel(x86-64)
    pkgconfig(budgie-1.0)
    pkgconfig(budgie-theme-1.0)

budgie-desktop-docs:
    budgie-desktop-docs

budgie-desktop-debuginfo:
    budgie-desktop-debuginfo
    budgie-desktop-debuginfo(x86-64)
    debuginfo(build-id)
    libbudgie-plugin.so.0.0.0-10.6.2-1.fc37.x86_64.debug()(64bit)
    libbudgie-private.so.0.0.0-10.6.2-1.fc37.x86_64.debug()(64bit)
    libbudgiemenuapplet.so-10.6.2-1.fc37.x86_64.debug()(64bit)
    libbudgietheme.so.0.0.0-10.6.2-1.fc37.x86_64.debug()(64bit)
    libcaffeineapplet.so-10.6.2-1.fc37.x86_64.debug()(64bit)
    libclockapplet.so-10.6.2-1.fc37.x86_64.debug()(64bit)
    libgvc.so-10.6.2-1.fc37.x86_64.debug()(64bit)
    libicontasklistapplet.so-10.6.2-1.fc37.x86_64.debug()(64bit)
    libkeyboardlayoutapplet.so-10.6.2-1.fc37.x86_64.debug()(64bit)
    liblockkeysapplet.so-10.6.2-1.fc37.x86_64.debug()(64bit)
    libnightlightapplet.so-10.6.2-1.fc37.x86_64.debug()(64bit)
    libnotificationsapplet.so-10.6.2-1.fc37.x86_64.debug()(64bit)
    libplacesindicator.so-10.6.2-1.fc37.x86_64.debug()(64bit)
    libraven.so.0.0.0-10.6.2-1.fc37.x86_64.debug()(64bit)
    libraventriggerapplet.so-10.6.2-1.fc37.x86_64.debug()(64bit)
    libseparatorapplet.so-10.6.2-1.fc37.x86_64.debug()(64bit)
    libshowdesktopapplet.so-10.6.2-1.fc37.x86_64.debug()(64bit)
    libspacerapplet.so-10.6.2-1.fc37.x86_64.debug()(64bit)
    libstatusapplet.so-10.6.2-1.fc37.x86_64.debug()(64bit)
    libtasklistapplet.so-10.6.2-1.fc37.x86_64.debug()(64bit)
    libtrayapplet.so-10.6.2-1.fc37.x86_64.debug()(64bit)
    libuserindicator.so-10.6.2-1.fc37.x86_64.debug()(64bit)
    libworkspacesapplet.so-10.6.2-1.fc37.x86_64.debug()(64bit)

budgie-desktop-debugsource:
    budgie-desktop-debugsource
    budgie-desktop-debugsource(x86-64)



Generated by fedora-review 0.8.0 (e988316) last change: 2022-04-07
Command line :/usr/bin/fedora-review --name budgie-desktop --define DISTTAG=fc37
Buildroot used: fedora-rawhide-x86_64
Active plugins: Generic, C/C++, Shell-api
Disabled plugins: R, Haskell, SugarActivity, Perl, fonts, Python, Ocaml, PHP, Java
Disabled flags: EPEL6, EPEL7, BATCH, EXARCH

Hey Neal, any update on the review of this and my thoughts provided in https://bugzilla.redhat.com/show_bug.cgi?id=2086269#c12 ? :)

At this point, I think we're in good enough shape to let this through.

PACKAGE APPROVED.

Currently working on Mutter 11 / GNOME 43 support. Will land when validated.

(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/budgie-desktop

budgie-desktop has now been submitted for inclusion to bodhi. Closing as resolved!