Spec URL: http://piedmont.homelinux.org/fedora/python-eyed3/python-eyed3.spec SRPM URL: http://piedmont.homelinux.org/fedora/python-eyed3/python-eyed3-0.6.10-1.src.rpm Description: A Python module and program for processing ID3 tags. Information about mp3 files(i.e bit rate, sample frequency, play time, etc.) is also provided. The formats supported are ID3 v1.0/v1.1 and v2.3/v2.4.
* as it is a noarch package it may be better to have BuildRequires: python instead of BuildRequires: python-devel * you could remove the -f option of rm such that it breaks if the file isn't there anymore * You could add README.html and THANKS to %doc * the build is done twice since make triggers the build and the install target depends on all. So I think the make in %build should be removed or commented out with a comment indicating that install triggers the build unconditionally * I think that it would be better to have a * for man files to catch man pages when no compressed or compressed using something different than gz, like %{_mandir}/man1/*.1* * Given that it only creates the directory in python_sitelib, you may optionally set %{python_sitelib}/eyeD3/ instead of %{python_sitelib}/* These issues are not blockers.
Shouldn't the name be python-eyeD3? Otherwise * rpmlint is silent * follow packaging guidelines * spec legible * free software, licence GPL included * sane provides python-eyed3 = 0.6.10-1 * match upstream source 2f7ee6749b993faba3b5d10d9621d314 ./eyeD3-0.6.10.tar.gz * %files right * buildrequires/requires right The only remaining issue is the name.
(In reply to comment #2) > Shouldn't the name be python-eyeD3? It's up to the maintainers discretion. I based the name on how other distros package it also. http://fedoraproject.org/wiki/Packaging/NamingGuidelines#head-96b3088669f40824665abf97ff34841f9b65172d
Ok, APPROVED. But please take into consideration my comments, even though they aren't blockers.
It seems to be built in devel and added to owners.list, please don't forget to close the review.
I'm aware, but I'm waiting for the FC5 branch to be created before closing this.
Package Change Request ====================== Package Name: python-eyed3 New Branches: el6 Owners: cicku
Git done (by process-git-requests).
python-eyed3-0.7.4-1.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/python-eyed3-0.7.4-1.el6
python-eyed3-0.7.4-1.el6 has been pushed to the Fedora EPEL 6 stable repository.
Package Change Request ====================== Package Name: python-eyed3 New Branches: epel7 Owners: cicku