Bug 2099411 - Review Request: python-sphinx-design - Sphinx extension for designing beautiful, screen-size responsive web components
Summary: Review Request: python-sphinx-design - Sphinx extension for designing beautif...
Keywords:
Status: CLOSED DUPLICATE of bug 2099902
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Nobody's working on this, feel free to take it
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 2095189 2105307
TreeView+ depends on / blocked
 
Reported: 2022-06-20 22:01 UTC by Elliott Sales de Andrade
Modified: 2022-07-31 21:20 UTC (History)
3 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2022-07-31 21:20:24 UTC
Type: ---
Embargoed:
ksurma: fedora-review?


Attachments (Terms of Use)

Description Elliott Sales de Andrade 2022-06-20 22:01:40 UTC
Spec URL: https://qulogic.fedorapeople.org/python-sphinx-design.spec
SRPM URL: https://qulogic.fedorapeople.org/python-sphinx-design-0.2.0-1.fc36.src.rpm

Description:
A sphinx extension for designing beautiful, view size responsive web
components.

Created with inspiration from Bootstrap (v5), Material Design and Material-UI
design frameworks.

Fedora Account System Username: qulogic

Comment 1 Elliott Sales de Andrade 2022-06-20 22:01:41 UTC
This package built on koji:  https://koji.fedoraproject.org/koji/taskinfo?taskID=88511252

Comment 2 José Matos 2022-06-22 11:42:11 UTC
*** Bug 2099902 has been marked as a duplicate of this bug. ***

Comment 3 Elliott Sales de Andrade 2022-06-23 05:57:19 UTC
I actually think Jerry did a more thorough job than I did, and I won't have time to refresh this before next weekend at least. If he wants to grab the package from me, I won't mind.

Comment 4 Jerry James 2022-06-28 21:13:08 UTC
I've been super busy and am just now circling back around to this.  I'm fine with it either way.  I guess one of should sign on as comaintainer for the other, whichever package wins out. :-)

Comment 5 Karolina Surma 2022-07-11 14:04:10 UTC
> whichever package wins out. :-)

There was some discussion over Jerry's package already, so I followed with my comments there. 
This package would need very similar improvements as were pointed out there, namely:
- license file is not marked %license (nb. there are more license files in the package - one file per each bundled icon theme)
- licenses are not fully declared in the specfile (from the other specfile: sphinx_design/compiled/material* is ASL 2.0)
- the bundled icon packs should be explicitly mentioned as Provides

I see that tarball from PyPI doesn't contain the upstream tests. In this case I think it'd be better to take the GH's tarball and run them. Ability to catch any inconsistencies when integrating newer Sphinx is - personally for me :-) - really important.

However you decide to follow up with the package (this or the other one - whatever works for you :-)), I'll be happy to review it.

Comment 6 Karolina Surma 2022-07-11 14:12:00 UTC
I did some browsing the packaging guidelines when it comes to the bundled JSON files with icons. 
I found only this: "Support for other font systems, for specific applications, non-OpenType font formats, bulky documentation, TEX, CSS, or JSON files… MUST be split in separate non-font packages, that SHOULD install outside /usr/share/fonts, and MUST NOT use <something>-fonts naming." - which this package fulfills. Their licenses are Fedora-compliant, so I don't see a problem there, they would just need to be declared.

I wonder who in Fedora could know more of the topic. Maybe it's worth starting a devel thread?

Comment 7 Mattias Ellert 2022-07-31 21:20:24 UTC

*** This bug has been marked as a duplicate of bug 2099902 ***


Note You need to log in before you can comment on or make changes to this bug.