Bug 2107583 - `git review -s` broken with openssh 8.8
Summary: `git review -s` broken with openssh 8.8
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: git-review
Version: 36
Hardware: Unspecified
OS: Unspecified
unspecified
high
Target Milestone: ---
Assignee: Haïkel Guémar
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 2280367
TreeView+ depends on / blocked
 
Reported: 2022-07-15 13:10 UTC by Luigi Toscano
Modified: 2024-05-14 15:54 UTC (History)
2 users (show)

Fixed In Version: git-review-2.3.1-1.fc37 git-review-2.3.1-1.fc36
Clone Of:
: 2280367 (view as bug list)
Environment:
Last Closed: 2022-07-21 14:52:51 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description Luigi Toscano 2022-07-15 13:10:08 UTC
Description of problem:

git review -s fails when trying to get the commit-msg script:


Problems encountered installing commit-msg hook
The following command failed with exit code 255
    "scp -P29418 <user>@<host>:hooks/commit-msg .git/hooks/commit-msg"
-----------------------
subsystem request failed on channel 0
scp: Connection closed
-----------------------

openssh 8.8 switched from the scp protocol to the sftp protocol, which is not supported yet by some ssh server used by gerrit instances around. 
However it is still possible to use the deprecated scp protocol by adding the -O parameter to the scp call, and git-review added this workaround after the release 2.2.0 through the following change:

https://review.opendev.org/c/opendev/git-review/+/823413

So either that patch should be be backported, or this is a good time to update git-review to the latest release (2.3.1).

Version-Release number of selected component (if applicable):
git-review version 2.2.0

Comment 1 Haïkel Guémar 2022-07-21 07:53:34 UTC
Hi Luigi, i updated git-review package to 2.3.1 (as provenpackager) on F36+.
Builds are in progress.

Comment 2 Fedora Update System 2022-07-21 07:58:25 UTC
FEDORA-2022-6b482a9de9 has been submitted as an update to Fedora 37. https://bodhi.fedoraproject.org/updates/FEDORA-2022-6b482a9de9

Comment 3 Fedora Update System 2022-07-21 09:05:51 UTC
FEDORA-2022-629523b28f has been submitted as an update to Fedora 36. https://bodhi.fedoraproject.org/updates/FEDORA-2022-629523b28f

Comment 4 Fedora Update System 2022-07-21 14:52:51 UTC
FEDORA-2022-6b482a9de9 has been pushed to the Fedora 37 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 5 Fedora Update System 2022-07-22 06:08:34 UTC
FEDORA-2022-629523b28f has been pushed to the Fedora 36 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2022-629523b28f`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-629523b28f

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 6 Fedora Update System 2022-07-30 01:52:16 UTC
FEDORA-2022-629523b28f has been pushed to the Fedora 36 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.