Bug 2280367 - `git review -s` broken with openssh openssh-8.7p1-38.el9.x86_64 [NEEDINFO]
Summary: `git review -s` broken with openssh openssh-8.7p1-38.el9.x86_64
Keywords:
Status: ON_QA
Alias: None
Product: Fedora EPEL
Classification: Fedora
Component: git-review
Version: epel9
Hardware: Unspecified
OS: Unspecified
unspecified
high
Target Milestone: ---
Assignee: Joel Capitao
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: 2107583
Blocks:
TreeView+ depends on / blocked
 
Reported: 2024-05-14 15:54 UTC by Alfredo Moralejo
Modified: 2024-07-17 12:09 UTC (History)
5 users (show)

Fixed In Version:
Clone Of: 2107583
Environment:
Last Closed:
Type: Bug
Embargoed:
jcapitao: needinfo? (zaitcev)
jcapitao: needinfo? (zaitcev)


Attachments (Terms of Use)

Description Alfredo Moralejo 2024-05-14 15:54:09 UTC
This is also happening in RHEL9. See:

https://www.redhat.com/en/blog/openssh-scp-deprecation-rhel-9-what-you-need-know

+++ This bug was initially created as a clone of Bug #2107583 +++

Description of problem:

git review -s fails when trying to get the commit-msg script:


Problems encountered installing commit-msg hook
The following command failed with exit code 255
    "scp -P29418 <user>@<host>:hooks/commit-msg .git/hooks/commit-msg"
-----------------------
subsystem request failed on channel 0
scp: Connection closed
-----------------------

openssh 8.8 switched from the scp protocol to the sftp protocol, which is not supported yet by some ssh server used by gerrit instances around. 
However it is still possible to use the deprecated scp protocol by adding the -O parameter to the scp call, and git-review added this workaround after the release 2.2.0 through the following change:

https://review.opendev.org/c/opendev/git-review/+/823413

So either that patch should be be backported, or this is a good time to update git-review to the latest release (2.3.1).

Version-Release number of selected component (if applicable):
git-review version 2.2.0

--- Additional comment from Haïkel Guémar on 2022-07-21 07:53:34 UTC ---

Hi Luigi, i updated git-review package to 2.3.1 (as provenpackager) on F36+.
Builds are in progress.

--- Additional comment from Fedora Update System on 2022-07-21 07:58:25 UTC ---

FEDORA-2022-6b482a9de9 has been submitted as an update to Fedora 37. https://bodhi.fedoraproject.org/updates/FEDORA-2022-6b482a9de9

--- Additional comment from Fedora Update System on 2022-07-21 09:05:51 UTC ---

FEDORA-2022-629523b28f has been submitted as an update to Fedora 36. https://bodhi.fedoraproject.org/updates/FEDORA-2022-629523b28f

--- Additional comment from Fedora Update System on 2022-07-21 14:52:51 UTC ---

FEDORA-2022-6b482a9de9 has been pushed to the Fedora 37 stable repository.
If problem still persists, please make note of it in this bug report.

--- Additional comment from Fedora Update System on 2022-07-22 06:08:34 UTC ---

FEDORA-2022-629523b28f has been pushed to the Fedora 36 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2022-629523b28f`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-629523b28f

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

--- Additional comment from Fedora Update System on 2022-07-30 01:52:16 UTC ---

FEDORA-2022-629523b28f has been pushed to the Fedora 36 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 1 Joel Capitao 2024-06-13 12:59:22 UTC
I proposed a PR at https://src.fedoraproject.org/rpms/git-review/pull-request/6 to update to 2.3.1 which contains the fix

Comment 2 Joel Capitao 2024-06-14 07:31:20 UTC
Hello zaitcev
I'm willing to help co-maintain that package in EPEL if you want.

Comment 3 Joel Capitao 2024-07-01 09:30:11 UTC
Hello Zaitcev

I'm reiterating my wish to co-maintain that package in EPEL.

Comment 4 Fedora Admin user for bugzilla script actions 2024-07-17 04:43:36 UTC
This package has changed maintainer in Fedora. Reassigning to the new maintainer of this component.


Note You need to log in before you can comment on or make changes to this bug.