Bug 2112130 - golang-github-prometheus-node-exporter-1.5.0 is available
Summary: golang-github-prometheus-node-exporter-1.5.0 is available
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: golang-github-prometheus-node-exporter
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Mark E. Fuller
QA Contact:
URL:
Whiteboard:
Depends On: 2110790 2166945 2198968 2198971 2198973
Blocks:
TreeView+ depends on / blocked
 
Reported: 2022-07-28 22:04 UTC by Upstream Release Monitoring
Modified: 2023-05-18 17:04 UTC (History)
8 users (show)

Fixed In Version: golang-github-prometheus-node-exporter-1.5.0-1.fc39
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
: 2208339 (view as bug list)
Environment:
Last Closed: 2023-05-18 14:25:26 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)

Description Upstream Release Monitoring 2022-07-28 22:04:43 UTC
Releases retrieved: 1.4.0-rc.0
Upstream release that is considered latest: 1.4.0-rc.0
Current version/release in rawhide: 1.3.1-11.fc37
URL: https://github.com/prometheus/node_exporter

Please consult the package updates policy before you issue an update to a stable branch: https://docs.fedoraproject.org/en-US/fesco/Updates_Policy/


More information about the service that created this bug can be found at: https://fedoraproject.org/wiki/Upstream_release_monitoring


Please keep in mind that with any upstream change, there may also be packaging changes that need to be made. Specifically, please remember that it is your responsibility to review the new version to ensure that the licensing is still correct and that no non-free or legally problematic items have been added upstream.


Based on the information from Anitya: https://release-monitoring.org/project/98081/


To change the monitoring settings for the project, please visit:
https://src.fedoraproject.org/rpms/golang-github-prometheus-node-exporter

Comment 1 Upstream Release Monitoring 2022-09-27 12:16:21 UTC
Releases retrieved: 1.4.0
Upstream release that is considered latest: 1.4.0
Current version/release in rawhide: 1.3.1-12.fc38
URL: https://github.com/prometheus/node_exporter

Please consult the package updates policy before you issue an update to a stable branch: https://docs.fedoraproject.org/en-US/fesco/Updates_Policy/


More information about the service that created this bug can be found at: https://docs.fedoraproject.org/en-US/package-maintainers/Upstream_Release_Monitoring


Please keep in mind that with any upstream change, there may also be packaging changes that need to be made. Specifically, please remember that it is your responsibility to review the new version to ensure that the licensing is still correct and that no non-free or legally problematic items have been added upstream.


Based on the information from Anitya: https://release-monitoring.org/project/98081/


To change the monitoring settings for the project, please visit:
https://src.fedoraproject.org/rpms/golang-github-prometheus-node-exporter

Comment 2 Pat Riehecky 2022-11-16 15:53:57 UTC
I'll confess some interest in having this updated to the current version.

Comment 3 Upstream Release Monitoring 2022-11-30 00:33:27 UTC
Releases retrieved: 1.4.1, 1.5.0
Upstream release that is considered latest: 1.5.0
Current version/release in rawhide: 1.3.1-12.fc38
URL: https://github.com/prometheus/node_exporter

Please consult the package updates policy before you issue an update to a stable branch: https://docs.fedoraproject.org/en-US/fesco/Updates_Policy/


More information about the service that created this bug can be found at: https://docs.fedoraproject.org/en-US/package-maintainers/Upstream_Release_Monitoring


Please keep in mind that with any upstream change, there may also be packaging changes that need to be made. Specifically, please remember that it is your responsibility to review the new version to ensure that the licensing is still correct and that no non-free or legally problematic items have been added upstream.


Based on the information from Anitya: https://release-monitoring.org/project/98081/


To change the monitoring settings for the project, please visit:
https://src.fedoraproject.org/rpms/golang-github-prometheus-node-exporter

Comment 4 Thomas Juberg 2022-12-23 20:24:28 UTC
Any chance we could get this updated for EPEL 8/9?

1.4.0 contains a fix for crash on EPYC processors https://github.com/prometheus/node_exporter/issues/2299 which I keep hitting.

1.4.1/1.5.0 contains security related fixes for crypto, net and exporter-toolkit

Comment 5 Mark E. Fuller 2023-05-10 22:24:40 UTC
I will do my best to work on this

Comment 6 Mark E. Fuller 2023-05-10 23:22:09 UTC
I've identified three new packages on which this is dependent (submitted for review)

There is then a build error for the package (https://download.copr.fedorainfracloud.org/results/fuller/go-sig_prometheus/fedora-rawhide-x86_64/05908811-golang-github-prometheus-node-exporter/builder-live.log.gz) which I don't have time to sort out yet - insight from interested parties is more than welcome

Comment 7 Elliott Sales de Andrade 2023-05-10 23:41:09 UTC
_build/src/github.com/prometheus/node_exporter/collector/netclass_rtnl_linux.go:89:21: msg.Attributes.Alias undefined (type *rtnetlink.LinkAttributes has no field or method Alias)
_build/src/github.com/prometheus/node_exporter/collector/netclass_rtnl_linux.go:90:30: msg.Attributes.Alias undefined (type *rtnetlink.LinkAttributes has no field or method Alias)
_build/src/github.com/prometheus/node_exporter/collector/netclass_rtnl_linux.go:101:71: msg.Attributes.Carrier undefined (type *rtnetlink.LinkAttributes has no field or method Carrier)
_build/src/github.com/prometheus/node_exporter/collector/netclass_rtnl_linux.go:102:99: msg.Attributes.CarrierChanges undefined (type *rtnetlink.LinkAttributes has no field or method CarrierChanges)
_build/src/github.com/prometheus/node_exporter/collector/netclass_rtnl_linux.go:103:105: msg.Attributes.CarrierUpCount undefined (type *rtnetlink.LinkAttributes has no field or method CarrierUpCount)
_build/src/github.com/prometheus/node_exporter/collector/netclass_rtnl_linux.go:104:109: msg.Attributes.CarrierDownCount undefined (type *rtnetlink.LinkAttributes has no field or method CarrierDownCount)
_build/src/github.com/prometheus/node_exporter/collector/netclass_rtnl_linux.go:107:87: msg.Attributes.LinkMode undefined (type *rtnetlink.LinkAttributes has no field or method LinkMode)
_build/src/github.com/prometheus/node_exporter/collector/netclass_rtnl_linux.go:108:71: msg.Attributes.LinkMode undefined (type *rtnetlink.LinkAttributes has no field or method LinkMode)
_build/src/github.com/prometheus/node_exporter/collector/netclass_rtnl_linux.go:120:83: msg.Attributes.NetDevGroup undefined (type *rtnetlink.LinkAttributes has no field or method NetDevGroup)
_build/src/github.com/prometheus/node_exporter/collector/netclass_rtnl_linux.go:121:99: msg.Attributes.TxQueueLen undefined (type *rtnetlink.LinkAttributes has no field or method TxQueueLen)
_build/src/github.com/prometheus/node_exporter/collector/netclass_rtnl_linux.go:121:99: too many errors

I didn't look into which netlink package node-exporter uses, but perhaps bug 2142810?

Comment 8 Mark E. Fuller 2023-05-11 14:38:25 UTC
Thanks for that - I identified and updated three libraries in rawhide to make some progress, including closing that bug.

I've opened a PR that needs review (and likely revision) to also get prometheus-procfs up-to-date: https://src.fedoraproject.org/rpms/golang-github-prometheus-procfs/pull-request/2

There are a further three new packages that require review:
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=2198968
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=2198971
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=2198973

The most recent build errors now appear to be with prometheus-procfs, which is confusing since it's updated in the COPR: https://copr.fedorainfracloud.org/coprs/fuller/go-sig_prometheus/build/5911523/

Comment 9 Mark E. Fuller 2023-05-17 21:07:46 UTC
Finally got the COPR build - should be in rawhide soon

Thanks for all the help

Comment 10 Fedora Update System 2023-05-18 14:23:51 UTC
FEDORA-2023-dfdd9630df has been submitted as an update to Fedora 39. https://bodhi.fedoraproject.org/updates/FEDORA-2023-dfdd9630df

Comment 11 Fedora Update System 2023-05-18 14:25:26 UTC
FEDORA-2023-dfdd9630df has been pushed to the Fedora 39 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 12 Pat Riehecky 2023-05-18 14:30:05 UTC
Can this be branched into the various EPELs?

Comment 13 Mark E. Fuller 2023-05-18 14:59:30 UTC
Probably EPEL9, maybe also EPEL8 - can you open a "branch and build" EPEL package request? https://docs.fedoraproject.org/en-US/epel/epel-package-request/

Feel free to assign me to it or ping me via email

I'll try to get it done next week


Note You need to log in before you can comment on or make changes to this bug.